Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Commit 2375eb8

Browse files
authored
GitHub Actions CI updates (#824)
- Prefer Ubuntu 20.04 to 18.04 and bump versions of actions. - Drop sympy version constraints for NMODL. - Use a debug (not release) build for coverage. - Related to nmodl#879.
1 parent cb38844 commit 2375eb8

File tree

4 files changed

+23
-17
lines changed

4 files changed

+23
-17
lines changed

.github/workflows/clang_cmake_format_check.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ on:
1010
jobs:
1111
build:
1212
name: clang-cmake-format-check
13-
runs-on: ubuntu-20.04
13+
runs-on: ubuntu-22.04
1414
steps:
1515
- name: Fetch repository
16-
uses: actions/checkout@v2
16+
uses: actions/checkout@v3
1717
- name: Install clang-format 11
1818
run: |
1919
sudo apt-get update

.github/workflows/coreneuron-ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131

3232
strategy:
3333
matrix:
34-
os: [ ubuntu-18.04, macOS-10.15 ]
34+
os: [ ubuntu-20.04, macOS-10.15 ]
3535
config:
3636
# Defaults: CORENRN_ENABLE_MPI=ON
3737
- {cmake_option: "-DCORENRN_ENABLE_MPI=ON -DCORENRN_ENABLE_DEBUG_CODE=ON", documentation: ON}
@@ -68,7 +68,7 @@ jobs:
6868
GCC_VERSION: ${{ matrix.config.gcc_version }}
6969

7070
- name: Set up Python3
71-
uses: actions/setup-python@v2
71+
uses: actions/setup-python@v3
7272
with:
7373
python-version: ${{ env.PYTHON_VERSION }}
7474
env:
@@ -92,9 +92,9 @@ jobs:
9292
- name: Install NMODL dependencies
9393
if: ${{ matrix.config.use_nmodl == 'ON' || matrix.config.use_ispc == 'ON' }}
9494
run: |
95-
python3 -m pip install --upgrade pip jinja2 pyyaml pytest "sympy<1.6";
95+
python3 -m pip install --upgrade pip jinja2 pyyaml pytest sympy
9696
97-
- uses: actions/checkout@v2
97+
- uses: actions/checkout@v3
9898

9999
- name: Install Python3 documentation dependencies
100100
if: ${{ startsWith(matrix.os, 'ubuntu') && matrix.config.documentation == 'ON' }}
@@ -162,7 +162,7 @@ jobs:
162162
echo ::set-output name=status::done
163163
164164
- name: Deploy 🚀
165-
uses: JamesIves/github-pages-deploy-action@4.1.5
165+
uses: JamesIves/github-pages-deploy-action@v4
166166
if: steps.documentation.outputs.status == 'done' && github.ref == 'refs/heads/master'
167167
with:
168168
branch: gh-pages # The branch the action should deploy to.

.github/workflows/coverage.yml

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,21 @@ on:
1515
- release/**
1616

1717
env:
18-
BUILD_TYPE: Release
19-
DEFAULT_PY_VERSION: 3.8
18+
CMAKE_BUILD_PARALLEL_LEVEL: 3
2019

2120
jobs:
2221
coverage:
23-
runs-on: ubuntu-18.04
22+
runs-on: ubuntu-20.04
2423
name: "Coverage Test"
2524
steps:
2625
- name: Install packages
2726
run: |
28-
sudo apt-get install doxygen bison flex libboost-all-dev libopenmpi-dev openmpi-bin python3-dev python3-pip lcov libfl-dev
27+
sudo apt-get update
28+
sudo apt-get install bison doxygen flex lcov libboost-all-dev \
29+
libopenmpi-dev libfl-dev ninja-build openmpi-bin python3-dev \
30+
python3-pip
2931
shell: bash
30-
- uses: actions/checkout@v2
32+
- uses: actions/checkout@v3
3133
with:
3234
fetch-depth: 2
3335
- name: Build and Test for Coverage
@@ -36,10 +38,15 @@ jobs:
3638
working-directory: ${{runner.workspace}}/CoreNeuron
3739
run: |
3840
mkdir build && cd build
39-
cmake .. -DCORENRN_ENABLE_MPI=ON -DCORENRN_ENABLE_DEBUG_CODE=ON -DCMAKE_C_FLAGS="-coverage -O0" -DCMAKE_CXX_FLAGS="-coverage -O0";
40-
make -j2
41+
cmake .. -G Ninja \
42+
-DCMAKE_BUILD_TYPE=Debug \
43+
-DCMAKE_C_FLAGS="-coverage" \
44+
-DCMAKE_CXX_FLAGS="-coverage" \
45+
-DCORENRN_ENABLE_MPI=ON \
46+
-DCORENRN_ENABLE_DEBUG_CODE=ON
47+
cmake --build .
4148
(cd ..; lcov --capture --initial --directory . --no-external --output-file build/coverage-base.info)
42-
make test
49+
ctest --output-on-failure
4350
(cd ..; lcov --capture --directory . --no-external --output-file build/coverage-run.info)
4451
lcov --add-tracefile coverage-base.info --add-tracefile coverage-run.info --output-file coverage-combined.info
4552
lcov --remove coverage-combined.info --output-file coverage.info "*/external/*"
@@ -55,4 +62,3 @@ jobs:
5562
shasum -a 256 -c codecov.SHA256SUM
5663
chmod +x codecov
5764
./codecov -f build/coverage.info
58-

.github/workflows/test-as-submodule.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
echo "Will use neuron branch: $nrn_branch"
6464
echo ::set-output name=neuron_branch::"${nrn_branch}"
6565
66-
- uses: actions/checkout@v2
66+
- uses: actions/checkout@v3
6767
name: Checkout NEURON
6868
with:
6969
path: nrn

0 commit comments

Comments
 (0)