Update NMODL submodule and update comments

Author: pramodk

CMake/OpenAccHelper.cmake

@@ -5,38 +5,47 @@
 # =============================================================================
 
 if(CORENRN_ENABLE_GPU)
-
+  # openacc needs to build static library in order to have global/routines
+  # working. See https://www.pgroup.com/userforum/viewtopic.php?t=5350
   set(COMPILE_LIBRARY_TYPE "STATIC")
 
+  # cuda unified memory support
   if(CORENRN_ENABLE_CUDA_UNIFIED_MEMORY)
     add_definitions(-DUNIFIED_MEMORY)
   endif()
 
+  # if user don't specify host compiler, use gcc from $PATH
   if(NOT CUDA_HOST_COMPILER)
     find_program(GCC_BIN gcc)
     set(CUDA_HOST_COMPILER ${GCC_BIN} CACHE FILEPATH "" FORCE)
   endif()
 
+  # various flags for PGI compiler with GPU build
   if(${CMAKE_C_COMPILER_ID} STREQUAL "PGI")
+    # workaround for old PGI version
     add_definitions(-DPG_ACC_BUGS)
     set(ACC_FLAGS "-acc")
+    # disable very verbose diagnosis messages
     set(PGI_DIAG_FLAGS "--diag_suppress 177")
+    # some of the mod files can have too many functions, increase inline level
     set(PGI_INLINE_FLAGS "-Minline=size:200,levels:10")
+    # C/C++ compiler flags
     set(CMAKE_C_FLAGS "${ACC_FLAGS} ${CMAKE_C_FLAGS}")
     set(CMAKE_CXX_FLAGS "${ACC_FLAGS} ${CMAKE_CXX_FLAGS} ${PGI_DIAG_FLAGS}")
+    # avoid PGI adding standard compliant "-A" flags
     set(CMAKE_CXX11_STANDARD_COMPILE_OPTION  --c++11)
     set(CMAKE_CXX14_STANDARD_COMPILE_OPTION  --c++14)
   else()
     message(WARNING "Non-PGI compiler : make sure to add required compiler flags to enable OpenACC")
   endif()
 
+  # find_cuda produce verbose messages : use new behavior to use _ROOT variables
   if(POLICY CMP0074)
     cmake_policy(SET CMP0074 NEW)
   endif()
   find_package(CUDA 5.0 REQUIRED)
   set(CUDA_SEPARABLE_COMPILATION ON)
   set(CUDA_PROPAGATE_HOST_FLAGS OFF)
-
   add_definitions(-DCUDA_PROFILING)
 else(CORENRN_ENABLE_GPU)
   # OpenACC pragmas are not guarded, disable all unknown pragm warnings

CMakeLists.txt

@@ -192,6 +192,7 @@ if(CORENRN_ENABLE_NMODL)
     set(CORENRN_NMODL_INCLUDE ${CMAKE_BINARY_DIR}/include)
   endif()
   include_directories(${CORENRN_NMODL_INCLUDE})
+  # set correct arguments for nmodl for cpu/gpu target
   if(CORENRN_ENABLE_GPU)
     set(CORENRN_NMODL_FLAGS "acc --oacc" CACHE STRING "Extra NMODL options such as passes")
   else()

coreneuron/mpi/nrnmpi.cpp

@@ -242,10 +242,10 @@ int nrnmpi_local_rank() {
 }
 
 /**
- * Return number of ranks launched on single shared memory node
+ * Return number of ranks running on single shared memory node
  *
  * We use MPI 3 MPI_Comm_split_type function and MPI_COMM_TYPE_SHARED key to
- * determine number of mpi ranks within a shared memory node..
+ * determine number of mpi ranks within a shared memory node.
  */
 int nrnmpi_local_size() {
     int local_size = 1;