Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Commit 52a586b

Browse files
authored
Fix CLI issue with nrnivmodl-core : verbose flag consumes an extra arg (#437)
* -V flag doesn't have argument and hence it should use `:` with getopts * Otherwise use of -V end up "eating" next argument from CLI
1 parent 6174048 commit 52a586b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

extra/nrnivmodl-core.in

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ params_BUILD_TYPE="@COMPILE_LIBRARY_TYPE@"
2929
MAKE_OPTIONS="MECHLIB_SUFFIX MOD2CPP_BINARY MOD2CPP_RUNTIME_FLAGS DEST_DIR INCFLAGS LINKFLAGS MODS_PATH VERBOSE BUILD_TYPE"
3030

3131
# parse CLI args
32-
while getopts "n:m:a:d:i:l:V:p:b:h" OPT; do
32+
while getopts "n:m:a:d:i:l:Vp:b:h" OPT; do
3333
case "$OPT" in
3434
n)
3535
# suffix for mechanism library
@@ -145,5 +145,4 @@ fi
145145
# run makefile
146146
echo "[INFO] Running: make -j$PARALLEL_BUILDS -f ${ROOT_DIR}/share/coreneuron/nrnivmodl_core_makefile ${make_params[@]}"
147147
make -j$PARALLEL_BUILDS -f "${ROOT_DIR}/share/coreneuron/nrnivmodl_core_makefile" "${make_params[@]}"
148-
149148
echo "[INFO] MOD files built successfully for CoreNEURON"

0 commit comments

Comments
 (0)