Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Commit 8adc992

Browse files
author
Omar Awile
authored
Merge pull request #207 from BlueBrain/fix/nrnivmodl-core
Fixed path in nrnivmodl-core script and improved code documentaiton
2 parents 1fe45cd + c63d4b9 commit 8adc992

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

extra/nrnivmodl-core

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,11 +66,16 @@ ls "${params_MODS_PATH:-.}"/*.mod || echo "Warning: No mods found!"
6666
make -j$PARALLELISM -f "${ROOTDIR}/share/coreneuron/nrnivmodl_core_makefile" "${make_params[@]}"
6767

6868
# Create a little script to call make install (relinks w right RPATH)
69+
# This should allow splitting the build of special-core into two phases:
70+
# 1. build the binary from the libcoreneuron.so library and the compiled models
71+
# 2. install into the final destination directory and relinking as necessary
72+
# TODO: instead of outputting a script we could output an options file which would be read by
73+
# this script when installing to ensure the same arguments are being used.
6974
echo "#!/bin/bash
7075
set -e
7176
[ \$# -eq 1 ] || { echo 'Required install destination. Syntax: ' \$(basename \$0) '<directory>'; false; }
7277
set -x
73-
make -f '${ROOTDIR}/bin/nrnivmodl_core_makefile' " $(printf "'%s' " "${make_params[@]}") "DESTDIR=\$1 install
78+
make -f '${ROOTDIR}/share/coreneuron/nrnivmodl_core_makefile' " $(printf "'%s' " "${make_params[@]}") "DESTDIR=\$1 install
7479
" > nrnivmech_install.sh
7580
chmod 755 nrnivmech_install.sh
7681

0 commit comments

Comments
 (0)