CMake improvement : clone hpc-coding-convention module automatically (#368)

 - if --recursive is not used, coding convention directory should exist
 - remove olf clang-format related cmake files

fixes #366

Author: pramodk

CMake/AddHpcCodingConvSubmodule.cmake

@@ -0,0 +1,28 @@
+# =============================================================================
+# Copyright (C) 2016-2020 Blue Brain Project
+#
+# See top-level LICENSE file for details.
+# =============================================================================
+
+include(FindPackageHandleStandardArgs)
+find_package(FindPkgConfig QUIET)
+
+find_path(
+    HpcCodingConv_PROJ
+  NAMES setup.cfg
+  PATHS "${CORENEURON_PROJECT_SOURCE_DIR}/CMake/hpc-coding-conventions/")
+
+find_package_handle_standard_args(HpcCodingConv REQUIRED_VARS HpcCodingConv_PROJ)
+
+if(NOT HpcCodingConv_FOUND)
+  find_package(Git 1.8.3 QUIET)
+  if(NOT ${GIT_FOUND})
+    message(FATAL_ERROR "git not found, clone repository with --recursive")
+  endif()
+  message(STATUS "Sub-module CMake/hpc-coding-conventions missing: running git submodule update --init")
+  execute_process(
+    COMMAND
+      ${GIT_EXECUTABLE} submodule update --init --
+      ${CORENEURON_PROJECT_SOURCE_DIR}/CMake/hpc-coding-conventions
+    WORKING_DIRECTORY ${CORENEURON_PROJECT_SOURCE_DIR})
+endif()

CMake/ClangFormatHelper.cmake

@@ -33,6 +33,13 @@ if(NOT CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
   set(CORENEURON_AS_SUBPROJECT ON)
 endif()
 
+# =============================================================================
+# Include cmake modules path
+# =============================================================================
+list(APPEND CMAKE_MODULE_PATH ${CORENEURON_PROJECT_SOURCE_DIR}/CMake
+            ${CORENEURON_PROJECT_SOURCE_DIR}/CMake/packages
+            ${CORENEURON_PROJECT_SOURCE_DIR}/CMake/config)
+
 # =============================================================================
 # HPC Coding Conventions
 # =============================================================================
@@ -43,15 +50,9 @@ set(CORENRN_ClangFormat_EXCLUDES_RE
 set(CORENRN_CMakeFormat_EXCLUDES_RE
     ".*/external/.*$$" ".*/CMake/packages/.*$$"
     CACHE STRING "list of regular expressions to exclude CMake files from formatting" FORCE)
+include(AddHpcCodingConvSubmodule)
 add_subdirectory(CMake/hpc-coding-conventions/cpp)
 
-# =============================================================================
-# Include cmake modules path
-# =============================================================================
-list(APPEND CMAKE_MODULE_PATH ${CORENEURON_PROJECT_SOURCE_DIR}/CMake
-            ${CORENEURON_PROJECT_SOURCE_DIR}/CMake/packages
-            ${CORENEURON_PROJECT_SOURCE_DIR}/CMake/config)
-
 # =============================================================================
 # Include common cmake modules
 # =============================================================================
@@ -62,6 +63,7 @@ include(SetRpath)
 include(CTest)
 include(AddRandom123Submodule)
 include(AddCLI11Submodule)
+
 add_subdirectory(${CORENEURON_PROJECT_SOURCE_DIR}/external/CLI11)
 
 # =============================================================================
@@ -106,7 +108,6 @@ endif()
 # Include cmake modules after cmake options
 # =============================================================================
 include(OpenAccHelper)
-include(ClangFormatHelper)
 
 # =============================================================================
 # Common dependencies