Skip to content
This repository was archived by the owner on Mar 20, 2023. It is now read-only.

Commit d6ae63f

Browse files
authored
Fix reporting tests under CI (#284)
* Adapt report config file to CLI11 * update dat files to 1.2 * Add reportinglib to DYLD_LIBRARY_PATH (MacOS compatibility) * Enabled reportinglib in CPU builds of coreneuron * Added rpath of reportinglib in nrnivmodl_core_makefile
1 parent 1ba2b4a commit d6ae63f

File tree

7 files changed

+21
-11
lines changed

7 files changed

+21
-11
lines changed

extra/nrnivmodl_core_makefile.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ endif
2929
# - @CORENRN_LINK_DEFS
3030
LDFLAGS = $(LINKFLAGS) @CORENRN_LINK_DEFS@
3131
CORENRNLIB_FLAGS = -L$(libdir) -lcoreneuron
32+
CORENRNLIB_FLAGS += $(if @reportinglib_LIB_DIR@, -W$(subst ;, -W,l,-rpath,@reportinglib_LIB_DIR@),)
3233
OS_NAME := $(shell uname)
3334
_cm =,
3435

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
--outpath ./
2-
--datpath @CMAKE_CURRENT_SOURCE_DIR@/ring/
3-
--tstop 10.000000
4-
--dt 0.025000
5-
--forwardskip 0.000000
6-
--prcellgid -1
7-
--report-conf @CMAKE_CURRENT_SOURCE_DIR@/reportinglib/1.report
8-
--cell-permute 0
1+
outpath = ./
2+
datpath = @CMAKE_CURRENT_SOURCE_DIR@/ring/
3+
tstop = 10.000000
4+
dt = 0.025000
5+
forwardskip = 0.000000
6+
prcellgid = -1
7+
report-conf = @CMAKE_CURRENT_SOURCE_DIR@/reportinglib/1.report
8+
cell-permute = 0

tests/integration/reportinglib/reporting_test.sh.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#! /bin/sh
22

3-
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:@CMAKE_BINARY_DIR@/lib:@reportinglib_LIB_DIR@
43
export OMP_NUM_THREADS=1
54
@SRUN_PREFIX@ @CMAKE_BINARY_DIR@/bin/@CMAKE_SYSTEM_PROCESSOR@/special-core --mpi --read-config @[email protected]
65
chmod +x ./@[email protected]

tests/integration/ring/12_3.dat

1 Byte
Binary file not shown.

tests/integration/ring/13_3.dat

1 Byte
Binary file not shown.

tests/jenkins/install_coreneuron.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ set -e
44

55
source ${JENKINS_DIR:-.}/_env_setup.sh
66

7+
# Install reportinglib with spack to run reportinglib tests
8+
spack install reportinglib%intel
9+
reportinglib_dir=$(spack cd -i reportinglib%intel && pwd)
10+
711
CORENRN_TYPE="$1"
812

913
if [ "${CORENRN_TYPE}" = "GPU-non-unified" ] || [ "${CORENRN_TYPE}" = "GPU-unified" ]; then
@@ -63,6 +67,8 @@ elif [ "${CORENRN_TYPE}" = "AoS" ] || [ "${CORENRN_TYPE}" = "SoA" ]; then
6367
-DCMAKE_BUILD_TYPE=Debug \
6468
-DCORENRN_ENABLE_SOA=$CORENRN_ENABLE_SOA \
6569
-DCORENRN_ENABLE_OPENMP=$ENABLE_OPENMP \
70+
-DCORENRN_ENABLE_REPORTINGLIB=ON \
71+
-DCMAKE_PREFIX_PATH=$reportinglib_dir \
6672
-DTEST_MPI_EXEC_BIN="mpirun" \
6773
-DTEST_EXEC_PREFIX="mpirun;-n;2" \
6874
-DAUTO_TEST_WITH_SLURM=OFF \

tests/jenkins/run_neuron_direct.sh

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22

33
set -e
44
source ${JENKINS_DIR:-.}/_env_setup.sh
5-
module load neuron/develop intel
5+
module purge
6+
module load unstable neuron/develop intel hpe-mpi
67

78
set -x
89
CORENRN_TYPE="$1"
@@ -17,8 +18,11 @@ nrnivmodl ../tests/jenkins/mod
1718
nrnivmodl-core ../tests/jenkins/mod
1819
ls -la x86_64
1920

21+
# Unload intel module to avoid issue whith mpirun
22+
module unload intel
23+
2024
# run test sim with external mechanism
21-
python $WORKSPACE/tests/jenkins/neuron_direct.py
25+
mpirun -n 1 nrniv -python $WORKSPACE/tests/jenkins/neuron_direct.py -mpi
2226

2327
# remove build directory
2428
cd -

0 commit comments

Comments
 (0)