Skip to content

Commit 9223ba9

Browse files
CI: Use commitlint to check PR titles (#18)
1 parent 901263e commit 9223ba9

File tree

6 files changed

+22
-5
lines changed

6 files changed

+22
-5
lines changed

.codespellrc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
[codespell]
2+
skip = .git/*

.github/workflows/commitlint.yml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
name: Check PR titles using commitlint
2+
3+
on:
4+
pull_request:
5+
types: [edited, opened, reopened, synchronize]
6+
7+
jobs:
8+
check-pr-title:
9+
name: Check PR title
10+
runs-on: ubuntu-latest
11+
steps:
12+
- uses: actions/checkout@master
13+
- uses: actions/setup-node@v2
14+
with:
15+
node-version: '14'
16+
- run: npm install -g --force commitlint @commitlint/cli commitlint-plugin-cleanfeet
17+
- run: npm install conventional-changelog-conventionalcommits
18+
- run: touch .git/COMMIT_EDITMSG
19+
- run: echo ${{ github.event.pull_request.title }} | commitlint

dir_content_diff/base_comparators.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
class BaseComparator(ABC):
2222
"""Base Comparator class."""
2323

24-
# pylint: disable=no-self-use
25-
2624
def __init__(
2725
self,
2826
default_load_kwargs=None,

tests/test_base.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"""Test the base features of the ``dir-content-diff`` package."""
22
# pylint: disable=missing-function-docstring
3-
# pylint: disable=no-self-use
43
# pylint: disable=redefined-outer-name
54
# pylint: disable=unused-argument
65
# pylint: disable=use-implicit-booleaness-not-comparison

tests/test_pandas.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
"""Test the Pandas extension of the ``dir-content-diff`` package."""
22
# pylint: disable=missing-function-docstring
3-
# pylint: disable=no-self-use
43
# pylint: disable=redefined-outer-name
54
# pylint: disable=unused-argument
65
# pylint: disable=use-implicit-booleaness-not-comparison

tox.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ commands =
4141
basepython = python3.8
4242
deps =
4343
pre-commit
44-
pylint
44+
pylint>=2.14
4545
commands =
4646
pre-commit run --all-files --show-diff-on-failure
4747
pylint -j {env:PYLINT_NPROCS:1} {[base]files}

0 commit comments

Comments
 (0)