Theme Swapping

[BlueMystical]

Hi there.
I just made some progress on the requested feature for on the fly Theme Swapping

On this Example:

1. Theme detected automatically, Dark Mode On at Windows Settings.
2. Swap theme button clicked. Dark to Clear Mode.
3. Swap theme button clicked. Clear to Dark Mode.

Ther are still some colors that are refusing to change, gotta find them, but it works.
Will commit this progress in a few.

Regards.

[jukfiuune]

Very nice! Question - How exactly do you change the color of the scroll bars to the dark one? i remember just setting immersivedarkmode to 1 just changed the titlebar style, not the scrollbars. Thanks

[BlueMystical]

i use a combination of the SetWindowTheme and DwmSetWindowAttribute Win32 APIs, you can check the actual code here.

[BlueMystical]

Good news!

On the fly theme swapping is now fully enabled, see the Example project.
Also the ComboBox Control is now fully themed, the 'FlatComboBox' is no longer needed.

Regards.

[MagicAndre1981]

for me it doesn't work. Do I have to enable a setting to react to theme change in windows? or do you mean the user can swap the theme on its own and this works on the fly?

[MagicAndre1981]

ok, I can call ApplyTheme(true); to force dark mode no matter which theme is selected so my request from #30 is implemeted. Great 🥳

[BlueMystical]

Yep, the ApplyTheme method is the way, check the 'Theme Swap' button on the Example Form.

[MagicAndre1981]

now that I can force a theme can we also handle theme change of windows settings app? I tried to override WndProc and handle WM_THEMECHANGED but the code is never executed. Is changing dark/light mode raising a different message?

[kachnitata]

hi, one of the recent commits seems to have a little side effect.

with using

switch (control.GetType().Name)

instead of former is operator, now the inherited controls do not work as expected.

I am using a Control derived from TabControl that allows to close individual tabs and now it does not look nice:

are there any plans to handle such cases?

[kachnitata]

I made a mistake when pulling the current version. So context menus are ok now, but for the inherited control issue I suggest using

switch (GetKnownUIType(control.GetType()).Name)
and

    /// <summary>
    /// in order to be able to use Type.Name we have to find a "known" type
    /// this handles the cases of custom controls derived from those provided by WinForms or DarkModeForms
    /// so we try to find the closest ancestor belonging to System.Windows.Forms or DarkModeForms
    /// if not found, we just return the current type
    /// </summary>
    private static Type GetKnownUIType(Type t0)
    {
      Type t = t0;
      while (t != typeof(Object) && !t.Namespace.StartsWith("System.Windows.Forms") && !t.Namespace.Equals("DarkModeForms")) t = t.BaseType;
      return t == typeof(Object) ? t0 : t;
    }

please consider it, or let me know if you suggest other solution
regards

[kachnitata]

possible alternative would be some kind of "event handler" for extending the functionality for unhandled types, or dictionary which would say "treat type X as Y" or something like that....

[kachnitata]

Actually, I start liking the idea... The user would call a Register method which would record into a Dictionary the type name pair. It would be looked up before (from) the Case statement. Would be safer and more transparent than my current solution. Should I elaborate and post the code?

[kachnitata]

In case the user does not Register anything, the dictionary is empty and everything works unmodified

[BlueMystical]

This issue seems to be escalating too high, maybe i just revert to the pile of IFs...

[BlueMystical]

Alright, v1.8.3 reverts to the old trusty pile of IFs
Hope this fixes the issues
Regards.

[BlueMystical]

and sorry for the late, i had a lot of RL work lately.

[BlueMystical]

By the way @kachnitata just added an optional Close Tab button on the FlatTab Control, check it out !

Feel free to modify it as you need in your own project

[kachnitata]

Wow, thank you !