Bug fix with 5.7 authentication and other issues

An issue on MySQL 5.7 was found with the authentication packet where a malformed packet would be sent.
Fixed issue authentication seed data would be hardcoded to utf-8 instead of following the server language connection settings.

Author: Chris Board

AndroidMySQLConnector/build.gradle

@@ -25,12 +25,12 @@ group 'com.BoardiesITSolutions'
 
 
 android {
-    compileSdkVersion 27
+    compileSdkVersion 28
     defaultConfig {
         //applicationId "com.BoardiesITSolutions.AndroidMySQLConnector"
         minSdkVersion 19
-        targetSdkVersion 27
-        versionCode 9
+        targetSdkVersion 28
+        versionCode 14
         versionName "0.23"
         testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
     }
@@ -88,7 +88,7 @@ def getArtifactFullPath() {
 
 dependencies {
     implementation fileTree(dir: 'libs', include: ['*.jar'])
-    implementation 'com.android.support:appcompat-v7:27.1.1'
+    implementation 'com.android.support:appcompat-v7:28.0.0-rc02'
     testImplementation 'junit:junit:4.12'
     androidTestImplementation 'com.android.support.test:runner:1.0.2'
     androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.2'

AndroidMySQLConnector/src/main/java/com/BoardiesITSolutions/AndroidMySQLConnector/PacketManager/AuthResponse.java

@@ -96,7 +96,7 @@ private void createAuthenticationPacket() throws IOException
                         String authSalt2 = this.mysqlConn.getAuthSalt2();
                         String seed = this.mysqlConn.getAuthSalt() + this.mysqlConn.getAuthSalt2();
                         //String updateSeed = this.seed.substring(0, 20);
-                        byte[] bytes = seed.getBytes(Charset.forName("UTF-8"));
+                        byte[] bytes = seed.getBytes(charset);
                         String temp = readString(bytes);
                         byte[] password = scramblePassword(this.mysqlConn.getPassword(), temp);
 
@@ -111,9 +111,13 @@ private void createAuthenticationPacket() throws IOException
                         //any error either we receive an EOF packet but running show processlist from the server itself
                         //shows unauthenticated user. Therefore, if we're not connecting to a default database
                         //add the null terminator to the password, if we are using a default database don't add the null terminator
+                        //but this also only appears to be required on certain MySQL Versions.
                         if ((this.mysqlConn.getDatabase() == null) || this.mysqlConn.getDatabase().length() == 0)
                         {
-                            dataOutPacket.writeByte(0); //Write the null terminator
+                            if (!mysqlConn.getServerVersion().startsWith("5.7"))
+                            {
+                                dataOutPacket.writeByte(0); //Write the null terminator
+                            }
                         }
 
                     }

build.gradle

@@ -16,7 +16,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.1.3'
+        classpath 'com.android.tools.build:gradle:3.1.4'
         if (!publishToMavenLocal) {
             classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'
         }