fix(lint): fix F403 and F811 issues (#474)

Author: jonperron

boaviztapi/routers/cloud_router.py

@@ -44,7 +44,7 @@ async def get_archetype_config(
 
 
 @cloud_router.post("/instance", description=cloud_provider_description)
-async def instance_cloud_impact(
+async def instance_cloud_impact_from_configuration(
     cloud_instance: Cloud = Body(None, examples=[cloud_example]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -71,7 +71,7 @@ async def instance_cloud_impact(
 
 
 @cloud_router.get("/instance", description=cloud_provider_description)
-async def instance_cloud_impact(
+async def instance_cloud_impact_from_model(
     provider: str = Query(
         config.default_cloud_provider, examples=[config.default_cloud_provider]
     ),

boaviztapi/routers/component_router.py

@@ -65,7 +65,7 @@ async def cpu_archetype_config(
 
 
 @component_router.post("/cpu", description=cpu_description)
-async def cpu_impact_bottom_up(
+async def cpu_impact_bottom_up_from_configuration(
     cpu: CPU = Body(None, openapi_examples=components_examples_openapi["cpu"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -85,7 +85,7 @@ async def cpu_impact_bottom_up(
 
 
 @component_router.get("/cpu", description=cpu_description)
-async def cpu_impact_bottom_up(
+async def cpu_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_cpu,
@@ -116,7 +116,7 @@ async def gpu_archetype_config(
 
 
 @component_router.post("/gpu", description=gpu_description)
-async def gpu_impact_bottom_up(
+async def gpu_impact_bottom_up_from_configuration(
     gpu: GPU = Body(None, openapi_examples=components_examples_openapi["gpu"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -136,7 +136,7 @@ async def gpu_impact_bottom_up(
 
 
 @component_router.get("/gpu", description=gpu_description)
-async def gpu_impact_bottom_up(
+async def gpu_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_gpu,
@@ -169,7 +169,7 @@ async def ram_archetype_config(
 
 
 @component_router.post("/ram", description=ram_description)
-async def ram_impact_bottom_up(
+async def ram_impact_bottom_up_from_configuration(
     ram: RAM = Body(None, openapi_examples=components_examples_openapi["ram"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -189,7 +189,7 @@ async def ram_impact_bottom_up(
 
 
 @component_router.get("/ram", description=ram_description)
-async def ram_impact_bottom_up(
+async def ram_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_ram,
@@ -222,7 +222,7 @@ async def ssd_archetype_config(
 
 
 @component_router.post("/ssd", description=ssd_description)
-async def disk_impact_bottom_up(
+async def ssd_disk_impact_bottom_up_from_configuration(
     disk: Disk = Body(None, openapi_examples=components_examples_openapi["ssd"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -243,7 +243,7 @@ async def disk_impact_bottom_up(
 
 
 @component_router.get("/ssd", description=ssd_description)
-async def disk_impact_bottom_up(
+async def ssd_disk_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_ssd,
@@ -278,7 +278,7 @@ async def hdd_archetype_config(
 
 
 @component_router.post("/hdd", description=hdd_description)
-async def disk_impact_bottom_up(
+async def hdd_disk_impact_bottom_up_from_configuration(
     disk: Disk = Body(None, openapi_examples=components_examples_openapi["hdd"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -299,7 +299,7 @@ async def disk_impact_bottom_up(
 
 
 @component_router.get("/hdd", description=hdd_description)
-async def disk_impact_bottom_up(
+async def hdd_disk_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_hdd,
@@ -336,7 +336,7 @@ async def motherboard_archetype_config(
 
 
 @component_router.post("/motherboard", description=motherboard_description)
-async def motherboard_impact_bottom_up(
+async def motherboard_impact_bottom_up_from_configuration(
     motherboard: Motherboard = Body(
         None, openapi_examples=components_examples_openapi["motherboard"]
     ),
@@ -355,7 +355,7 @@ async def motherboard_impact_bottom_up(
 
 
 @component_router.get("/motherboard", description=motherboard_description)
-async def motherboard_impact_bottom_up(
+async def motherboard_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     criteria: List[str] = Query(config.default_criteria),
@@ -387,7 +387,7 @@ async def power_supply_archetype_config(
 
 
 @component_router.post("/power_supply", description=power_supply_description)
-async def power_supply_impact_bottom_up(
+async def power_supply_impact_bottom_up_from_configuration(
     power_supply: PowerSupply = Body(
         None, openapi_examples=components_examples_openapi["power_supply"]
     ),
@@ -412,7 +412,7 @@ async def power_supply_impact_bottom_up(
 
 
 @component_router.get("/power_supply", description=power_supply_description)
-async def power_supply_impact_bottom_up(
+async def power_supply_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_power_supply,
@@ -448,7 +448,7 @@ async def case_archetype_config(
 
 
 @component_router.post("/case", description=case_description)
-async def case_impact_bottom_up(
+async def case_impact_bottom_up_from_configuration(
     case: Case = Body(None, openapi_examples=components_examples_openapi["case"]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -468,7 +468,7 @@ async def case_impact_bottom_up(
 
 
 @component_router.get("/case", description=case_description)
-async def case_impact_bottom_up(
+async def case_impact_bottom_up_from_model(
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
     archetype: str = config.default_case,

boaviztapi/routers/iot_router.py

@@ -30,7 +30,7 @@ async def get_archetype_config(
 
 
 @iot.post("/iot_device", description="")
-async def iot_device_impact(
+async def iot_device_impact_from_configuration(
     iot: IoT = Body(None, examples=[""]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -47,7 +47,7 @@ async def iot_device_impact(
 
 
 @iot.get("/iot_device", description="")
-async def iot_device_impact(
+async def iot_device_impact_from_model(
     archetype: str = config.default_iot_device,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,

boaviztapi/routers/peripheral_router.py

@@ -51,7 +51,7 @@ async def monitor_get_archetype_config(
 
 
 @peripheral_router.post("/monitor", description=peripheral_description)
-async def monitor_impact(
+async def monitor_impact_from_configuration(
     monitor: Monitor = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -68,7 +68,7 @@ async def monitor_impact(
 
 
 @peripheral_router.get("/monitor", description=peripheral_description)
-async def monitor_impact(
+async def monitor_impact_from_model(
     archetype: str = config.default_monitor,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -100,7 +100,7 @@ async def usb_stick_get_archetype_config(
 
 
 @peripheral_router.post("/usb_stick", description=peripheral_description)
-async def usb_stick_impact(
+async def usb_stick_impact_from_configuration(
     usb_stick: UsbStick = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -117,7 +117,7 @@ async def usb_stick_impact(
 
 
 @peripheral_router.get("/usb_stick", description=peripheral_description)
-async def usb_stick_impact(
+async def usb_stick_impact_from_model(
     archetype: str = config.default_usb_stick,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -149,7 +149,7 @@ async def external_ssd_get_archetype_config(
 
 
 @peripheral_router.post("/external_ssd", description=peripheral_description)
-async def external_ssd_impact(
+async def external_ssd_impact_from_configuration(
     external_ssd: ExternalSSD = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -166,7 +166,7 @@ async def external_ssd_impact(
 
 
 @peripheral_router.get("/external_ssd", description=peripheral_description)
-async def external_ssd_impact(
+async def external_ssd_impact_from_model(
     archetype: str = config.default_external_ssd,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -198,7 +198,7 @@ async def external_hdd_get_archetype_config(
 
 
 @peripheral_router.post("/external_hdd", description=peripheral_description)
-async def external_hdd_impact(
+async def external_hdd_impact_from_configuration(
     external_hdd: ExternalHDD = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -215,7 +215,7 @@ async def external_hdd_impact(
 
 
 @peripheral_router.get("/external_hdd", description=peripheral_description)
-async def external_hdd_impact(
+async def external_hdd_impact_from_model(
     archetype: str = config.default_external_hdd,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -264,7 +264,7 @@ async def vr_controller_impact_from_configuration(
 
 
 @peripheral_router.get("/vr_controller", description=peripheral_description)
-async def vr_controller_impact(
+async def vr_controller_impact_from_model(
     archetype: str = config.default_vr_controller,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,

boaviztapi/routers/terminal_router.py

@@ -58,7 +58,7 @@ async def laptop_get_archetype_config(
 
 
 @terminal_router.post("/laptop", description=terminal_description)
-async def laptop_impact(
+async def laptop_impact_from_configuration(
     laptop: Laptop = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -75,7 +75,7 @@ async def laptop_impact(
 
 
 @terminal_router.get("/laptop", description=terminal_description)
-async def laptop_impact(
+async def laptop_impact_from_model(
     archetype: str = config.default_laptop,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -103,7 +103,7 @@ async def desktop_get_archetype_config(
 
 
 @terminal_router.post("/desktop", description=terminal_description)
-async def desktop_impact(
+async def desktop_impact_from_configuration(
     desktop: Desktop = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -120,7 +120,7 @@ async def desktop_impact(
 
 
 @terminal_router.get("/desktop", description=terminal_description)
-async def desktop_impact(
+async def desktop_impact_from_model(
     archetype: str = config.default_desktop,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -150,7 +150,7 @@ async def smartphone_get_archetype_config(
 
 
 @terminal_router.post("/smartphone", description=terminal_description)
-async def smartphone_impact(
+async def smartphone_impact_from_configuration(
     smartphone: Smartphone = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -167,7 +167,7 @@ async def smartphone_impact(
 
 
 @terminal_router.get("/smartphone", description=terminal_description)
-async def smartphone_impact(
+async def smartphone_impact_from_model(
     archetype: str = config.default_smartphone,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -195,7 +195,7 @@ async def tablet_get_archetype_config(
 
 
 @terminal_router.post("/tablet", description=terminal_description)
-async def tablet_impact(
+async def tablet_impact_from_configuration(
     tablet: Tablet = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -212,7 +212,7 @@ async def tablet_impact(
 
 
 @terminal_router.get("/tablet", description=terminal_description)
-async def tablet_impact(
+async def tablet_impact_from_model(
     archetype: str = config.default_tablet,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -242,7 +242,7 @@ async def television_get_archetype_config(
 
 
 @terminal_router.post("/television", description=terminal_description)
-async def television_impact(
+async def television_impact_from_configuration(
     television: Television = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -259,7 +259,7 @@ async def television_impact(
 
 
 @terminal_router.get("/television", description=terminal_description)
-async def television_impact(
+async def television_impact_from_model(
     archetype: str = config.default_television,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -287,7 +287,7 @@ async def box_get_archetype_config(
 
 
 @terminal_router.post("/box", description=terminal_description)
-async def box_impact(
+async def box_impact_from_configuration(
     box: Box = Body(None, examples=[end_user_terminal]),
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -304,7 +304,7 @@ async def box_impact(
 
 
 @terminal_router.get("/box", description=terminal_description)
-async def box_impact(
+async def box_impact_from_model(
     archetype: str = config.default_box,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,
@@ -351,7 +351,7 @@ async def vr_headset_impact_from_configuration(
 
 
 @terminal_router.get("/vr_headset", description=terminal_description)
-async def vr_headset_impact(
+async def vr_headset_impact_from_model(
     archetype: str = config.default_vr_headset,
     verbose: bool = True,
     duration: Optional[float] = config.default_duration,

pyproject.toml

@@ -64,13 +64,6 @@ line-length = 88
 target-version = "py313"
 force-exclude = true
 
-[tool.ruff.lint]
-# TODO - uncomment these ignores one by one and fix in separate PRs
-ignore = [
-    "F403", # Unable to detect undefined names
-    "F811", # Redefinition of unused
-]
-
 [tool.ruff.format]
 quote-style = "double"
 indent-style = "space"