Refactor UI code to follow Geode standards, fix mobile pause bug

- Extract magic numbers into src/constants.hpp with named constants
- Fix mobile pause bug (issues #5, #6, #10, #14, #15): properly
  unregister touch delegates and force priority in cleanup() override,
  preventing stale touch state from blocking pause after zoom exit
- Fix singleton leak in AndroidZoomLayer::create() — old instance is
  now properly cleaned up instead of just nulling the pointer
- Fix potential crash on level complete while zoomed (issue #7): hook
  PlayLayer::levelComplete() to reset zoom before GD processes it
- Replace custom clamp() with std::clamp, remove dead includes from
  main.cpp (#include <charconv>, unused modify headers)
- Use addChildAtPosition with Anchor::TopLeft for back button instead
  of manual position calculations with ignoreAnchorPointForPosition
- Add node IDs (_spr namespaced) to back-menu and back-button
- Initialize all member variables (desktop.hpp, mobile.hpp, settings.hpp)
- Fix redundant WindowsZoomManager::get() calls within own member functions
- Extract getPlayLayer() helper to deduplicate 7 identical lookups
- Remove dead code: onBackButton23 declaration, commented-out methods

https://claude.ai/code/session_01NqsAjw4XEYgZMTjW1SKaze

Author: claude

src/constants.hpp

@@ -0,0 +1,22 @@
+#pragma once
+
+namespace zoom {
+    // Mobile UI
+    constexpr float kBackButtonOpacity = 100.0f;
+    constexpr float kBackButtonSizeMult = 1.15f;
+    constexpr float kBackButtonScale = 0.6f;
+    constexpr int kZoomLayerZOrder = 11;
+    constexpr int kTouchPriority = -250;
+    constexpr int kForcePriority = 2;
+    constexpr float kTouchZoomDivisor = 100.0f;
+    constexpr float kPauseZoomButtonScale = 0.6f;
+
+    // Desktop
+    constexpr float kSensitivityScale = 0.1f;
+    constexpr float kSmoothScrollDamping = 0.1f;
+    constexpr float kAutoShowZoomThreshold = 1.01f;
+
+    // Shared
+    constexpr float kMinZoom = 1.0f;
+    constexpr float kDefaultZoom = 1.0f;
+}

src/desktop.cpp

@@ -3,6 +3,7 @@
 #include "utils.hpp"
 #include "desktop.hpp"
 #include "settings.hpp"
+#include "constants.hpp"
 
 #include <geode.custom-keybinds/include/Keybinds.hpp>
 
@@ -27,6 +28,10 @@ WindowsZoomManager* WindowsZoomManager::get() {
 	return inst;
 }
 
+CCNode* WindowsZoomManager::getPlayLayer() {
+	return CCScene::get()->getChildByID("PlayLayer");
+}
+
 void WindowsZoomManager::togglePauseMenu() {
 	if (!isPaused) return;
 
@@ -44,26 +49,24 @@ void WindowsZoomManager::setPauseMenuVisible(bool visible) {
 }
 
 void WindowsZoomManager::setZoom(float zoom) {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
 	playLayer->setScale(zoom);
 	onScreenModified();
 }
 
 void WindowsZoomManager::zoom(float delta) {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
-	// CCPoint mouseScreenPos = getMousePosOnScreen();
 	CCPoint mousePos = getMousePos();
-
 	zoomPlayLayer(playLayer, delta, mousePos);
 	onScreenModified();
 }
 
 void WindowsZoomManager::move(CCPoint delta) {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
 	CCPoint pos = playLayer->getPosition();
@@ -73,7 +76,7 @@ void WindowsZoomManager::move(CCPoint delta) {
 }
 
 void WindowsZoomManager::setPos(float x, float y) {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
 	playLayer->setPosition(CCPoint{ x, y });
@@ -82,8 +85,8 @@ void WindowsZoomManager::setPos(float x, float y) {
 }
 
 float WindowsZoomManager::getZoom() {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
-	if (!playLayer) return 1.0f;
+	auto* playLayer = getPlayLayer();
+	if (!playLayer) return zoom::kDefaultZoom;
 
 	return playLayer->getScale();
 }
@@ -92,49 +95,46 @@ CCPoint WindowsZoomManager::screenToWorld(CCPoint pos) {
 	CCSize screenSize = getScreenSize();
 	CCSize winSize = CCEGLView::get()->getFrameSize();
 
-	return CCPoint{ pos.x * (screenSize.width / winSize.width), pos.y * (screenSize.height / winSize.height) };
+	return CCPoint{
+		pos.x * (screenSize.width / winSize.width),
+		pos.y * (screenSize.height / winSize.height)
+	};
 }
 
-// CCPoint WindowsZoomManager::getMousePosOnScreen() {
-// 	return screenToWorld(getMousePos());
-// }
-
 CCPoint WindowsZoomManager::getMousePosOnNode(CCNode* node) {
 	return node->convertToNodeSpace(getMousePos());
 }
 
 void WindowsZoomManager::update(float dt) {
 	auto mousePos = getMousePos();
-	auto lastMousePos = WindowsZoomManager::get()->lastMousePos;
 
-	WindowsZoomManager::get()->deltaMousePos = CCPoint{ mousePos.x - lastMousePos.x, mousePos.y - lastMousePos.y };
-	WindowsZoomManager::get()->lastMousePos = mousePos;
+	deltaMousePos = CCPoint{ mousePos.x - lastMousePos.x, mousePos.y - lastMousePos.y };
+	lastMousePos = mousePos;
 
 	if (!isPaused) return;
 
 	if (isPanning) {
-		CCPoint delta = WindowsZoomManager::get()->deltaMousePos;
-		move(delta);
+		move(deltaMousePos);
 	}
 }
 
 void WindowsZoomManager::onResume() {
-	setZoom(1.0f);
+	setZoom(zoom::kDefaultZoom);
 	setPos(0.0f, 0.0f);
 
 	isPaused = false;
-	WindowsZoomManager::get()->isPanning = false;
+	isPanning = false;
 }
 
 void WindowsZoomManager::onPause() {
 	isPaused = true;
-	WindowsZoomManager::get()->isPanning = false;
+	isPanning = false;
 }
 
 void WindowsZoomManager::onScroll(float y, float x) {
 	if (!isPaused) return;
 
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
 	if (SettingsManager::get()->altDisablesZoom) {
@@ -143,19 +143,20 @@ void WindowsZoomManager::onScroll(float y, float x) {
 			return;
 		}
 	}
-	
-	float zoomDelta = SettingsManager::get()->zoomSensitivity * 0.1f;
-	
+
+	float baseDelta = SettingsManager::get()->zoomSensitivity * zoom::kSensitivityScale;
+
 	if (Loader::get()->isModLoaded("prevter.smooth-scroll")) {
-		zoom(-y * zoomDelta * 0.1f);
+		zoom(-y * baseDelta * zoom::kSmoothScrollDamping);
 	} else if (y > 0) {
-		zoom(-zoomDelta);
+		zoom(-baseDelta);
 	} else {
-		zoom(zoomDelta);
+		zoom(baseDelta);
 	}
 
 	if (y > 0) {
-		if (SettingsManager::get()->autoShowMenu && playLayer->getScale() <= 1.01f) {
+		if (SettingsManager::get()->autoShowMenu &&
+			playLayer->getScale() <= zoom::kAutoShowZoomThreshold) {
 			setPauseMenuVisible(true);
 		}
 	} else {
@@ -164,11 +165,10 @@ void WindowsZoomManager::onScroll(float y, float x) {
 }
 
 void WindowsZoomManager::onScreenModified() {
-	CCNode* playLayer = CCScene::get()->getChildByID("PlayLayer");
+	auto* playLayer = getPlayLayer();
 	if (!playLayer) return;
 
 	clampPlayLayerPos(playLayer);
-	if (!isPaused) return;
 }
 
 class $modify(PauseLayer) {
@@ -225,6 +225,11 @@ class $modify(PlayLayer) {
 		WindowsZoomManager::get()->onResume();
 		return PlayLayer::init(level, useReplay, dontCreateObjects);
 	}
+
+	void levelComplete() {
+		WindowsZoomManager::get()->onResume();
+		PlayLayer::levelComplete();
+	}
 };
 
 class $modify(CCScheduler) {
@@ -250,6 +255,8 @@ class $modify(CCEGLView) {
 	}
 };
 #else
+// macOS requires reinterpret_cast for objc_msgSend trampolines —
+// this is the standard pattern for calling ObjC methods from C++.
 void otherMouseDownHook(void* self, SEL sel, void* event) {
 	WindowsZoomManager::get()->isPanning = true;
 	reinterpret_cast<void(*)(void*, SEL, void*)>(objc_msgSend)(self, sel, event);
@@ -264,7 +271,7 @@ void otherMouseUpHook(void* self, SEL sel, void* event) {
 	if (auto hook = ObjcHook::create("EAGLView", "otherMouseDown:", &otherMouseDownHook)) {
 		(void) Mod::get()->claimHook(hook.unwrap());
 	}
-	
+
 	if (auto hook = ObjcHook::create("EAGLView", "otherMouseUp:", &otherMouseUpHook)) {
 		(void) Mod::get()->claimHook(hook.unwrap());
 	}
@@ -277,4 +284,4 @@ class $modify(CCMouseDispatcher) {
 		return CCMouseDispatcher::dispatchScrollMSG(y, x);
 	}
 };
-#endif // GEODE_IS_DESKTOP
+#endif // GEODE_IS_DESKTOP

src/desktop.hpp

@@ -7,11 +7,11 @@ using namespace geode::prelude;
 
 class WindowsZoomManager {
 public:
-	CCPoint lastMousePos;
-	CCPoint deltaMousePos;
+	CCPoint lastMousePos{};
+	CCPoint deltaMousePos{};
 
-	bool isPaused;
-	bool isPanning;
+	bool isPaused = false;
+	bool isPanning = false;
 
 	static WindowsZoomManager* get();
 
@@ -27,13 +27,13 @@ class WindowsZoomManager {
 	void move(CCPoint delta);
 
 	float getZoom();
-	// CCPoint getMousePosOnScreen();
 	CCPoint getMousePosOnNode(CCNode* node);
-	
+
 	void onResume();
 	void onPause();
 	void onScroll(float y, float x);
 private:
+	CCNode* getPlayLayer();
 	void onScreenModified();
 };
-#endif // GEODE_IS_DESKTOP
+#endif // GEODE_IS_DESKTOP

src/main.cpp

@@ -1,16 +1,5 @@
-#include <charconv>
-
 #include <Geode/Geode.hpp>
 
-#include <Geode/modify/MenuLayer.hpp>
-#include <Geode/modify/PauseLayer.hpp>
-#include <Geode/modify/CCKeyboardDispatcher.hpp>
-#include <Geode/modify/CCMouseDispatcher.hpp>
-#include <Geode/modify/PlayLayer.hpp>
-#include <Geode/modify/CCEGLView.hpp>
-#include <Geode/modify/CCApplication.hpp>
-#include <Geode/modify/CCScheduler.hpp>
-
 #include "settings.hpp"
 
 #ifdef GEODE_IS_MOBILE
@@ -19,14 +8,9 @@
 
 using namespace geode::prelude;
 
-float clamp(float d, float min, float max) {
-	const float t = d < min ? min : d;
-	return t > max ? max : t;
-}
-
 $execute {
 	geode::log::info("Zoom mod loaded!");
 	geode::log::info("Platform: " GEODE_PLATFORM_NAME);
 
 	SettingsManager::get()->init();
-}
+}