test: improve #220 test case

Author: BoboTiG

mss/linux.py

@@ -364,9 +364,9 @@ def _set_cfunctions(self) -> None:
 
         cfactory = self._cfactory
         attrs = {
+            "xfixes": getattr(self, "xfixes", None),
             "xlib": self.xlib,
             "xrandr": self.xrandr,
-            "xfixes": getattr(self, "xfixes", None),
         }
         for func, (attr, argtypes, restype) in CFUNCTIONS.items():
             with suppress(AttributeError):

mss/tests/test_issue_220.py

@@ -7,7 +7,15 @@
 import mss
 
 tkinter = pytest.importorskip("tkinter")
-root = tkinter.Tk()
+
+
+@pytest.fixture
+def root() -> tkinter.Tk:
+    master = tkinter.Tk()
+    try:
+        yield master
+    finally:
+        master.destroy()
 
 
 def take_screenshot():
@@ -16,23 +24,23 @@ def take_screenshot():
         sct.grab(region)
 
 
-def create_top_level_win():
-    top_level_win = tkinter.Toplevel(root)
+def create_top_level_win(master: tkinter.Tk):
+    top_level_win = tkinter.Toplevel(master)
 
     take_screenshot_btn = tkinter.Button(top_level_win, text="Take screenshot", command=take_screenshot)
     take_screenshot_btn.pack()
 
     take_screenshot_btn.invoke()
-    root.update_idletasks()
-    root.update()
+    master.update_idletasks()
+    master.update()
 
     top_level_win.destroy()
-    root.update_idletasks()
-    root.update()
+    master.update_idletasks()
+    master.update()
 
 
-def test_regression(capsys):
-    btn = tkinter.Button(root, text="Open TopLevel", command=create_top_level_win)
+def test_regression(root: tkinter.Tk, capsys):
+    btn = tkinter.Button(root, text="Open TopLevel", command=lambda: create_top_level_win(root))
     btn.pack()
 
     # First screenshot: it works