Skip to content

Commit 8cbd9a0

Browse files
committed
🐛 코어구조변경으로 인한 Side Effect 해결
- 읽고싶은 책 등록시 독서노트에 회독 하나 더 추가되는거 수정
1 parent e45caf8 commit 8cbd9a0

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/main/java/com/boggle_boggle/bbegok/repository/ReadDateRepository.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,14 @@
33
import com.boggle_boggle.bbegok.entity.ReadDate;
44
import com.boggle_boggle.bbegok.entity.ReadingRecord;
55
import com.boggle_boggle.bbegok.entity.user.User;
6+
import com.boggle_boggle.bbegok.enums.ReadStatus;
67
import org.springframework.data.jpa.repository.JpaRepository;
78

89
import java.util.List;
910
import java.util.Optional;
1011

1112
public interface ReadDateRepository extends JpaRepository<ReadDate, Long> {
1213
Optional<ReadDate> findByreadDateSeqAndReadingRecord(Long id, ReadingRecord readingRecord);
13-
List<ReadDate> findByReadingRecordAndReadingRecord_User(ReadingRecord readingRecord, User user);
14+
List<ReadDate> findByReadingRecordAndReadingRecord_UserAndStatusNot(ReadingRecord readingRecord, User user, ReadStatus status);
1415
List<ReadDate> findByReadingRecordOrderByReadDateSeq(ReadingRecord readingRecord);
1516
}

src/main/java/com/boggle_boggle/bbegok/service/NoteService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.boggle_boggle.bbegok.entity.*;
99
import com.boggle_boggle.bbegok.entity.embed.Pages;
1010
import com.boggle_boggle.bbegok.entity.user.User;
11+
import com.boggle_boggle.bbegok.enums.ReadStatus;
1112
import com.boggle_boggle.bbegok.exception.Code;
1213
import com.boggle_boggle.bbegok.exception.exception.GeneralException;
1314
import com.boggle_boggle.bbegok.repository.*;
@@ -38,7 +39,7 @@ public List<NotesByReadDateResponse> getNote(Long recordId, String userId) {
3839

3940
//현재 독서기록에 대한 모든 Note를 찾는다. 이때 readDateSeq별로 그룹바이 해야하고, readDateSeq순서대로 정렬(Null이면 제일 앞으로)
4041
List<Note> notes = noteRepository.findByReadingRecordAndReadingRecord_User(readingRecord, user);
41-
List<ReadDate> readDates = readDateRepository.findByReadingRecordAndReadingRecord_User(readingRecord, user);
42+
List<ReadDate> readDates = readDateRepository.findByReadingRecordAndReadingRecord_UserAndStatusNot(readingRecord, user, ReadStatus.pending);
4243
// 그룹화된 결과 생성
4344
Map<ReadDateAndIdDto, List<NoteDto>> groupedNotes = groupNotesByReadDate(notes, readDates);
4445

0 commit comments

Comments
 (0)