Updated get changed field methods/update changed fields

Author: avonville

includes/class-ajax.php

@@ -132,10 +132,11 @@ public function save_form() {
 
         $form_fields = weforms()->form->save( $data );
 
-        //Update Old Entry meta_key if changed
+        // Update Old Entry meta_key if changed
         $form_id        = $form_data['wpuf_form_id'];
         $form           = weforms()->form->get( $form_id );
-        $update_entries = $form->update_entries( $form_id, $form_fields );
+        
+        $form->maybe_update_entries( $form_id, $form_fields );
 
         do_action( 'weforms_update_form', $form_data['wpuf_form_id'], $form_fields, $settings );
 

includes/class-form.php

@@ -139,7 +139,7 @@ public function get_fields() {
                 $field['recaptcha_theme']   = isset( $field['recaptcha_theme'] ) ? $field['recaptcha_theme'] : 'light';
             }
 
-            // Check if meta_key has changed for updating old Entries
+            // Check if meta_key has changed when saving form compared current entries
             $field['original_name'] = $field['name'];
 
             $form_fields[] = apply_filters( 'weforms-get-form-field', $field, $this->id );
@@ -377,21 +377,17 @@ public function entries() {
      * @param array $form_fields
      */
 
-    public function update_entries( $form_id, $form_fields ) {
+    public function maybe_update_entries( $form_id, $form_fields ) {
         global $wpdb;
-        foreach ($form_fields as $field) {
-            $old_name = $field['original_name'];
-            $new_name = $field['name'];
-            if ($new_name != $old_name) {
-                $field_to_change = $field['original_name'];
-            } else {
-                $field_to_change = " ";
-            }
-        }
+        $changed_fields = $this->get_changed_fields( $form_fields );
+        
+        error_log("Fields to change" . " = " . print_r($changed_fields,1));
+
+        return;
         $entries  = weforms_get_form_entries($form_id);
-        if ($field_to_change == " ") {
-            return;
-        }
+        // if ($field_to_change == " ") {
+        //     return;
+        // }
         foreach ( $entries as $entry ) {            
             $entry_id    = $entry->id;
             $values      = weforms_get_entry_meta( $entry_id );
@@ -403,6 +399,33 @@ public function update_entries( $form_id, $form_fields ) {
             }
         }
      }
+    
+    /**
+     * Get changed fields of form on Save
+     * @since 1.6.9
+     * @param int $form_id
+     * @param array $form_fields
+     * 
+     * @return array
+     */
+    public function get_changed_fields( $form_fields ) {
+        $changed_fields = array();
+        foreach ($form_fields as $field) {
+            if ( array_key_exists( 'original_name', $field ) ) {
+                $old_name = $field['original_name'];
+                $new_name = $field['name'];
+            } else {
+                $old_name = $field['name'];
+                $new_name = $field['name'];
+            }
+            if ($new_name != $old_name) {
+                $changed_fields[] = $field['original_name'];
+            } else {
+                continue;
+            }
+        }
+        return $changed_fields;
+    }
 
     /**
      * Get number of form entries