ZIP Imports/Exports: Fixed some lint and test issues

- Updated test handling to create imports folder when required.
- Updated some tests to delete created import zip files.

Author: ssddanbrown

resources/js/components/index.js

@@ -30,7 +30,7 @@ export {HeaderMobileToggle} from './header-mobile-toggle';
 export {ImageManager} from './image-manager';
 export {ImagePicker} from './image-picker';
 export {ListSortControl} from './list-sort-control';
-export {LoadingButton} from './loading-button';
+export {LoadingButton} from './loading-button.ts';
 export {MarkdownEditor} from './markdown-editor';
 export {NewUserPassword} from './new-user-password';
 export {Notification} from './notification';

resources/js/components/page-comments.js

@@ -93,7 +93,6 @@ export class PageComments extends Component {
 
     updateCount() {
         const count = this.getCommentCount();
-        console.log('update count', count, this.container);
         this.commentsTitle.textContent = window.$trans.choice(this.countText, count, {count});
     }
 

tests/Exports/ZipImportTest.php

@@ -168,6 +168,8 @@ public function test_import_upload_success()
         $resp->assertRedirect("/import/{$import->id}");
         $this->assertFileExists(storage_path($import->path));
         $this->assertActivityExists(ActivityType::IMPORT_CREATE);
+
+        ZipTestHelper::deleteZipForImport($import);
     }
 
     public function test_import_show_page()
@@ -325,6 +327,8 @@ public function test_run_revalidates_content()
         $resp = $this->followRedirects($resp);
         $resp->assertSeeText('The name field is required.');
         $resp->assertSeeText('The id must be an integer.');
+
+        ZipTestHelper::deleteZipForImport($import);
     }
 
     public function test_run_checks_permissions_on_import()
@@ -340,6 +344,8 @@ public function test_run_checks_permissions_on_import()
 
         $resp = $this->followRedirects($resp);
         $resp->assertSeeText('You are lacking the required permissions to create books.');
+
+        ZipTestHelper::deleteZipForImport($import);
     }
 
     public function test_run_requires_parent_for_chapter_and_page_imports()
@@ -379,6 +385,8 @@ public function test_run_validates_correct_parent_type()
 
         $resp = $this->followRedirects($resp);
         $resp->assertSee('Parent book required for chapter import.');
+
+        ZipTestHelper::deleteZipForImport($import);
     }
 
     protected function runImportFromFile(UploadedFile $file): TestResponse

tests/Exports/ZipTestHelper.php

@@ -20,7 +20,14 @@ public static function importFromData(array $importData, array $zipData, array $
 
         $import = Import::factory()->create($importData);
         $zip = static::zipUploadFromData($zipData, $files);
-        rename($zip->getRealPath(), storage_path($import->path));
+        $targetPath = storage_path($import->path);
+        $targetDir = dirname($targetPath);
+
+        if (!file_exists($targetDir)) {
+            mkdir($targetDir);
+        }
+
+        rename($zip->getRealPath(), $targetPath);
 
         return $import;
     }