Fix for the broken test

Author: ehhc

browser/main/lib/dataApi/attachmentManagement.js

@@ -199,7 +199,7 @@ function removeStorageAndNoteReferences (input, noteKey) {
 function deleteAttachmentFolder (storageKey, noteKey) {
   const storagePath = findStorage.findStorage(storageKey)
   const noteAttachmentPath = path.join(storagePath.path, DESTINATION_FOLDER, noteKey)
-  sander.rimraf(noteAttachmentPath)
+  sander.rimrafSync(noteAttachmentPath)
 }
 
 module.exports = {

tests/dataApi/deleteNote-test.js

@@ -45,7 +45,8 @@ test.serial('Delete a note', (t) => {
     .then(function doTest () {
       return createNote(storageKey, input1)
         .then(function createAttachmentFolder (data) {
-          fs.mkdirSync(path.join(storagePath.path, attachmentManagement.DESTINATION_FOLDER, data.noteKey))
+          fs.mkdirSync(path.join(storagePath, attachmentManagement.DESTINATION_FOLDER))
+          fs.mkdirSync(path.join(storagePath, attachmentManagement.DESTINATION_FOLDER, data.key))
           return data
         })
         .then(function (data) {
@@ -54,15 +55,16 @@ test.serial('Delete a note', (t) => {
     })
     .then(function assert (data) {
       try {
-        CSON.readFileSync(path.join(storagePath.path, 'notes', data.noteKey + '.cson'))
+        CSON.readFileSync(path.join(storagePath, 'notes', data.noteKey + '.cson'))
         t.fail('note cson must be deleted.')
       } catch (err) {
         t.is(err.code, 'ENOENT')
+        return data
       }
     })
     .then(function assertAttachmentFolderDeleted (data) {
-      const attachmentFolderPath = path.join(storagePath.path, attachmentManagement.DESTINATION_FOLDER, data.noteKey)
-      t.assert(fs.existsSync(attachmentFolderPath) === false, 'Attachment folder was not deleted')
+      const attachmentFolderPath = path.join(storagePath, attachmentManagement.DESTINATION_FOLDER, data.noteKey)
+      t.is(fs.existsSync(attachmentFolderPath), false)
     })
 })