Skip to content

Commit 084deca

Browse files
hikerpigRokt33r
authored andcommitted
improvement: MarkdownPreview, rewriteIframe attempt can be combined to one call
1 parent 330a444 commit 084deca

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

browser/components/MarkdownPreview.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,9 @@ export default class MarkdownPreview extends React.Component {
558558
}
559559

560560
componentDidUpdate (prevProps) {
561-
if (prevProps.value !== this.props.value) this.rewriteIframe()
561+
// actual rewriteIframe function should be called only once
562+
let needsRewriteIframe = false
563+
if (prevProps.value !== this.props.value) needsRewriteIframe = true
562564
if (
563565
prevProps.smartQuotes !== this.props.smartQuotes ||
564566
prevProps.sanitize !== this.props.sanitize ||
@@ -568,7 +570,7 @@ export default class MarkdownPreview extends React.Component {
568570
prevProps.lineThroughCheckbox !== this.props.lineThroughCheckbox
569571
) {
570572
this.initMarkdown()
571-
this.rewriteIframe()
573+
needsRewriteIframe = true
572574
}
573575
if (
574576
prevProps.fontFamily !== this.props.fontFamily ||
@@ -583,6 +585,10 @@ export default class MarkdownPreview extends React.Component {
583585
prevProps.customCSS !== this.props.customCSS
584586
) {
585587
this.applyStyle()
588+
needsRewriteIframe = true
589+
}
590+
591+
if (needsRewriteIframe) {
586592
this.rewriteIframe()
587593
}
588594
}

0 commit comments

Comments
 (0)