Skip to content

Commit 38ed5b8

Browse files
committed
Remove handleSlider
1 parent 8a6df8b commit 38ed5b8

File tree

1 file changed

+6
-24
lines changed
  • browser/main/modals/PreferencesModal

1 file changed

+6
-24
lines changed

browser/main/modals/PreferencesModal/UiTab.js

Lines changed: 6 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ class UiTab extends React.Component {
6363
}
6464
ipc.addListener('APP_SETTING_DONE', this.handleSettingDone)
6565
ipc.addListener('APP_SETTING_ERROR', this.handleSettingError)
66-
67-
this.handleSlider(null, 1)
68-
this.handleSlider(null, 2)
6966
}
7067

7168
componentWillUnmount() {
@@ -230,24 +227,6 @@ class UiTab extends React.Component {
230227
return `${hour}:${minute}`
231228
}
232229

233-
handleSlider(e, number) {
234-
const sliderID = 'rs-range-line-' + number
235-
const bulletID = 'rs-bullet-' + number
236-
237-
const rangeSlider = document.getElementById(sliderID)
238-
const rangeBullet = document.getElementById(bulletID)
239-
240-
if (rangeSlider && rangeBullet) {
241-
const bulletPosition = rangeSlider.value / rangeSlider.max
242-
rangeBullet.style.left =
243-
bulletPosition * 574 + 6 * (1 - bulletPosition) + 'px'
244-
}
245-
246-
if (e) {
247-
this.handleUIChange(e)
248-
}
249-
}
250-
251230
render() {
252231
const UiAlert = this.state.UiAlert
253232
const UiAlertElement =
@@ -308,7 +287,7 @@ class UiTab extends React.Component {
308287
<label>
309288
<input
310289
onChange={e => this.handleUIChange(e)}
311-
checked={this.state.config.ui.enableScheduleTheme}
290+
checked={config.ui.enableScheduleTheme}
312291
ref='enableScheduleTheme'
313292
type='checkbox'
314293
/>
@@ -322,6 +301,7 @@ class UiTab extends React.Component {
322301
</div>
323302
<div styleName='group-section-control'>
324303
<select
304+
disabled={!config.ui.enableScheduleTheme}
325305
value={config.ui.scheduledTheme}
326306
onChange={e => this.handleUIChange(e)}
327307
ref='uiScheduledTheme'
@@ -361,6 +341,7 @@ class UiTab extends React.Component {
361341
styleName='rs-label'
362342
>{`End: ${this.formatTime(config.ui.scheduleEnd)}`}</span>
363343
<input
344+
disabled={!config.ui.enableScheduleTheme}
364345
id='rs-range-line-1'
365346
styleName='rs-range'
366347
type='range'
@@ -369,7 +350,7 @@ class UiTab extends React.Component {
369350
max='1440'
370351
step='5'
371352
ref='scheduleEnd'
372-
onChange={e => this.handleSlider(e, 1)}
353+
onChange={e => this.handleUIChange(e)}
373354
/>
374355
</div>
375356
<div styleName='range-slider' id='secondRow'>
@@ -378,6 +359,7 @@ class UiTab extends React.Component {
378359
styleName='rs-label'
379360
>{`Start: ${this.formatTime(config.ui.scheduleStart)}`}</span>
380361
<input
362+
disabled={!config.ui.enableScheduleTheme}
381363
id='rs-range-line-2'
382364
styleName='rs-range'
383365
type='range'
@@ -386,7 +368,7 @@ class UiTab extends React.Component {
386368
max='1440'
387369
step='5'
388370
ref='scheduleStart'
389-
onChange={e => this.handleSlider(e, 2)}
371+
onChange={e => this.handleUIChange(e)}
390372
/>
391373
</div>
392374
<div styleName='box-minmax'>

0 commit comments

Comments
 (0)