Skip to content

Commit b224c72

Browse files
authored
Merge pull request #2637 from miguelalexbt/master
Warning when printing snippet
2 parents 6c57ac8 + a39da48 commit b224c72

File tree

5 files changed

+34
-18
lines changed

5 files changed

+34
-18
lines changed

browser/main/Detail/InfoPanel.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,22 +70,22 @@ class InfoPanel extends React.Component {
7070
<hr />
7171

7272
<div id='export-wrap'>
73-
<button styleName='export--enable' onClick={(e) => exportAsMd(e)}>
73+
<button styleName='export--enable' onClick={(e) => exportAsMd(e, 'export-md')}>
7474
<i className='fa fa-file-code-o' />
7575
<p>{i18n.__('.md')}</p>
7676
</button>
7777

78-
<button styleName='export--enable' onClick={(e) => exportAsTxt(e)}>
78+
<button styleName='export--enable' onClick={(e) => exportAsTxt(e, 'export-txt')}>
7979
<i className='fa fa-file-text-o' />
8080
<p>{i18n.__('.txt')}</p>
8181
</button>
8282

83-
<button styleName='export--enable' onClick={(e) => exportAsHtml(e)}>
83+
<button styleName='export--enable' onClick={(e) => exportAsHtml(e, 'export-html')}>
8484
<i className='fa fa-html5' />
8585
<p>{i18n.__('.html')}</p>
8686
</button>
8787

88-
<button styleName='export--enable' onClick={(e) => print(e)}>
88+
<button styleName='export--enable' onClick={(e) => print(e, 'print')}>
8989
<i className='fa fa-print' />
9090
<p>{i18n.__('Print')}</p>
9191
</button>

browser/main/Detail/InfoPanelTrashed.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,17 @@ const InfoPanelTrashed = ({
3131
</div>
3232

3333
<div id='export-wrap'>
34-
<button styleName='export--enable' onClick={(e) => exportAsMd(e)}>
34+
<button styleName='export--enable' onClick={(e) => exportAsMd(e, 'export-md')}>
3535
<i className='fa fa-file-code-o' />
3636
<p>.md</p>
3737
</button>
3838

39-
<button styleName='export--enable' onClick={(e) => exportAsTxt(e)}>
39+
<button styleName='export--enable' onClick={(e) => exportAsTxt(e, 'export-txt')}>
4040
<i className='fa fa-file-text-o' />
4141
<p>.txt</p>
4242
</button>
4343

44-
<button styleName='export--enable' onClick={(e) => exportAsHtml(e)}>
44+
<button styleName='export--enable' onClick={(e) => exportAsHtml(e, 'export-html')}>
4545
<i className='fa fa-html5' />
4646
<p>.html</p>
4747
</button>

browser/main/Detail/SnippetNoteDetail.js

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -645,11 +645,18 @@ class SnippetNoteDetail extends React.Component {
645645
if (infoPanel.style) infoPanel.style.display = infoPanel.style.display === 'none' ? 'inline' : 'none'
646646
}
647647

648-
showWarning () {
648+
showWarning (e, msg) {
649+
const warningMessage = (msg) => ({
650+
'export-txt': 'Text export',
651+
'export-md': 'Markdown export',
652+
'export-html': 'HTML export',
653+
'print': 'Print'
654+
})[msg]
655+
649656
dialog.showMessageBox(remote.getCurrentWindow(), {
650657
type: 'warning',
651658
message: i18n.__('Sorry!'),
652-
detail: i18n.__('md/text import is available only a markdown note.'),
659+
detail: i18n.__(warningMessage(msg) + ' is available only in markdown notes.'),
653660
buttons: [i18n.__('OK')]
654661
})
655662
}
@@ -800,7 +807,9 @@ class SnippetNoteDetail extends React.Component {
800807
createdAt={formatDate(note.createdAt)}
801808
exportAsMd={this.showWarning}
802809
exportAsTxt={this.showWarning}
810+
exportAsHtml={this.showWarning}
803811
type={note.type}
812+
print={this.showWarning}
804813
/>
805814
</div>
806815
</div>

browser/main/NoteList/index.js

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ class NoteList extends React.Component {
6464
this.focusHandler = () => {
6565
this.refs.list.focus()
6666
}
67-
this.alertIfSnippetHandler = () => {
68-
this.alertIfSnippet()
67+
this.alertIfSnippetHandler = (event, msg) => {
68+
this.alertIfSnippet(msg)
6969
}
7070
this.importFromFileHandler = this.importFromFile.bind(this)
7171
this.jumpNoteByHash = this.jumpNoteByHashHandler.bind(this)
@@ -495,14 +495,21 @@ class NoteList extends React.Component {
495495
})
496496
}
497497

498-
alertIfSnippet () {
498+
alertIfSnippet (msg) {
499+
const warningMessage = (msg) => ({
500+
'export-txt': 'Text export',
501+
'export-md': 'Markdown export',
502+
'export-html': 'HTML export',
503+
'print': 'Print'
504+
})[msg]
505+
499506
const targetIndex = this.getTargetIndex()
500507
if (this.notes[targetIndex].type === 'SNIPPET_NOTE') {
501508
dialog.showMessageBox(remote.getCurrentWindow(), {
502509
type: 'warning',
503510
message: i18n.__('Sorry!'),
504-
detail: i18n.__('md/text import is available only a markdown note.'),
505-
buttons: [i18n.__('OK'), i18n.__('Cancel')]
511+
detail: i18n.__(warningMessage(msg) + ' is available only in markdown notes.'),
512+
buttons: [i18n.__('OK')]
506513
})
507514
}
508515
}

lib/main-menu.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -99,21 +99,21 @@ const file = {
9999
{
100100
label: 'Plain Text (.txt)',
101101
click () {
102-
mainWindow.webContents.send('list:isMarkdownNote')
102+
mainWindow.webContents.send('list:isMarkdownNote', 'export-txt')
103103
mainWindow.webContents.send('export:save-text')
104104
}
105105
},
106106
{
107107
label: 'MarkDown (.md)',
108108
click () {
109-
mainWindow.webContents.send('list:isMarkdownNote')
109+
mainWindow.webContents.send('list:isMarkdownNote', 'export-md')
110110
mainWindow.webContents.send('export:save-md')
111111
}
112112
},
113113
{
114114
label: 'HTML (.html)',
115115
click () {
116-
mainWindow.webContents.send('list:isMarkdownNote')
116+
mainWindow.webContents.send('list:isMarkdownNote', 'export-html')
117117
mainWindow.webContents.send('export:save-html')
118118
}
119119
}
@@ -159,7 +159,7 @@ const file = {
159159
label: 'Print',
160160
accelerator: 'CommandOrControl+P',
161161
click () {
162-
mainWindow.webContents.send('list:isMarkdownNote')
162+
mainWindow.webContents.send('list:isMarkdownNote', 'print')
163163
mainWindow.webContents.send('print')
164164
}
165165
},

0 commit comments

Comments
 (0)