Merge pull request #1920 from samlanning/incorrect-state-property-reference

Rokt33r · web-flow · commit d69fd12fb91d · 2018-05-15T16:49:40.000+09:00
Fix mis-referenced state properties
diff --git a/browser/main/Detail/MarkdownNoteDetail.js b/browser/main/Detail/MarkdownNoteDetail.js
@@ -58,7 +58,7 @@ class MarkdownNoteDetail extends React.Component {
   }
 
   componentWillReceiveProps (nextProps) {
-    if (nextProps.note.key !== this.props.note.key && !this.isMovingNote) {
+    if (nextProps.note.key !== this.props.note.key && !this.state.isMovingNote) {
       if (this.saveQueue != null) this.saveNow()
       this.setState({
         note: Object.assign({}, nextProps.note)
diff --git a/browser/main/Detail/SnippetNoteDetail.js b/browser/main/Detail/SnippetNoteDetail.js
@@ -68,7 +68,7 @@ class SnippetNoteDetail extends React.Component {
   }
 
   componentWillReceiveProps (nextProps) {
-    if (nextProps.note.key !== this.props.note.key && !this.isMovingNote) {
+    if (nextProps.note.key !== this.props.note.key && !this.state.isMovingNote) {
       if (this.saveQueue != null) this.saveNow()
       const nextNote = Object.assign({
         description: ''

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ class MarkdownNoteDetail extends React.Component {`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`componentWillReceiveProps (nextProps) {`
`61`		`- if (nextProps.note.key !== this.props.note.key && !this.isMovingNote) {`
	`61`	`+ if (nextProps.note.key !== this.props.note.key && !this.state.isMovingNote) {`
`62`	`62`	`if (this.saveQueue != null) this.saveNow()`
`63`	`63`	`this.setState({`
`64`	`64`	`note: Object.assign({}, nextProps.note)`
Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ class SnippetNoteDetail extends React.Component {`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`componentWillReceiveProps (nextProps) {`
`71`		`- if (nextProps.note.key !== this.props.note.key && !this.isMovingNote) {`
	`71`	`+ if (nextProps.note.key !== this.props.note.key && !this.state.isMovingNote) {`
`72`	`72`	`if (this.saveQueue != null) this.saveNow()`
`73`	`73`	`const nextNote = Object.assign({`
`74`	`74`	`description: ''`