Skip to content

feedback 2025-09-19 #42

@gabitoesmiapodo

Description

@gabitoesmiapodo

Comes from cowprotocol#6198 (review)

Misc:

  • > In the PR you've provided there is no 'swap and bridge functionality for swaps. It would be nice to add it and to test it as well.

Configuration, should look into it, probably more missing macros here?

  • > Language switcher does not show 'flag' icons in Win11

Probably font-related, maybe current solution must be replaced by SVGs.

  • > When the language is changed to Russian, the font differs from the one we have in the app:
  • > We'd prefer to have the same font for every language. Example:

Not sure about this, with the current implementation font should keep being the same? We're not swapping fonts. Investigate.

  • > Besides, there is a typo in the Account Proxy help page:

Missing macros / templates (some of these maybe are already inside a macro but not translated, some maybe were added after I created the PR, some maybe not possible to translate, I'll check it out):

  • > Some errors that come from the BE are not translated:

I don't think we have control over text fetched from the backend. Probably not (but must check if it's indeed text from the backend).

  • > 'Received' in the order details is not translated

  • > 'Approved' is not transalted

  • > 'est'' (estimated) is not transalted

  • > Account Proxy is not translated.

  • > Account Proxy - 'copy address', 'copied' is not translated

  • > Hooks, 'build your own hook': this hook is a default one in the store, and should be translated, IMO

  • > 'Cancel order' link in the progress bar messages is not translated

  • > Failed onchain TX pop-up is not translated

  • > Limit order receipt: title is not translated, as well as dates

  • > Limit orders table: see the issues on the screenshot:

  • > Order created pop-up: 'Order' , 'for at most', 'for at least' are not transalted as well as ;View on Explorer' link

  • > Account Proxy page; 'Recoverable tokens' is not translated

  • > Order success modal: 'Received' is not translated

  • > Swap deadline setting: tooltip is not fully translated

  • > Order executed modal: 'tip' is not translated

  • > Swap confirm modal: Max send/min receive tooltips are not translated

  • > TWAP order receipt: modal name is not translated, order type is not translated, dates are not translated (days ago), there is a missing space in the top of the modals' text

  • > Unwrap is not translated (in the pop-up, in the account modal)

  • > View token list is also not translated

  • > Place limit order: 'View on Explorer' also not translated

  • > SWAP order is not translated in the TWAP warning

Dates: not sure about these, I got to check.

  • > Notifications panel: date is not translated (e.g. month should be written in a changed language)

  • > Date on the Review limit order modal is also not translated (month should be written in a changed language)

  • > Surplus tooltip in the Account modal': month is not translated

Do not translate / Change

  • > The section's view should remain as it is:

  • > Limit orders page name should not be changed (it should be 'Limit'):

Layout / broken things issues (some of these might be just changing the text in the translation):

  • > Legal section in the header is broken in the PR:

  • > Account modal: looks like styles are not properly adjusted to the language changes. See the images with explanation:

  • > The icon for a fortune cookie is missing in this PR in the footer

  • > Total fee tooltip: there are unnecessary symbols in it

  • > Same with the text for import token list warning:

  • > Limit orders, 'fills at' tooltip: there are missing spaces between letters and numbers

  • > Limit order settings: there are unnecessary symbols in the 'Enable partial fill' setting's tooltip

  • > Tooltips alignment does not look good in a mobile view (settings, swap container)

  • > Limit order warning when price is bad:

  • > TWAP order part tooltip has unnecessary symbols

  • > Tooltip for the teap order duration field does not look good

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions