Remove requirement for task completion when report (#229)

Co-authored-by: Felix <[email protected]>

Author: Lauritz-Tieste

challenges/src/endpoints/subtasks/reports.rs

@@ -81,7 +81,7 @@ impl Api {
         }
 
         let user_subtask = get_user_subtask(&db, auth.0.id, subtask.id).await?;
-        if !user_subtask.can_rate(&auth.0, &subtask) {
+        if !user_subtask.can_report(&auth.0, &subtask) {
             return CreateReport::permission_denied();
         }
 

challenges/src/services/subtasks.rs

@@ -259,6 +259,10 @@ pub trait UserSubtaskExt {
         user.id != subtask.creator && self.is_solved() && !self.is_rated()
     }
 
+    fn can_report(&self, user: &User, subtask: &challenges_subtasks::Model) -> bool {
+        user.id != subtask.creator && !self.is_rated()
+    }
+
     fn attempted(&self) -> bool {
         self.last_attempt().is_some()
     }