Skip to content

Commit b18e336

Browse files
jonathanaustinjonathanaustin
committed
qa-parent junit
1 parent 97f3c2b commit b18e336

File tree

3 files changed

+45
-46
lines changed

3 files changed

+45
-46
lines changed

‎build-tools/src/main/resources/bordertech/bt-spotbugs-exclude-filter.xml‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<FindBugsFilter>
33

4+
<!-- Core Bugs -->
5+
<Match>
6+
<Bug pattern="S508C_NON_TRANSLATABLE_STRING" />
7+
</Match>
48
<!-- Auxilary Plugin Bugs -->
59
<Match>
610
<Bug pattern="CLI_CONSTANT_LIST_INDEX, FCCD_FIND_CLASS_CIRCULAR_DEPENDENCY,LII_LIST_INDEXED_ITERATING, LSYC_LOCAL_SYNCHRONIZED_COLLECTION, LUI_USE_SINGLETON_LIST, PCOA_PARTIALLY_CONSTRUCTED_OBJECT_ACCESS,PDP_POORLY_DEFINED_PARAMETER,MUI_CONTAINSKEY_BEFORE_GET,PMB_POSSIBLE_MEMORY_BLOAT,SPP_EQUALS_ON_ENUM,SUI_CONTAINS_BEFORE_ADD" />

‎pom.xml‎

Lines changed: 5 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
<packaging>pom</packaging>
1212

1313
<properties>
14-
<surefireArgLine />
15-
<surefire.version>2.22.1</surefire.version>
1614
<maven.compiler.target>1.8</maven.compiler.target>
1715
<maven.compiler.source>1.8</maven.compiler.source>
1816
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
@@ -94,31 +92,6 @@
9492
</repository>
9593
</distributionManagement>
9694

97-
<dependencyManagement>
98-
<dependencies>
99-
<!-- Common lang3 -->
100-
<dependency>
101-
<groupId>org.apache.commons</groupId>
102-
<artifactId>commons-lang3</artifactId>
103-
<version>3.8.1</version>
104-
</dependency>
105-
<!-- Junit 5 -->
106-
<dependency>
107-
<groupId>org.junit.jupiter</groupId>
108-
<artifactId>junit-jupiter-engine</artifactId>
109-
<version>5.3.2</version>
110-
<scope>test</scope>
111-
</dependency>
112-
<!-- Junit 5 support for Junit 3 and 4 -->
113-
<dependency>
114-
<groupId>org.junit.vintage</groupId>
115-
<artifactId>junit-vintage-engine</artifactId>
116-
<scope>test</scope>
117-
<version>5.3.2</version>
118-
</dependency>
119-
</dependencies>
120-
</dependencyManagement>
121-
12295
<build>
12396
<pluginManagement>
12497
<plugins>
@@ -142,6 +115,7 @@
142115
</executions>
143116
</plugin>
144117

118+
<!-- Assembly -->
145119
<plugin>
146120
<artifactId>maven-assembly-plugin</artifactId>
147121
<configuration>
@@ -166,18 +140,19 @@
166140
<releaseProfiles>release</releaseProfiles>
167141
</configuration>
168142
</plugin>
169-
170143
</plugins>
171144
</pluginManagement>
172145

173146
<plugins>
147+
174148
<!-- Compile the java source. -->
175149
<plugin>
176150
<groupId>org.apache.maven.plugins</groupId>
177151
<artifactId>maven-compiler-plugin</artifactId>
178152
<version>3.8.0</version>
179153
</plugin>
180154

155+
<!-- Javadoc -->
181156
<plugin>
182157
<groupId>org.apache.maven.plugins</groupId>
183158
<artifactId>maven-javadoc-plugin</artifactId>
@@ -206,6 +181,7 @@
206181
</executions>
207182
</plugin>
208183

184+
<!-- Enforcer -->
209185
<plugin>
210186
<groupId>org.apache.maven.plugins</groupId>
211187
<artifactId>maven-enforcer-plugin</artifactId>
@@ -230,17 +206,10 @@
230206
<dependency>
231207
<groupId>org.codehaus.mojo</groupId>
232208
<artifactId>extra-enforcer-rules</artifactId>
233-
<version>1.0-beta-9</version>
209+
<version>1.1</version>
234210
</dependency>
235211
</dependencies>
236212
</plugin>
237-
238-
<plugin>
239-
<groupId>org.apache.maven.plugins</groupId>
240-
<artifactId>maven-surefire-plugin</artifactId>
241-
<version>${surefire.version}</version>
242-
</plugin>
243-
244213
</plugins>
245214
</build>
246215

‎qa-parent/pom.xml‎

Lines changed: 36 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,14 @@
1414

1515
<properties>
1616

17-
<!--
18-
<javadoc.excluded.packages />
19-
<checkstyle.excludes />
20-
-->
17+
<surefireArgLine />
2118

2219
<!-- SKIP QA -->
23-
<bt.qa.skip>true</bt.qa.skip><!-- Basically a backwards compatible alias for wc.qa.skip -->
24-
<wc.qa.skip>${bt.qa.skip}</wc.qa.skip>
25-
<checkstyle.skip>${wc.qa.skip}</checkstyle.skip>
26-
<pmd.skip>${wc.qa.skip}</pmd.skip>
27-
<spotbugs.skip>${wc.qa.skip}</spotbugs.skip>
20+
<bt.qa.skip>true</bt.qa.skip>
21+
<checkstyle.skip>${bt.qa.skip}</checkstyle.skip>
22+
<pmd.skip>${bt.qa.skip}</pmd.skip>
23+
<cpd.skip>${bt.qa.skip}</cpd.skip>
24+
<spotbugs.skip>${bt.qa.skip}</spotbugs.skip>
2825

2926
<!-- Checkstyle -->
3027
<bt.checkstyle.config.file>bordertech/bt-checkstyle.xml</bt.checkstyle.config.file>
@@ -55,6 +52,25 @@
5552
configuration from bordertech-parent.
5653
</description>
5754

55+
<dependencyManagement>
56+
<dependencies>
57+
<!-- Junit 5 -->
58+
<dependency>
59+
<groupId>org.junit.jupiter</groupId>
60+
<artifactId>junit-jupiter-engine</artifactId>
61+
<version>5.3.2</version>
62+
<scope>test</scope>
63+
</dependency>
64+
<!-- Junit 5 support for Junit 4 -->
65+
<dependency>
66+
<groupId>org.junit.vintage</groupId>
67+
<artifactId>junit-vintage-engine</artifactId>
68+
<scope>test</scope>
69+
<version>5.3.2</version>
70+
</dependency>
71+
</dependencies>
72+
</dependencyManagement>
73+
5874
<build>
5975

6076
<plugins>
@@ -78,6 +94,17 @@
7894
</executions>
7995
</plugin>
8096

97+
<!-- Surefire -->
98+
<plugin>
99+
<groupId>org.apache.maven.plugins</groupId>
100+
<artifactId>maven-surefire-plugin</artifactId>
101+
<version>2.22.1</version>
102+
<configuration>
103+
<!-- Arg set by jacoco. -->
104+
<argLine>${surefireArgLine}</argLine>
105+
</configuration>
106+
</plugin>
107+
81108
<!-- Verify: Check the code style. -->
82109
<plugin>
83110
<groupId>org.apache.maven.plugins</groupId>
@@ -121,7 +148,6 @@
121148
<groupId>org.apache.maven.plugins</groupId>
122149
<artifactId>maven-pmd-plugin</artifactId>
123150
<version>3.11.0</version>
124-
<!-- Common CONFIG for PMD and CPD -->
125151
<configuration>
126152
<failurePriority>${bt.pmd.failure.priority}</failurePriority>
127153
<minimumPriority>${bt.pmd.min.priority}</minimumPriority>

0 commit comments

Comments
 (0)