Feature: Hide IPv4/6, DNS and DHCP info if adapter is down (#3114)

BornToBeRoot · web-flow · commit 4b07dd92dbc2 · 2025-07-23T23:15:52.000Z
* Feature: Hide IPv4/6, DNS and DHCP info if adapter is down * Docs: #3111 #3114
diff --git a/Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.cs b/Source/NETworkManager.Converters/BooleansAndToVisibilityCollapsedConverter.cs
@@ -0,0 +1,20 @@
+﻿using System;
+using System.Globalization;
+using System.Linq;
+using System.Windows;
+using System.Windows.Data;
+
+namespace NETworkManager.Converters;
+
+public sealed class BooleansAndToVisibilityCollapsedConverter : IMultiValueConverter
+{
+    public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)
+    {
+        return values.OfType<bool>().All(b => b) ? Visibility.Visible : Visibility.Collapsed;
+    }
+
+    public object[] ConvertBack(object value, Type[] targetTypes, object parameter, CultureInfo culture)
+    {
+        throw new NotImplementedException();
+    }
+}
diff --git a/Source/NETworkManager.Converters/BooleansOrToVisibilityCollapsedConverter.cs b/Source/NETworkManager.Converters/BooleansOrToVisibilityCollapsedConverter.cs
@@ -6,7 +6,7 @@
 
 namespace NETworkManager.Converters;
 
-public sealed class BooleanToVisibilityCollapsedMultiConverter : IMultiValueConverter
+public sealed class BooleansOrToVisibilityCollapsedConverter : IMultiValueConverter
 {
     public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)
     {
diff --git a/Source/NETworkManager.Models/Network/NetworkInterface.cs b/Source/NETworkManager.Models/Network/NetworkInterface.cs
@@ -54,6 +54,7 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()
             var ipProperties = networkInterface.GetIPProperties();
 
             foreach (var unicastIPAddrInfo in ipProperties.UnicastAddresses)
+            {
                 switch (unicastIPAddrInfo.Address.AddressFamily)
                 {
                     case AddressFamily.InterNetwork:
@@ -74,11 +75,13 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()
                         listIPv6Address.Add(unicastIPAddrInfo.Address);
                         break;
                 }
+            }
 
             var listIPv4Gateway = new List<IPAddress>();
             var listIPv6Gateway = new List<IPAddress>();
 
             foreach (var gatewayIPAddrInfo in ipProperties.GatewayAddresses)
+            {
                 switch (gatewayIPAddrInfo.Address.AddressFamily)
                 {
                     case AddressFamily.InterNetwork:
@@ -88,6 +91,7 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()
                         listIPv6Gateway.Add(gatewayIPAddrInfo.Address);
                         break;
                 }
+            }
 
             // Check if autoconfiguration for DNS is enabled (only via registry key)
             var nameServerKey =
diff --git a/Source/NETworkManager/Views/IPScannerView.xaml b/Source/NETworkManager/Views/IPScannerView.xaml
@@ -24,7 +24,7 @@
         <converters:BooleanReverseToVisibilityCollapsedConverter x:Key="BooleanReverseToVisibilityCollapsedConverter" />
         <converters:BooleanToStringConverter x:Key="BooleanToStringConverter" />
         <converters:BooleanToVisibilityCollapsedConverter x:Key="BooleanToVisibilityCollapsedConverter" />
-        <converters:BooleanToVisibilityCollapsedMultiConverter x:Key="BooleanToVisibilityCollapsedMultiConverter" />
+        <converters:BooleansOrToVisibilityCollapsedConverter x:Key="BooleansOrToVisibilityCollapsedConverter" />
         <converters:HostUpStyleConverter x:Key="HostUpStyleConverter" />
         <converters:IPStatusToStringConverter x:Key="IPStatusToStringConverter" />
         <converters:IntNotZeroToVisibilityCollapsedConverter x:Key="IntNotZeroToVisibilityCollapsedConverter" />
@@ -518,7 +518,7 @@
                                     SortMemberPath="Hostname"
                                     MinWidth="150">
                     <DataGridTextColumn.Visibility>
-                        <MultiBinding Converter="{StaticResource BooleanToVisibilityCollapsedMultiConverter}">
+                        <MultiBinding Converter="{StaticResource BooleansOrToVisibilityCollapsedConverter}">
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
                                      Path="IPScanner_ResolveHostname" />
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
@@ -544,7 +544,7 @@
                                     SortMemberPath="MACAddress"
                                     MinWidth="150">
                     <DataGridTextColumn.Visibility>
-                        <MultiBinding Converter="{StaticResource BooleanToVisibilityCollapsedMultiConverter}">
+                        <MultiBinding Converter="{StaticResource BooleansOrToVisibilityCollapsedConverter}">
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
                                      Path="IPScanner_ResolveMACAddress" />
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
@@ -557,7 +557,7 @@
                                     SortMemberPath="Vendor"
                                     MinWidth="200">
                     <DataGridTextColumn.Visibility>
-                        <MultiBinding Converter="{StaticResource BooleanToVisibilityCollapsedMultiConverter}">
+                        <MultiBinding Converter="{StaticResource BooleansOrToVisibilityCollapsedConverter}">
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
                                      Path="IPScanner_ResolveMACAddress" />
                             <Binding Source="{x:Static Member=settings:SettingsManager.Current}"
diff --git a/Source/NETworkManager/Views/NetworkInterfaceView.xaml b/Source/NETworkManager/Views/NetworkInterfaceView.xaml
diff --git a/Website/docs/changelog/next-release.md b/Website/docs/changelog/next-release.md

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace NETworkManager.Converters;`
`8`	`8`
`9`		`-public sealed class BooleanToVisibilityCollapsedMultiConverter : IMultiValueConverter`
	`9`	`+public sealed class BooleansOrToVisibilityCollapsedConverter : IMultiValueConverter`
`10`	`10`	`{`
`11`	`11`	`public object Convert(object[] values, Type targetType, object parameter, CultureInfo culture)`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -54,6 +54,7 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()`
`54`	`54`	`var ipProperties = networkInterface.GetIPProperties();`
`55`	`55`
`56`	`56`	`foreach (var unicastIPAddrInfo in ipProperties.UnicastAddresses)`
	`57`	`+ {`
`57`	`58`	`switch (unicastIPAddrInfo.Address.AddressFamily)`
`58`	`59`	`{`
`59`	`60`	`case AddressFamily.InterNetwork:`
`@@ -74,11 +75,13 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()`
`74`	`75`	`listIPv6Address.Add(unicastIPAddrInfo.Address);`
`75`	`76`	`break;`
`76`	`77`	`}`
	`78`	`+ }`
`77`	`79`
`78`	`80`	`var listIPv4Gateway = new List<IPAddress>();`
`79`	`81`	`var listIPv6Gateway = new List<IPAddress>();`
`80`	`82`
`81`	`83`	`foreach (var gatewayIPAddrInfo in ipProperties.GatewayAddresses)`
	`84`	`+ {`
`82`	`85`	`switch (gatewayIPAddrInfo.Address.AddressFamily)`
`83`	`86`	`{`
`84`	`87`	`case AddressFamily.InterNetwork:`
`@@ -88,6 +91,7 @@ public static List<NetworkInterfaceInfo> GetNetworkInterfaces()`
`88`	`91`	`listIPv6Gateway.Add(gatewayIPAddrInfo.Address);`
`89`	`92`	`break;`
`90`	`93`	`}`
	`94`	`+ }`
`91`	`95`
`92`	`96`	`// Check if autoconfiguration for DNS is enabled (only via registry key)`
`93`	`97`	`var nameServerKey =`