Skip to content

Commit efcad84

Browse files
committed
Feature: Replace IPv6 Regex with IPAddress Parse
1 parent 3bd2eb0 commit efcad84

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

Source/NETworkManager.Models/Network/SNTPLookup.cs

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
1-
using System;
1+
using NETworkManager.Utilities;
2+
using System;
23
using System.Collections.Generic;
34
using System.Net;
45
using System.Net.Sockets;
5-
using System.Text.RegularExpressions;
66
using System.Threading.Tasks;
7-
using NETworkManager.Utilities;
87

98
namespace NETworkManager.Models.Network;
109

@@ -102,10 +101,9 @@ public void QueryAsync(IEnumerable<ServerConnectionInfo> servers, bool dnsResolv
102101
// NTP requires an IP address to connect to
103102
IPAddress serverIP = null;
104103

105-
if (Regex.IsMatch(server.Server, RegexHelper.IPv4AddressRegex) ||
106-
Regex.IsMatch(server.Server, RegexHelper.IPv6AddressRegex))
104+
if (IPAddress.TryParse(server.Server, out var address) && (address.AddressFamily == AddressFamily.InterNetwork || address.AddressFamily == AddressFamily.InterNetworkV6))
107105
{
108-
serverIP = IPAddress.Parse(server.Server);
106+
serverIP = address;
109107
}
110108
else
111109
{

Source/NETworkManager.Validators/IPv6AddressValidator.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
using NETworkManager.Localization.Resources;
22
using System.Globalization;
3+
using System.Net;
34
using System.Net.Sockets;
45
using System.Windows.Controls;
56

@@ -11,7 +12,7 @@ public override ValidationResult Validate(object value, CultureInfo cultureInfo)
1112
{
1213
var input = (value as string);
1314

14-
if (System.Net.IPAddress.TryParse(input, out var address) && address.AddressFamily == AddressFamily.InterNetworkV6)
15+
if (IPAddress.TryParse(input, out var address) && address.AddressFamily == AddressFamily.InterNetworkV6)
1516
return ValidationResult.ValidResult;
1617

1718
return new ValidationResult(false, Strings.EnterValidIPv6Address);

Source/global.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"sdk": {
3-
"version": "8.0.412",
3+
"version": "8.0.411",
44
"rollForward": "latestFeature",
55
"allowPrerelease": false
66
}

0 commit comments

Comments
 (0)