MIM-413: Get leases by contact code instead of pnr when getting maintenance units (#261)

* Get leases by contact code instead of pnr when getting maintenance units

* Remove call to getContactByContactCode

---------

Co-authored-by: Henrik Persson <henrik.persson@iteam.com>

Author: henrikhenrikpersson

src/services/property-management-service/index.ts

@@ -683,18 +683,8 @@ export const routes = (router: KoaRouter) => {
   router.get('(.*)/maintenanceUnits/contactCode/:contactCode', async (ctx) => {
     const metadata = generateRouteMetadata(ctx)
     try {
-      const contactResult = await leasingAdapter.getContactByContactCode(
-        ctx.params.contactCode
-      )
-      if (!contactResult.ok) {
-        ctx.status = 404
-        ctx.body = { reason: 'Contact not found', ...metadata }
-        logger.info('Contact not found')
-        return
-      }
-
-      const leases = await leasingAdapter.getLeasesForPnr(
-        contactResult.data.nationalRegistrationNumber,
+      const leases = await leasingAdapter.getLeasesForContactCode(
+        ctx.params.contactCode,
         false,
         false
       )

src/services/property-management-service/tests/index.test.ts

@@ -124,15 +124,11 @@ describe('rental-property-service index', () => {
           ...maintenanceUnitInfo,
           type: index % 2 === 0 ? 'Tvättstuga' : 'Miljöbod',
         }))
-    const contactMock = factory.contact.build()
     const leaseMock = factory.lease.build()
 
     it('should return all maintenance units', async () => {
-      const getContactSpy = jest
-        .spyOn(leasingAdapter, 'getContactByContactCode')
-        .mockResolvedValue({ ok: true, data: contactMock })
-      const getLeasesForPnrSpy = jest
-        .spyOn(leasingAdapter, 'getLeasesForPnr')
+      const getLeasesForContactCodeSpy = jest
+        .spyOn(leasingAdapter, 'getLeasesForContactCode')
         .mockResolvedValue([leaseMock])
       const getMaintenanceUnitsForRentalPropertySpy = jest
         .spyOn(
@@ -147,14 +143,32 @@ describe('rental-property-service index', () => {
 
       expect(res.status).toBe(200)
       expect(res.body.content).toEqual(maintenanceUnitInfoMock)
-      expect(getContactSpy).toHaveBeenCalledWith('P965339')
-      expect(getLeasesForPnrSpy).toHaveBeenCalledWith(
-        '199404084924',
+      expect(getLeasesForContactCodeSpy).toHaveBeenCalledWith(
+        'P965339',
         false,
         false
       )
       expect(getMaintenanceUnitsForRentalPropertySpy).toHaveBeenCalledWith(
-        '705-022-04-0201'
+        leaseMock.rentalPropertyId
+      )
+    })
+
+    it('should return an empty list if there are no leases', async () => {
+      const getLeasesForContactCodeSpy = jest
+        .spyOn(leasingAdapter, 'getLeasesForContactCode')
+        .mockResolvedValue([])
+
+      const res = await request(app.callback()).get(
+        '/api/maintenanceUnits/contactCode/P965339'
+      )
+
+      expect(res.status).toBe(200)
+      expect(res.body.content).toEqual([])
+      expect(res.body.reason).toBe('No maintenance units found')
+      expect(getLeasesForContactCodeSpy).toHaveBeenCalledWith(
+        'P965339',
+        false,
+        false
       )
     })
   })