Feat/uth 236 get all parking space listings from one core (#35)

* Feat: UTH-236 Get All Parking Space Listings From OneCore

Added missing functionality to filter result based on a ContactCode. Scored/internal Listings where the user doesn't have a housing contract is filtered out.

Author: mittistormen

core/src/adapters/leasing-adapter/listings.ts

@@ -296,52 +296,6 @@ const createMultipleListings = async (
   }
 }
 
-const createMultipleListings = async (
-  listingsData: Array<Omit<Listing, 'id' | 'rentalObject'>>
-): Promise<AdapterResult<Listing[], 'partial-failure' | 'unknown'>> => {
-  try {
-    const response = await axios.post(
-      `${tenantsLeasesServiceUrl}/listings/batch`,
-      { listings: listingsData }
-    )
-
-    if (response.status === HttpStatusCode.Created) {
-      return { ok: true, data: response.data.content }
-    }
-
-    // Handle partial success (207 Multi-Status)
-    if (response.status === 207) {
-      logger.warn(
-        {
-          listingsCount: listingsData.length,
-          responseData: response.data,
-        },
-        'Partial success when creating multiple listings'
-      )
-      return { ok: false, err: 'partial-failure' }
-    }
-
-    logger.error(
-      {
-        status: response.status,
-        data: response.data,
-        listingsCount: listingsData.length,
-      },
-      'Unexpected response when creating multiple listings'
-    )
-    return { ok: false, err: 'unknown' }
-  } catch (error) {
-    logger.error(
-      {
-        error,
-        listingsCount: listingsData.length,
-      },
-      'Error creating multiple listings'
-    )
-    return { ok: false, err: 'unknown' }
-  }
-}
-
 export {
   getActiveListingByRentalObjectCode,
   getListingsWithApplicants,

core/src/services/lease-service/tests/listings.test.ts

@@ -132,6 +132,7 @@ describe('GET /listings', () => {
     })
     const parkingSpace = factory.vacantParkingSpace.build({
       rentalObjectCode: '12345',
+      residentialAreaCode: 'AREA123',
     })
 
     const getListingsSpy = jest
@@ -142,6 +143,15 @@ describe('GET /listings', () => {
       .spyOn(tenantLeaseAdapter, 'getParkingSpaces')
       .mockResolvedValueOnce({ ok: true, data: [parkingSpace] })
 
+    jest
+      .spyOn(tenantLeaseAdapter, 'getTenantByContactCode')
+      .mockResolvedValueOnce({
+        ok: true,
+        data: factory.tenant.build({
+          currentHousingContract: { residentialArea: { code: 'AREA123' } },
+        }),
+      })
+
     const res = await request(app.callback()).get(
       '/listings?rentalObjectCode=12345'
     )