minor corrections to copilot feedback

Author: albinrm

core/.env.template

@@ -11,5 +11,6 @@ AUTH__KEYCLOAK__URL=https://auth-test.mimer.nu
 AUTH__KEYCLOAK__REALM=onecore-test
 AUTH__KEYCLOAK__CLIENT_ID=onecore-test
 AUTH__KEYCLOAK__CLIENT_SECRET=
+# Comma-separated list of IPs allowed to upload scanned receipts, e.g. 10.0.0.1,10.0.0.2
 SCANNER__ALLOWED_IPS=
 SCANNER__ERROR_NOTIFICATION_EMAIL=

core/src/services/keys-service/scan-receipt.ts

@@ -123,8 +123,13 @@ export const routes = (router: KoaRouter) => {
     const { receiptId, keyLoanId } = scanResult
 
     // Upload scanned image to file storage (MinIO)
+    const knownImageExts = ['jpg', 'jpeg', 'png', 'tiff', 'bmp', 'gif', 'webp']
+    const fileExt = filename.includes('.')
+      ? filename.split('.').pop()!.toLowerCase()
+      : ''
+    const ext = knownImageExts.includes(fileExt) ? fileExt : 'jpeg'
     const contentType = ctx.request.type || 'image/jpeg'
-    const storageFileName = `receipt-${receiptId}-${Date.now()}.${contentType.split('/')[1] || 'jpg'}`
+    const storageFileName = `receipt-${receiptId}-${Date.now()}.${ext}`
 
     const uploadResult = await fileStorageAdapter.uploadFile(
       storageFileName,

services/keys/src/services/key-service/scan-receipt-service.ts

@@ -14,6 +14,7 @@
 import { Knex } from 'knex'
 import { Jimp } from 'jimp'
 import jsQR from 'jsqr'
+import { logger } from '@onecore/utilities'
 import * as receiptsAdapter from './adapters/receipts-adapter'
 
 const UUID_REGEX =
@@ -92,7 +93,8 @@ export async function processScannedReceipt(
     )
 
     return { ok: true, data: { receiptId: receipt.id, keyLoanId } }
-  } catch {
+  } catch (err) {
+    logger.error({ err, keyLoanId }, 'Failed to create receipt')
     return { ok: false, err: 'receipt-creation-failed' }
   }
 }