Skip to content

Unparsable ffmpeg output #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Unparsable ffmpeg output #94

wants to merge 2 commits into from

Conversation

@BotBlake
Copy link
Owner

@BotBlake BotBlake commented May 26, 2025

This is a temporary solution to mark unparsable runs as failed.
This is related to the fact that ffmpeg does not always output the required values.

This implementation not only handles these issues but will also log and warn the user when issues have occured.
That way we can collect more data about this issue!

@BotBlake
Copy link
Owner Author

BotBlake commented May 26, 2025

@theAeon @gingerbreadassassin @felix920506 @skalthoff
You where the only people to reproduce this issue. #86 / #70

Please be so kind and test this branch.
Then, search in your jellybench-ffmpeg.log for incomplete_data_return

If this line is NOT showing up, the issue was NOT reproduced.
If it shows in the log please leave a more detailed description including the logs of that run.

Kind regards and thank you all!

@skalthoff
Copy link

skalthoff commented Jun 2, 2025 •
edited
Loading

ok finally got around to testing, still recieved and error and didn't complete, sorta thinking that it may be an intel arc issue?:

jellybench-ffmpeg.log
jellybench.log

[AVHWDeviceContext @ 0x61aa365c4b80] No VA display found for device /dev/dri/by-path/pci-0000:09:00.0-render.
Device creation failed: -22.
Failed to set value 'vaapi=va:/dev/dri/by-path/pci-0000:09:00.0-render' for option 'init_hw_device': Invalid argument
Error parsing global options: Invalid argument

2025-06-02 16:21:12 jellybench worker log WARNING: < < Run failed: generic_ffmpeg_failure
2025-06-02 16:21:12 jellybench worker log INFO: > ./jellybench_data/ffmpeg/ffmpeg_files/ffmpeg -c:v h264 -i /home/skalthoff/jellybench_py/jellybench_data/videos/Test%20Jellyfin%204K%20AVC%20150M.mp4 -noautoscale -an -sn -vf "scale=trunc(min(max(iw\,ih*a)\,528)/2)*2:trunc(ow/a/2)*2,format=yuv420p" -c:v libx265 -preset veryfast -b:v 3616000 -maxrate 3616000 -f null - -benchmark
2025-06-02 16:21:12 jellybench worker log INFO: > > Run with 1 Processes
2025-06-02 16:21:12 jellybench worker log DEBUG: > > > Running FFMPEG Process: 0
2025-06-02 16:21:43 jellybench worker log DEBUG: < < < Finished FFMPEG Process 0 without error'
2025-06-02 16:21:43 jellybench worker log INFO: < < Run finished.```

@theAeon
Copy link

theAeon commented Jun 3, 2025 •
edited
Loading

sorta thinking that it may be an intel arc issue?

Possible. I'm running an arc A380.

@gingerbreadassassin, @felix920506, are you?

@felix920506
Copy link
Contributor

felix920506 commented Jun 3, 2025

I had problems with the Linux commands from the server as well.

The provided ffmpeg version is too old and didn't work for me on Ubuntu 24.04

When I modified the program to override the ffmpeg executable it failed because the command was invalid

I am running Intel Arc A750

@BotBlake
Copy link
Owner Author

BotBlake commented Jun 3, 2025

@skalthoff @theAeon @felix920506
Thanks for testing and the feedback.
It seems like you are talking about a different issue now. (#62 )
This fix is only intended for the original issue you guys reported where the tool would crash on "incomplete runs"
I didnt see any of this in the provided log files, so the original bug did not seem to have occured. 😅

If you guys have time please try to reproduce the original issue again.

@theAeon
Copy link

theAeon commented Jun 3, 2025

@skalthoff @theAeon @felix920506 Thanks for testing and the feedback. It seems like you are talking about a different issue now. (#62 ) This fix is only intended for the original issue you guys reported where the tool would crash on "incomplete runs" I didnt see any of this in the provided log files, so the original bug did not seem to have occured. 😅

If you guys have time please try to reproduce the original issue again.

thats what i get for not reading the entire post i responded to. will do.

@BotBlake BotBlake marked this pull request as ready for review June 3, 2025 12:24
@BotBlake
Copy link
Owner Author

BotBlake commented Jun 3, 2025

Whoops accidentally opened for review 🗿

@BotBlake BotBlake marked this pull request as draft June 3, 2025 12:27
@theAeon
Copy link

theAeon commented Jun 3, 2025

still getting

Status: Testing  Workers: 01  Last Speed: 0.00     25% [===========                                    ] ETA:   1:02:54Traceback (most recent call last):
  File "/home/andrew/.cache/pypoetry/virtualenvs/jellybench-py-v2VybeFM-py3.12/bin/jellybench", line 6, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/andrew/jellybench_py/jellybench_py/core.py", line 1045, in main
    return cli()
           ^^^^^
  File "/home/andrew/jellybench_py/jellybench_py/core.py", line 998, in cli
    valid, runs, result = benchmark(
                          ^^^^^^^^^^
  File "/home/andrew/jellybench_py/jellybench_py/core.py", line 360, in benchmark
    "single_worker_speed": max_pass_run_data["speed"],
                           ~~~~~~~~~~~~~~~~~^^^^^^^^^
KeyError: 'speed'
(jellybench-py-py3.12) andrew@jellyfin:~/jellybench_py$

so if you're trying to mark that as a failure it isn't working

@BotBlake
Copy link
Owner Author

BotBlake commented Jun 3, 2025

@theAeon interesting...
Can you add the log files please?
I'm curious to see what's happening.

@theAeon
Copy link

theAeon commented Jun 3, 2025

here ya go
jellybench-ffmpeg.log
jellybench.log

@BotBlake BotBlake mentioned this pull request Oct 11, 2025
Open
6 tasks
@BotBlake BotBlake marked this pull request as ready for review October 13, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BotBlake @skalthoff @theAeon @felix920506