fix: fixed issue when COP not provided by heat pump (10 minutes dev time)

Author: BottlecapDave

custom_components/octopus_energy/api_client/heat_pump.py

@@ -123,15 +123,15 @@ class OctoHeatPumpControllerConfiguration(BaseModel):
 
 
 class OctoHeatPumpLivePerformance(BaseModel):
-    coefficientOfPerformance: str 
+    coefficientOfPerformance: str | None
     heatOutput: ValueAndUnit
     powerInput: ValueAndUnit
     outdoorTemperature: ValueAndUnit
     readAt: str
 
 
 class OctoHeatPumpLifetimePerformance(BaseModel):
-    seasonalCoefficientOfPerformance: str
+    seasonalCoefficientOfPerformance: str | None
     heatOutput: ValueAndUnit
     energyInput: ValueAndUnit
     readAt: str

custom_components/octopus_energy/heat_pump/sensor_lifetime_scop.py

@@ -73,7 +73,7 @@ def _handle_coordinator_update(self) -> None:
         and result.data.octoHeatPumpLifetimePerformance is not None):
       _LOGGER.debug(f"Updating OctopusEnergyHeatPumpSensorLifetimeSCoP for '{self._heat_pump_id}'")
 
-      self._state = float(result.data.octoHeatPumpLifetimePerformance.seasonalCoefficientOfPerformance)
+      self._state = float(result.data.octoHeatPumpLifetimePerformance.seasonalCoefficientOfPerformance) if result.data.octoHeatPumpLifetimePerformance.seasonalCoefficientOfPerformance is not None else None
       self._attributes["read_at"] = datetime.fromisoformat(result.data.octoHeatPumpLifetimePerformance.readAt)
       self._last_updated = current
 

custom_components/octopus_energy/heat_pump/sensor_live_cop.py

@@ -76,7 +76,7 @@ def _handle_coordinator_update(self) -> None:
       self._state = 0
       # Only update the CoP if heat pump is actively running
       if float(result.data.octoHeatPumpLivePerformance.powerInput.value) != 0:
-        self._state = float(result.data.octoHeatPumpLivePerformance.coefficientOfPerformance)
+        self._state = float(result.data.octoHeatPumpLivePerformance.coefficientOfPerformance) if result.data.octoHeatPumpLivePerformance.coefficientOfPerformanc is not None else None
 
       self._attributes["read_at"] = datetime.fromisoformat(result.data.octoHeatPumpLivePerformance.readAt)
       self._last_updated = current