Skip to content

Commit 514afc9

Browse files
authored
chore: fix ci/cd (#2685)
RUN_CODSPEED=1 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Switches benchmarks to CodSpeed Divan with CI updates, bumps MSRV to 1.89, upgrades key deps (ariadne/logos/rowan/smol_str), and adapts diagnostics to Ariadne’s new API. > > - **Benchmarks**: > - Migrate from `codspeed-bencher-compat` to `codspeed-divan-compat` (`divan`) with `#[divan::bench]`, `divan::main()`, and `black_box`. > - Add/expand incremental and parsing/lexing benches; remove `benchmark_group!/benchmark_main!` usage. > - Update build script to generate Divan-style benches. > - **CI**: > - Run instrumented benchmarks on `codspeed-macro`; add `mode: walltime`; build `baml_tests` for CodSpeed. > - Fix pull_request `paths` quoting; simplify benchmark run conditions. > - **Diagnostics**: > - Update `baml_diagnostics` to new Ariadne `Report::build` signature using `(file_id, range)`. > - **MSRV & Dependencies**: > - Bump MSRV to `1.89` in `Cargo.toml`. > - Upgrade `ariadne`→`0.6`, `logos`→`0.15`, `rowan`→`0.16`, `smol_str`→`0.3`. > - Replace CodSpeed crates with latest Divan-compatible versions; refresh `Cargo.lock`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 65b7617. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent d3226f6 commit 514afc9

File tree

7 files changed

+656
-141
lines changed

7 files changed

+656
-141
lines changed

.github/workflows/ci.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ on:
55
branches: [main, canary]
66
pull_request:
77
paths:
8-
- 'baml_language/**'
9-
- '.github/workflows/ci.yaml'
8+
- "baml_language/**"
9+
- ".github/workflows/ci.yaml"
1010
workflow_dispatch:
1111

1212
concurrency:
@@ -398,7 +398,7 @@ jobs:
398398
- name: "Check dependencies"
399399
run: cargo deny check
400400
working-directory: baml_language
401-
continue-on-error: true # For now, just warn
401+
continue-on-error: true # For now, just warn
402402

403403
snapshot-tests:
404404
name: "snapshot tests"
@@ -449,10 +449,9 @@ jobs:
449449
450450
benchmarks-instrumented:
451451
name: "benchmarks instrumented (baml)"
452-
runs-on: ubuntu-24.04
452+
runs-on: codspeed-macro
453453
needs: determine_changes
454454
if: |
455-
github.repository == 'BoundaryML/baml-2' &&
456455
(
457456
github.ref == 'refs/heads/main' ||
458457
github.ref == 'refs/heads/canary' ||
@@ -484,12 +483,13 @@ jobs:
484483
tool: cargo-codspeed
485484

486485
- name: "Build benchmarks"
487-
run: cargo codspeed build --features "codspeed" -p baml_db
486+
run: cargo codspeed build -p baml_tests
488487
working-directory: baml_language
489488

490489
- name: "Run benchmarks"
491490
uses: CodSpeedHQ/action@v3
492491
with:
492+
mode: walltime
493493
run: cd baml_language && cargo codspeed run
494494
token: ${{ secrets.CODSPEED_TOKEN }}
495495

@@ -549,4 +549,4 @@ jobs:
549549
exit 1
550550
fi
551551
552-
echo "All required checks passed!"
552+
echo "All required checks passed!"

0 commit comments

Comments
 (0)