Skip to content

Commit 5c66842

Browse files
authored
fix: 🐛 fixed issues in test generation (#138)
* fix: 🐛 fixed issues in test generation * fix: 🐛 fixed issues in api test generation
1 parent bfc0be2 commit 5c66842

File tree

8 files changed

+26
-50
lines changed

8 files changed

+26
-50
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
"@tsconfig/node18": "^18.2.4",
5151
"@types/figlet": "^1.5.8",
5252
"@types/gradient-string": "^1.1.6",
53-
"@types/node": "^22.5.4",
53+
"@types/node": "^22.5.5",
5454
"@types/yargs": "^17.0.33",
5555
"@typescript-eslint/eslint-plugin": "^8.5.0",
5656
"@typescript-eslint/parser": "^8.5.0",

pnpm-lock.yaml

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/templates/api/data/booking-request-data.ts

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ export const BookingRequestData = {
66
folder: '/api/data',
77
content: `package {{ groupId }}.api.data;
88
9-
import java.text.SimpleDateFormat;
10-
import java.util.concurrent.TimeUnit;
9+
import static java.time.ZoneId.systemDefault;
10+
import static java.time.format.DateTimeFormatter.ISO_LOCAL_DATE;
11+
import static java.util.concurrent.TimeUnit.DAYS;
1112
1213
import {{ groupId }}.api.pojo.BookingData;
1314
import {{ groupId }}.api.pojo.BookingDates;
@@ -17,7 +18,7 @@ public final class BookingRequestData {
1718
private static final Faker FAKER = new Faker ();
1819
1920
public static BookingData getBookingData () {
20-
final var formatter = new SimpleDateFormat ("yyyy-MM-dd");
21+
final var formatter = ISO_LOCAL_DATE.withZone (systemDefault ());
2122
return BookingData.builder ()
2223
.firstname (FAKER.name ()
2324
.firstName ())
@@ -27,10 +28,10 @@ public final class BookingRequestData {
2728
.numberBetween (1, 2000))
2829
.depositpaid (true)
2930
.bookingdates (BookingDates.builder ()
30-
.checkin (formatter.format (FAKER.date ()
31-
.past (20, TimeUnit.DAYS)))
32-
.checkout (formatter.format (FAKER.date ()
33-
.future (5, TimeUnit.DAYS)))
31+
.checkin (formatter.format (FAKER.timeAndDate ()
32+
.past (20, DAYS)))
33+
.checkout (formatter.format (FAKER.timeAndDate ()
34+
.future (5, DAYS)))
3435
.build ())
3536
.additionalneeds ("Breakfast")
3637
.build ();

src/templates/api/pojo/booking-data.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { TemplateFile } from '../../../types/types.js';
22

33
export const BookingDataPojo = {
44
fileName: 'BookingData.java',
5-
folder: '/api/data/',
5+
folder: '/api/pojo/',
66
test: true,
77
content: `package {{ groupId }}.api.pojo;
88

src/templates/api/pojo/booking-test-data.ts

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/templates/api/requests/booking-request.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { TemplateFile } from '../../../types/types.js';
22

33
export const BookingRequest = {
44
fileName: 'BookingRequest.java',
5-
folder: '/api/request/',
5+
folder: '/api/requests/',
66
test: true,
77
content: `package {{ groupId }}.api.requests;
88
@@ -16,11 +16,8 @@ import static io.github.boykaframework.enums.RequestMethod.POST;
1616
import static io.github.boykaframework.enums.RequestMethod.PUT;
1717
import static java.text.MessageFormat.format;
1818
19-
import {{ groupId }}.api.data.AuthRequestData;
2019
import {{ groupId }}.api.pojo.BookingData;
21-
import io.github.boykaframework.actions.api.ApiActions;
2220
import io.github.boykaframework.builders.ApiRequest;
23-
import io.github.boykaframework.enums.RequestMethod;
2421
import lombok.experimental.UtilityClass;
2522
2623
@UtilityClass

src/templates/mobile/pages/drag-drop-page.ts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ export const DragDropPage = {
77
content: `package {{ groupId }}.mobile.pages;
88
99
import static io.appium.java_client.AppiumBy.accessibilityId;
10-
import static io.appium.java_client.AppiumBy.androidUIAutomator;
10+
import static {% if platform == "Android" %}io.appium.java_client.AppiumBy.androidUIAutomator;
11+
{% else %}io.appium.java_client.AppiumBy.iOSNsPredicateString;{% endif %}
1112
import static java.text.MessageFormat.format;
1213
1314
import io.github.boykaframework.builders.Locator;
@@ -45,15 +46,15 @@ public class DragDropPage {
4546
.{{ platform | downcase }} (
4647
{% if platform == "Android" %}androidUIAutomator (
4748
"new UiSelector().textStartsWith(\\"You made it\\")"{% else %}iOSNsPredicateString (
48-
"label BEGINSWITH \\"You made it\\""){% endif %}))
49+
"label BEGINSWITH \\"You made it\\""{% endif %}))
4950
.parent (this.screen)
5051
.name ("Description")
5152
.build ();
5253
private final Locator title = Locator.buildLocator ()
5354
.{{ platform | downcase }} (
5455
{% if platform == "Android" %}androidUIAutomator (
5556
"new UiSelector().text(\\"Congratulations\\")"{% else %}iOSNsPredicateString (
56-
"label == \\"Congratulations\\""){% endif %}))
57+
"label == \\"Congratulations\\""{% endif %}))
5758
.parent (this.screen)
5859
.name ("Title")
5960
.build ();
@@ -73,6 +74,10 @@ public class DragDropPage {
7374
accessibilityId (format ("drop-{0}{1}", direction.getInitial (), index)))
7475
.build ();
7576
}
77+
78+
private DragDropPage () {
79+
// Utility class.
80+
}
7681
}
7782
`,
7883
} satisfies TemplateFile;

src/templates/template-list.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { BookingRequestData } from './api/data/booking-request-data.js';
44
import { AuthTokenPojo } from './api/pojo/auth-token.js';
55
import { BookingDataPojo } from './api/pojo/booking-data.js';
66
import { BookingDatesPojo } from './api/pojo/booking-dates.js';
7-
import { BookingTestDataPojo } from './api/pojo/booking-test-data.js';
87
import { BookingRequest } from './api/requests/booking-request.js';
98
import { GitIgnore } from './gitignore.js';
109
import { DragDropAction } from './mobile/actions/drag-drop-action.js';
@@ -31,7 +30,6 @@ export const templates = {
3130
AuthTokenPojo,
3231
BookingDataPojo,
3332
BookingDatesPojo,
34-
BookingTestDataPojo,
3533
BookingRequest,
3634
],
3735
mobile: [DragDropPage, DragDropAction, WdioHomePage, WdioTest, MobileTestSuite],

0 commit comments

Comments
 (0)