Merge pull request #167 from Brain-WP/feature/ghactions-make-workflow-more-modular

GH Actions: make workflow more modular

Author: gmazzap

.github/workflows/php-qa.yml

@@ -12,7 +12,73 @@ concurrency:
     cancel-in-progress: true
 
 jobs:
-    qa:
+    phpcompatibility:
+        runs-on: ubuntu-latest
+
+        name: "PHPCompatibility"
+
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v6
+
+            - name: Setup PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                php-version: 'latest'
+                coverage: 'none'
+                tools: cs2pr
+              env:
+                fail-fast: true
+
+            - name: Install dependencies
+              uses: "ramsey/composer-install@v3"
+              with:
+                # Bust the cache at least once a month - output format: YYYY-MM.
+                custom-cache-suffix: $(date -u "+%Y-%m")
+
+            - name: Check cross-version PHP compatibility
+              id: phpcs
+              run: composer phpcompat -- --report-full --report-checkstyle=./phpcs-report.xml
+
+            - name: Show PHPCS results in PR
+              if: ${{ always() && steps.phpcs.outcome == 'failure' }}
+              run: cs2pr ./phpcs-report.xml
+
+    lint:
+        runs-on: ubuntu-latest
+
+        strategy:
+            matrix:
+                php: ['5.6', '7.0', '7.4', '8.0', '8.5', 'nightly']
+
+        name: "Lint: PHP ${{ matrix.php }}"
+
+        continue-on-error: ${{ matrix.php == 'nightly' }}
+
+        steps:
+            - name: Checkout code
+              uses: actions/checkout@v6
+
+            - name: Setup PHP
+              uses: shivammathur/setup-php@v2
+              with:
+                php-version: ${{ matrix.php }}
+                ini-values: zend.assertions=1, error_reporting=-1, display_errors=On, display_startup_errors=On
+                coverage: 'none'
+                tools: parallel-lint, cs2pr
+              env:
+                fail-fast: true
+
+            - name: "Lint against parse and compile errors (push)"
+              if: ${{ github.event_name != 'pull_request' }}
+              run: parallel-lint ./src/ ./inc/ ./tests/ -e php --show-deprecated
+
+            - name: "Lint against parse and compile errors (PR)"
+              if: ${{ github.event_name == 'pull_request' }}
+              run: parallel-lint ./src/ ./inc/ ./tests/ -e php --show-deprecated --checkstyle | cs2pr
+
+    test:
+        needs: lint
         runs-on: ubuntu-latest
 
         strategy:
@@ -40,14 +106,9 @@ jobs:
                 php-version: ${{ matrix.php-versions }}
                 ini-values: zend.assertions=1, error_reporting=-1, display_errors=On, display_startup_errors=On
                 coverage: ${{ ( matrix.php-versions == '7.4' && 'xdebug' ) || 'none' }}
-                tools: parallel-lint
               env:
                 fail-fast: true
 
-            - name: Check syntax error in sources
-              if: ${{ matrix.dependency-versions == 'highest' }}
-              run: parallel-lint ./src/ ./tests/
-
             - name: Install dependencies
               uses: "ramsey/composer-install@v3"
               with:
@@ -57,10 +118,6 @@ jobs:
                 # Bust the cache at least once a month - output format: YYYY-MM.
                 custom-cache-suffix: $(date -u "+%Y-%m")
 
-            - name: Check cross-version PHP compatibility
-              if: ${{ matrix.php-versions == '7.4' && matrix.dependency-versions == 'highest' }} # results is same across versions, do it once
-              run: composer phpcompat
-
             - name: Migrate test configuration (>= 7.3)
               if: ${{ matrix.php-versions >= 7.3 && matrix.dependency-versions == 'highest' }}
               run: ./vendor/bin/phpunit --migrate-configuration

composer.json

@@ -71,7 +71,7 @@
     },
     "scripts" : {
         "phpcompat": [
-            "@php ./vendor/squizlabs/php_codesniffer/bin/phpcs -ps . --standard=PHPCompatibility --ignore=*/vendor/* --extensions=php --basepath=./ --runtime-set testVersion 5.6-"
+            "@php ./vendor/squizlabs/php_codesniffer/bin/phpcs -ps . --standard=PHPCompatibility --ignore=*/vendor/* --parallel=10 --extensions=php --basepath=./ --runtime-set testVersion 5.6-"
         ]
     }
 }