Skip to content

Commit 145d525

Browse files
committed
GH Actions: update for the release of PHP 8.5
... which is expected to be released this Thursday. * Builds against PHP 8.5 are no longer allowed to fail. * Add _allowed to fail_ build against PHP 8.6. * Includes minor workflow step logic simplifcation. Note (same as [last year](#152)): running PHP 8.4 with dependencies: lowest will not work due to issues in Patchwork and Mockery, but raising the minimum versions of those dependencies would require dropping support for PHP < 7.1 (and maybe more). Then again... might be about time to drop support for PHP < 7.2 ? WP itself has had a PHP 7.2 minimum for a while now.
1 parent 67f4454 commit 145d525

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

.github/workflows/php-qa.yml

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ jobs:
2525
dependency-versions: 'highest'
2626
- php-versions: '8.5'
2727
dependency-versions: 'highest'
28+
- php-versions: '8.6'
29+
dependency-versions: 'highest'
2830

29-
continue-on-error: ${{ matrix.php-versions == '8.5' }}
31+
continue-on-error: ${{ matrix.php-versions == '8.6' }}
3032

3133
steps:
3234
- uses: actions/checkout@v5
@@ -45,22 +47,15 @@ jobs:
4547
if: ${{ matrix.dependency-versions == 'highest' }}
4648
run: parallel-lint ./src/ ./tests/
4749

48-
- name: Install dependencies - normal
49-
if: ${{ matrix.php-versions != '8.5' }}
50+
- name: Install dependencies
5051
uses: "ramsey/composer-install@v3"
5152
with:
5253
dependency-versions: ${{ matrix.dependency-versions }}
54+
# For PHP "nightly", we need to install with ignore platform reqs as not all dependencies may allow it yet.
55+
composer-options: ${{ matrix.php == '8.6' && '--ignore-platform-req=php+' || '' }}
5356
# Bust the cache at least once a month - output format: YYYY-MM.
5457
custom-cache-suffix: $(date -u "+%Y-%m")
5558

56-
- name: Install dependencies - ignore-platform-reqs
57-
if: ${{ matrix.php-versions == '8.5' }}
58-
uses: "ramsey/composer-install@v3"
59-
with:
60-
dependency-versions: ${{ matrix.dependency-versions }}
61-
composer-options: "--ignore-platform-reqs"
62-
custom-cache-suffix: $(date -u "+%Y-%m")
63-
6459
- name: Check cross-version PHP compatibility
6560
if: ${{ matrix.php-versions == '7.4' && matrix.dependency-versions == 'highest' }} # results is same across versions, do it once
6661
run: composer phpcompat

0 commit comments

Comments
 (0)