Drop support for PHP < 7.2

Merge pull request #182 from Brain-WP/feature/162-drop-support-for-php-lt-7.2

Author: gmazzap

.github/workflows/php-qa.yml

@@ -51,7 +51,7 @@ jobs:
 
         strategy:
             matrix:
-                php: ['5.6', '7.0', '7.4', '8.0', '8.5', 'nightly']
+                php: ['7.2', '7.4', '8.0', '8.5', 'nightly']
 
         name: "Lint: PHP ${{ matrix.php }}"
 
@@ -87,7 +87,7 @@ jobs:
 
         strategy:
             matrix:
-                php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6']
+                php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5', '8.6']
                 dependencies: ['lowest', 'highest']
 
         continue-on-error: ${{ matrix.php == '8.6' }}
@@ -126,16 +126,16 @@ jobs:
               run: ./vendor/bin/phpunit --migrate-configuration
 
             - name: Run unit tests (without code coverage)
-              if: ${{ matrix.php != '7.4' || matrix.dependencies != 'highest' || github.event.repository.fork == true }}
+              if: ${{ matrix.php != '8.1' || matrix.dependencies != 'highest' || github.event.repository.fork == true }}
               run: ./vendor/bin/phpunit
 
             - name: Run unit tests with code coverage
-              if: ${{ matrix.php == '7.4' && matrix.dependencies == 'highest' && github.event.repository.fork == false }}
+              if: ${{ matrix.php == '8.1' && matrix.dependencies == 'highest' && github.event.repository.fork == false }}
               run: ./vendor/bin/phpunit --coverage-clover=coverage.xml
 
             - name: Update codecov.io
               uses: codecov/codecov-action@671740ac38dd9b0130fbe1cec585b89eea48d3de # v5.5.2
-              if: ${{ matrix.php == '7.4' && matrix.dependencies == 'highest' && github.event.repository.fork == false }} # upload coverage once is enough
+              if: ${{ matrix.php == '8.1' && matrix.dependencies == 'highest' && github.event.repository.fork == false }} # upload coverage once is enough
               env:
                 CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
               with:

README.md

@@ -14,7 +14,7 @@ It provides **two set of helpers**:
 
 ## Requirements
 
-* PHP 5.6+
+* PHP 7.2+
 * [Composer](https://getcomposer.org/) to install
 
 Via Composer following packages are required:
@@ -24,7 +24,7 @@ Via Composer following packages are required:
 
 When installed for development, following packages are also required:
 
-* [phpunit/phpunit](https://packagist.org/packages/phpunit/phpunit) version 5.7 or higher \(BSD-3-Clause\)
+* [phpunit/phpunit](https://packagist.org/packages/phpunit/phpunit) version 8.5 or higher \(BSD-3-Clause\)
 
 ## License
 

composer.json

@@ -27,12 +27,12 @@
     },
     "license": "MIT",
     "require": {
-        "php": ">=5.6.0",
+        "php": ">=7.2.0",
         "mockery/mockery": "~1.3.6 || ~1.4.4 || ~1.5.1 || ^1.6.10",
-        "antecedent/patchwork": "^2.1.17"
+        "antecedent/patchwork": "^2.2.3"
     },
     "require-dev": {
-        "phpunit/phpunit": "^5.7.27 || ^6.5.14 || ^7.5.20 || ^8.5.49 || ^9.6.30",
+        "phpunit/phpunit": "^8.5.52 || ^9.6.34",
         "phpcompatibility/php-compatibility": "^9.3.0",
         "dealerdirect/phpcodesniffer-composer-installer": "^1.0.0"
     },
@@ -71,7 +71,7 @@
     },
     "scripts" : {
         "phpcompat": [
-            "@php ./vendor/squizlabs/php_codesniffer/bin/phpcs -ps . --standard=PHPCompatibility --ignore=*/vendor/* --parallel=10 --extensions=php --basepath=./ --runtime-set testVersion 5.6-"
+            "@php ./vendor/squizlabs/php_codesniffer/bin/phpcs -ps . --standard=PHPCompatibility --ignore=*/vendor/* --parallel=10 --extensions=php --basepath=./ --runtime-set testVersion 7.2-"
         ]
     }
 }

docs/functions-testing-tools/functions-setup.md

@@ -29,11 +29,11 @@ After Brain Monkey is part of the project \(see _Getting Started / Installation_
 Let's take PHPUnit as example, the average test case class that uses Brain Monkey would be something like:
 
 ```php
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
 use Brain\Monkey;
 
-class MyTestCase extends PHPUnit_Framework_TestCase
+class MyTestCase extends TestCase
 {
     // Adds Mockery expectations to the PHPUnit assertions count.
     use MockeryPHPUnitIntegration;
@@ -46,7 +46,7 @@ class MyTestCase extends PHPUnit_Framework_TestCase
 }
 ```
 
-After that for all test classes can extend this class instead of directly extending `PHPUnit_Framework_TestCase`.
+After that, all test classes can extend this class instead of directly extending `PHPUnit\Framework\TestCase`.
 
 That's all. Again, I used PHPUnit for the example, but any testing framework can be used.
 

docs/general/installation.md

@@ -2,7 +2,7 @@
 
 To install Brain Monkey you need:
 
-* PHP 5.6+
+* PHP 7.2+
 * [Composer](https://getcomposer.org)
 
 Brain Monkey is available on Packagist, so the only thing you need to do is to add it as a dependency for your project.

docs/what-and-why.md

@@ -48,5 +48,5 @@ All the rest is joy.
 
 ### PHP versions compatibility
 
-Currently, Brain Monkey supports PHP 5.6+.
+Currently, Brain Monkey supports PHP 7.2+.
 

docs/wordpress-specific-tools/wordpress-setup.md

@@ -22,11 +22,11 @@ These two functions are:
 PHPUnit users will probably want to add these methods to a custom test case class:
 
 ```php
-use PHPUnit_Framework_TestCase;
+use PHPUnit\Framework\TestCase;
 use Mockery\Adapter\Phpunit\MockeryPHPUnitIntegration;
 use Brain\Monkey;
 
-class MyTestCase extends PHPUnit_Framework_TestCase {
+class MyTestCase extends TestCase {
 
     // Adds Mockery expectations to the PHPUnit assertions count.
     use MockeryPHPUnitIntegration;
@@ -43,7 +43,7 @@ class MyTestCase extends PHPUnit_Framework_TestCase {
 }
 ```
 
-and then extend various test classes from it instead of directly extend `PHPUnit_Framework_TestCase`.
+and then extend various test classes from it instead of directly extending `PHPUnit\Framework\TestCase`.
 
 That's all. You are ready to use all Brain Monkey features.
 

phpunit.xml.dist

@@ -1,5 +1,5 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/7.5/phpunit.xsd"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/8.5/phpunit.xsd"
          beStrictAboutTestsThatDoNotTestAnything="false"
          bootstrap="tests/bootstrap.php"
          colors="true"

src/Name/ClosureParamStringForm.php

@@ -77,22 +77,13 @@ public static function fromString($param)
     public static function fromReflectionParameter(\ReflectionParameter $parameter)
     {
         $type = '';
-        if (PHP_MAJOR_VERSION >= 7) {
-            if ($parameter->hasType()) {
-                $type = $parameter->getType();
-                if ($type instanceof \ReflectionNamedType) {
-                    // PHP >= 7.1.
-                    $type = $type->getName();
-                }
-
-                // In PHP 7.0 the ReflectionType::__toString() method will retrieve the type.
-                $type = ltrim($type, '\\');
-            }
-        } else {
-            preg_match(self::REFLECTION_PARAM_PATTERN, $parameter->__toString(), $matches);
-            if (isset($matches[1])) {
-                $type = $matches[1];
+        if ($parameter->hasType()) {
+            $type = $parameter->getType();
+            if ($type instanceof \ReflectionNamedType) {
+                $type = $type->getName();
             }
+
+            $type = ltrim($type, '\\');
         }
 
         return new static($parameter->getName(), $type, $parameter->isVariadic());

tests/bootstrap.php

@@ -16,10 +16,3 @@
     echo 'Autoload file not found. Please run `composer install`.';
     die(1);
 }
-
-// PHPUnit cross version compatibility.
-if (class_exists('PHPUnit_Framework_Error') === true
-    && class_exists('PHPUnit\Framework\Error\Error') === false
-) {
-    class_alias('PHPUnit_Framework_Error', 'PHPUnit\Framework\Error\Error');
-}