[BUG] Deleting Node from Merged Tree

[jadeandtea]

Description

When deleting a node from a branch from the tree that has been merged farther ahead, the program does not know what to do.

Steps to Reproduce

1. Choose a case rule that create multiple branches, such as Nurikabe White or Black.
2. Make any number of steps in both or either of the branches. The move doesn't have to be valid, and the resulting cell(s) does not have to be the same between the branches.
3. Merge the two branches. There does not have to be any similar tiles; the program should allow for this type of branch --> merge.

4. Delete one of the nodes on either branch.

Expected Behavior

When deleting the node, it should delete all nodes in front of it, including the merged node.

Screenshots

No response

Puzzle Files

No response

Additional Context

No response

[ADEPLI]

Has there been an update that modified the program's behavior? The program seems to be trying to delete the node in front, although there is a visual glitch with the arrows and sometimes the node not completely updating. I don't see any commits that would have addressed this issue, but the behavior seems to have changed. Does it still appear the same for everyone else?

1. Original State

2. After Deleting Previous Node

[jadeandtea]

Progress Report

The current version of deletion does the following:

1. Remove the current node from the parent's child list in the internal Tree
2. Remove all future nodes from the displayed tree.

Clearly, this would lead to the issue above, where the program still is told to display the merged node's transition node and node through the lower chain. On my dev branch, I have a solution that will cleanly delete all the connections stemming forward from the deleted node. However, it causes problems with the undo functionality.

The current undo implementation does the following:

1. Puts the parent's child back.
2. Traverses the reconnected part of the tree and puts back the elements in the tree view.
   And that's it.

Because the disconnected part of the tree is still fully connected, by reconnecting the single link, the tree reforms and works properly. I mean, it works I guess.

I'll see if I can figure out a way to disconnect only the parts of the tree that need to be disconnected, then change the undo to reconnect only those parts.