Skip to content

Commit 47adeea

Browse files
committed
fix: correctly commerce currency on iOS to match Android
1 parent 2639ffc commit 47adeea

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/ios/BranchSDK.m

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,7 @@ - (void)sendCommerceEvent:(CDVInvokedUrlCommand*)command
239239
NSDictionary *metadata;
240240
BNCCommerceEvent *commerce = [[BNCCommerceEvent alloc] init];
241241
NSArray *categories = [NSArray arrayWithObjects:BNCProductCategoryAnimalSupplies, BNCProductCategoryApparel, BNCProductCategoryArtsEntertainment, BNCProductCategoryBabyToddler, BNCProductCategoryBusinessIndustrial, BNCProductCategoryCamerasOptics, BNCProductCategoryElectronics, BNCProductCategoryFoodBeverageTobacco, BNCProductCategoryFurniture, BNCProductCategoryHardware, BNCProductCategoryHealthBeauty, BNCProductCategoryHomeGarden, BNCProductCategoryLuggageBags, BNCProductCategoryMature, BNCProductCategoryMedia, BNCProductCategoryOfficeSupplies, BNCProductCategoryReligious, BNCProductCategorySoftware, BNCProductCategorySportingGoods, BNCProductCategoryToysGames, BNCProductCategoryVehiclesParts, nil];
242+
NSArray *currencies = [NSArray arrayWithObjects:@"AED", @"AFN", @"ALL", @"AMD", @"ANG", @"AOA", @"ARS", @"AUD", @"AWG", @"AZN", @"BAM", @"BBD", @"BDT", @"BGN", @"BHD", @"BIF", @"BMD", @"BND", @"BOB", @"BOV", @"BRL", @"BSD", @"BTN", @"BWP", @"BYN", @"BYR", @"BZD", @"CAD", @"CDF", @"CHE", @"CHF", @"CHW", @"CLF", @"CLP", @"CNY", @"COP", @"COU", @"CRC", @"CUC", @"CUP", @"CVE", @"CZK", @"DJF", @"DKK", @"DOP", @"DZD", @"EGP", @"ERN", @"ETB", @"EUR", @"FJD", @"FKP", @"GBP", @"GEL", @"GHS", @"GIP", @"GMD", @"GNF", @"GTQ", @"GYD", @"HKD", @"HNL", @"HRK", @"HTG", @"HUF", @"IDR", @"ILS", @"INR", @"IQD", @"IRR", @"ISK", @"JMD", @"JOD", @"JPY", @"KES", @"KGS", @"KHR", @"KMF", @"KPW", @"KRW", @"KWD", @"KYD", @"KZT", @"LAK", @"LBP", @"LKR", @"LRD", @"LSL", @"LYD", @"MAD", @"MDL", @"MGA", @"MKD", @"MMK", @"MNT", @"MOP", @"MRO", @"MUR", @"MVR", @"MWK", @"MXN", @"MXV", @"MYR", @"MZN", @"NAD", @"NGN", @"NIO", @"NOK", @"NPR", @"NZD", @"OMR", @"PAB", @"PEN", @"PGK", @"PHP", @"PKR", @"PLN", @"PYG", @"QAR", @"RON", @"RSD", @"RUB", @"RWF", @"SAR", @"SBD", @"SCR", @"SDG", @"SEK", @"SGD", @"SHP", @"SLL", @"SOS", @"SRD", @"SSP", @"STD", @"SYP", @"SZL", @"THB", @"TJS", @"TMT", @"TND", @"TOP", @"TRY", @"TTD", @"TWD", @"TZS", @"UAH", @"UGX", @"USD", @"USN", @"UYI", @"UYU", @"UZS", @"VEF", @"VND", @"VUV", @"WST", @"XAF", @"XAG", @"XAU", @"XBA", @"XBB", @"XBC", @"XBD", @"XCD", @"XDR", @"XFU", @"XOF", @"XPD", @"XPF", @"XPT", @"XSU", @"XTS", @"XUA", @"XXX", @"YER", @"ZAR", @"ZMW", nil];
242243

243244
if ([command.arguments count] == 2) {
244245
metadata = [command.arguments objectAtIndex:1];
@@ -250,7 +251,8 @@ - (void)sendCommerceEvent:(CDVInvokedUrlCommand*)command
250251
commerce.revenue = [NSDecimalNumber decimalNumberWithString:value];
251252
}
252253
else if ([key isEqualToString:@"currency"]) {
253-
commerce.currency = [data objectForKey:key];
254+
NSString *value = ([[data objectForKey:key] isKindOfClass:[NSString class]]) ? [data objectForKey:key] : [[data objectForKey:key] stringValue];
255+
commerce.currency = [currencies objectAtIndex:[value intValue]];
254256
}
255257
else if ([key isEqualToString:@"transactionID"]) {
256258
commerce.transactionID = [data objectForKey:key];

testbed/www/js/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function BranchCommerce () {
6969
// revenue required
7070
var event = {
7171
'revenue': 50.29,
72-
'currency': 'USD',
72+
'currency': 148, // USD
7373
'transactionID': 'transaction id',
7474
'coupon': 'coupon',
7575
'shipping': 2.22,
@@ -82,7 +82,7 @@ function BranchCommerce () {
8282
'price': 4.99,
8383
'quantity': 2,
8484
'brand': 'brand',
85-
'category': 1,
85+
'category': 17, // Software
8686
'variant': 'variant'
8787
},
8888
{

0 commit comments

Comments
 (0)