Skip to content

Commit 495e6c7

Browse files
authored
Merge pull request #448 from BranchMetrics/cleanup
v3
2 parents 9c69eb0 + 741f5a3 commit 495e6c7

File tree

3,143 files changed

+567218
-8176
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

3,143 files changed

+567218
-8176
lines changed

.gitignore

Lines changed: 6 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,9 @@
1+
/tmp/
2+
node_modules/
3+
14
.DS_Store
2-
testbed/platforms
3-
testbed/plugins
4-
testbed/hooks
5-
testbed/build.json
6-
testbed/config.xml
7-
testbed/package.json
8-
node_modules
95
.installed
10-
.gradle/
11-
.idea/
12-
tmp/
13-
cordova-ionic-phonegap-branch-deep-linking.iml
14-
local.properties
15-
out/
16-
npm-debug.log*
17-
*.map
6+
187
package-lock.json
19-
yarn-error.log
8+
npm-debug.log*
9+
yarn-error.log*

.npmignore

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
1-
node_modules
1+
/examples/
2+
/tmp/
3+
node_modules/
4+
5+
.DS_Store
26
.installed
3-
tests/
4-
testbed/
7+
8+
npm-debug.log*
9+
yarn-error.log*
10+
11+
package-lock.json
512
plugin.template.xml
613
gulpfile.js
7-
CONTRIBUTING.md
8-
travis_after_all.py
9-
yarn.lock
14+
CONTRIBUTING.md

.travis.yml

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,21 @@
11
sudo: false
22
language: node_js
3+
node_js:
4+
- 9
5+
- 8
6+
- 7
37
cache:
8+
yarn: true
49
directories:
510
- node_modules
611
notifications:
712
email: false
8-
node_js:
9-
- '6'
10-
before_install:
11-
- npm i -g npm@^2.0.0
12-
before_script:
13-
- curl -Lo travis_after_all.py https://git.io/vLSON
14-
- npm prune
13+
install:
14+
- npm install
1515
script:
1616
- npm run validate
17-
- npm run changelog
1817
after_success:
19-
- python travis_after_all.py
20-
- npm run semantic-release
18+
- npm run travis-deploy-once "npm run semantic-release"
2119
branches:
2220
only:
2321
- master

CONTRIBUTING.md

Lines changed: 42 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,27 @@
11
# Contributing
22

3-
*Questions? [Contact us](https://support.branch.io/support/tickets/new)*
3+
_Questions? [Contact us](https://support.branch.io/support/tickets/new)_
44

5-
1. [Todo](#todo)
6-
1. [Data Flow](#data-flow)
7-
1. [Dependencies](#dependencies)
8-
1. [Setup](#setup)
9-
1. [Develop](#develop)
10-
1. [Test](#test)
11-
1. [Submit](#submit)
12-
1. [Publish](#publish)
5+
1. [Todo](#todo)
6+
1. [Data Flow](#data-flow)
7+
1. [Dependencies](#dependencies)
8+
1. [Setup](#setup)
9+
1. [Develop](#develop)
10+
1. [Test](#test)
11+
1. [Submit](#submit)
12+
1. [Publish](#publish)
1313

1414
## Data Flow
1515

16-
- [Users sets values](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/testbed/config.template.xml#L6-L13)
17-
- [Hooks run on build](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/plugin.xml#L45-L47)
18-
- [Hooks call scripts](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/hooks)
19-
- [Scripts for iOS](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/ios)
20-
- [Scripts for Android](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/android)
16+
* [Users sets values](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/testbed/config.template.xml#L6-L13)
17+
* [Hooks run on build](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/plugin.xml#L45-L47)
18+
* [Hooks call scripts](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/hooks)
19+
* [Scripts for iOS](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/ios)
20+
* [Scripts for Android](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/tree/master/src/scripts/android)
2121

2222
## Dependencies
2323

24-
- Homebrew
24+
* Homebrew
2525

2626
```sh
2727
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)";
@@ -30,27 +30,21 @@
3030
export PATH="/usr/local/bin:$PATH";
3131
```
3232

33-
- Node
33+
* Node
3434

3535
```sh
3636
brew install node;
3737
```
3838

39-
- Gulp
40-
41-
```sh
42-
npm install -g gulp-cli; # linter
43-
```
44-
45-
- Yarn
39+
* Yarn
4640

4741
```sh
4842
npm install -g yarn # faster npm
4943
```
5044

5145
## Setup
5246

53-
- Local
47+
* Local
5448

5549
```sh
5650
git clone [email protected]:BranchMetrics/cordova-ionic-phonegap-branch-deep-linking.git;
@@ -60,60 +54,52 @@
6054

6155
## Develop
6256

63-
- Changes to `/src` don't need a `init.sh` rebuild, just a `cordova run ios`
57+
* Changes to `/src` don't need a `yarn examples` rebuild, just a `cordova run`
58+
* Changes to `/src/index.js` need changes to `testbed/platforms/ios/platform_www/plugins/branch-cordova-sdk` and a `cordova run ios`
6459

65-
- **[optional]** Update [Android](https://github.com/BranchMetrics/android-branch-deep-linking/releases) and [iOS](https://github.com/BranchMetrics/ios-branch-deep-linking/releases) SDKs
60+
* **[optional]** Update [Android](https://github.com/BranchMetrics/android-branch-deep-linking/releases) and [iOS](https://github.com/BranchMetrics/ios-branch-deep-linking/releases) SDKs
6661

6762
```sh
68-
./src/scripts/npm/updateNativeSdk.sh -a 2.5.9
63+
./src/scripts/npm/updateNativeSdk.sh -a 2.5.9
6964
./src/scripts/npm/updateNativeSdk.sh -i 0.13.5
7065
```
7166

72-
- **[optional]** Update `CHANGELOG.md`
73-
74-
```sh
75-
npm run changelog
76-
```
77-
7867
## Test
7968

80-
- Validate all features on both `iOS` and `Android` on `device` only (no `simulator` or `TestFlight`)
69+
* Validate all features on both `iOS` and `Android` on `device` only (no `simulator` or `TestFlight`)
8170

82-
- ios
71+
* build
8372

8473
```sh
85-
./testbed/init -idc
74+
cd ./
75+
yarn examples
8676
```
87-
88-
- android
8977

9078
```sh
91-
./testbed/init -adc
79+
cd examples/cordova1
80+
# (plug in devices)
81+
# (ionic build if ionic 3)
82+
cordova run ios
83+
cordova run android
9284
```
9385

94-
- files
95-
96-
- test `branch.js` with console logs to Safari and Chrome inspectors
97-
- test `hooks` by changing to `before_prepare` and console logs with `cordova build`
98-
- test `BranchSDK.m` with `NSLog()` with Xcode
99-
- test `BranchSDK.java` with `system.out.println()` with Android Studio
86+
* files
87+
88+
* test `index.js` with console logs to Safari and Chrome inspectors
89+
* test `hooks` by changing to `before_prepare` and console logs with `cordova build`
90+
* test `BranchSDK.m` with `NSLog()` with Xcode
91+
* test `BranchSDK.java` with `system.out.println()` with Android Studio
10092
10193
## Submit
10294
103-
- **[required]** Git [comment prefix](https://github.com/semantic-release/semantic-release): `feat`, `fix`, `docs`, `style`, `refactor`, `perf`, `test`, `chore`, `revert`
95+
* **[required]** Git [comment prefix](https://github.com/semantic-release/semantic-release): `feat`, `fix`, `docs`, `style`, `refactor`, `perf`, `test`, `chore`, `revert`
10496
105-
- Versioning and tags are handled automatically based on commit messages
97+
* Versioning and tags are handled automatically based on commit messages
10698
107-
- Submit code with a [pull request](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking)
99+
* Submit code with a [pull request](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking)
108100
109101
## Publish
110102
111-
- Pull request code review from a Branch team member
112-
113-
- Merges will automatically add SDK to NPM
114-
115-
## Additional
103+
* Pull request code review from a Branch team member
116104
117-
- `<plugin name="branch-cordova-sdk" spec="../" />` or `cordova plugin add ../` causes an infinite loop when importing Branch on Cordova 7.0.1. Works on Cordova 6.5.0.
118-
- need to remove `TODO` from `init.sh` for `ios-sim` error
119-
- `cordova platform update [email protected]` added for Cordova 6.5.0 error on Android
105+
* Merges will automatically add SDK to NPM

LICENSE renamed to LICENSE.md

File renamed without changes.

0 commit comments

Comments
 (0)