Skip to content

Commit 717c87f

Browse files
authored
Merge pull request #309 from BranchMetrics/fix-android-only
Fix android only
2 parents 5ad804a + a4a5682 commit 717c87f

File tree

7 files changed

+13
-8
lines changed

7 files changed

+13
-8
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "branch-cordova-sdk",
33
"description": "Branch Metrics Cordova SDK",
44
"main": "www/branch.js",
5-
"version": "2.5.12",
5+
"version": "2.5.13",
66
"homepage": "https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking",
77
"repository": {
88
"type": "git",
@@ -39,7 +39,7 @@
3939
"changelog": "node ./src/scripts/npm/updateChangeLog -reset=true",
4040
"commitmsg": "validate-commit-msg",
4141
"precommit": "gulp prod",
42-
"prepush": "semantic-release pre --verifyRelease='./src/scripts/npm/updateNpmVersion' || true",
42+
"postcommit": "semantic-release pre --verifyRelease='./src/scripts/npm/updateNpmVersion' || true",
4343
"prerelease": "gulp prod",
4444
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
4545
},

plugin.template.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ SOFTWARE.
2424
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
2525
xmlns:android="http://schemas.android.com/apk/res/android"
2626
id="branch-cordova-sdk"
27-
version="2.5.12">
27+
version="2.5.13">
2828

2929
<!-- DO NOT EDIT THIS FILE. MAKE ALL CHANGES TO plugin.template.xml INSTEAD -->
3030

plugin.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ SOFTWARE.
2424
<plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"
2525
xmlns:android="http://schemas.android.com/apk/res/android"
2626
id="branch-cordova-sdk"
27-
version="2.5.12">
27+
version="2.5.13">
2828

2929
<!-- DO NOT EDIT THIS FILE. MAKE ALL CHANGES TO plugin.template.xml INSTEAD -->
3030

src/scripts/android/updateAndroidManifest.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,8 @@
197197
intentFilterData.push(getAppLinkIntentFilterDictionary(alternate))
198198
} else if (linkDomain.indexOf('bnc.lt') !== -1) {
199199
// bnc.lt
200-
if (preferences.androidPrefix == null) {
201-
throw new Error('BRANCH SDK: Missing "android-prefix" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP')
200+
if (preferences.androidPrefix === null) {
201+
throw new Error('BRANCH SDK: Invalid "android-prefix" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP')
202202
}
203203
intentFilterData.push(getAppLinkIntentFilterDictionary(linkDomain, preferences.androidPrefix))
204204
} else {

src/scripts/ios/updateDevelopmentTeam.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@
8585
var release = preferences.iosTeamRelease
8686
var debug = (preferences.iosTeamDebug) ? preferences.iosTeamDebug : preferences.iosTeamRelease
8787

88+
if (release === null) {
89+
throw new Error('BRANCH SDK: Invalid "ios-team-release" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP')
90+
}
91+
8892
content.ios.release.developmentTeam = release
8993
content.ios.debug.developmentTeam = debug
9094
}

src/scripts/npm/processConfigXml.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
'uriScheme': getBranchValue(branchXml, 'uri-scheme'),
5555
'iosBundleId': getBundleId(configXml, 'ios'),
5656
'iosProjectModule': getProjectModule(context),
57-
'iosTeamRelease': getBranchValue(branchXml, 'ios-team-release'),
57+
'iosTeamRelease': getBranchValue(branchXml, 'ios-team-release'), // optional
5858
'iosTeamDebug': getBranchValue(branchXml, 'ios-team-debug'), // optional
5959
'androidBundleId': getBundleId(configXml, 'android'), // optional
6060
'androidPrefix': getBranchValue(branchXml, 'android-prefix'), // optional
@@ -136,7 +136,7 @@
136136
if (preferences.iosBundleId === null || !/^[a-zA-Z0-9.]*$/.test(preferences.iosBundleId)) {
137137
throw new Error('BRANCH SDK: Invalid "id" or "ios-CFBundleIdentifier" in <widget> in your config.xml. Docs https://goo.gl/GijGKP')
138138
}
139-
if (preferences.iosTeamRelease === null || !/^[a-zA-Z0-9]{10}$/.test(preferences.iosTeamRelease)) {
139+
if (preferences.iosTeamRelease !== null && !/^[a-zA-Z0-9]{10}$/.test(preferences.iosTeamRelease)) {
140140
throw new Error('BRANCH SDK: Invalid "ios-team-release" in <branch-config> in your config.xml. Docs https://goo.gl/GijGKP')
141141
}
142142
if (preferences.iosTeamDebug !== null && !/^[a-zA-Z0-9]{10}$/.test(preferences.iosTeamDebug)) {

testbed/www/css/index.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ body {
1010
button, input {
1111
padding: 0.5em;
1212
border: 3px solid #F5F5F5;
13+
width: 100%;
1314
}
1415
button {
1516
background-color: #F5F5F5;

0 commit comments

Comments
 (0)