Skip to content

Commit 77462f9

Browse files
committed
fix: correct early exit on auto npm version
1 parent d6f8bcb commit 77462f9

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
"scripts": {
3939
"commitmsg": "validate-commit-msg",
4040
"precommit": "gulp prod",
41-
"postcommit": "semantic-release pre --verifyRelease='./src/scripts/npm/nodeVersion'",
41+
"postcommit": "semantic-release pre --verifyRelease='./src/scripts/npm/updateNpmVersion'",
4242
"prerelease": "gulp prod",
4343
"semantic-release": "semantic-release pre && npm publish && semantic-release post"
4444
},
@@ -59,4 +59,4 @@
5959
"validate-commit-msg": "^2.8.2",
6060
"xml2js": "^0.4.17"
6161
}
62-
}
62+
}

src/scripts/npm/updateNpmVersion.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
var exec = require('child_process').exec
66
var fileHelper = require('../lib/fileHelper.js')
77
var FILES = ['package.json', 'plugin.xml', 'plugin.template.xml']
8+
var isChange = false
89

910
// entry
1011
module.exports = updateNpmVersion
@@ -21,14 +22,12 @@
2122
var content = readContent(file)
2223
var updated = updateVersion(file, content, version)
2324

24-
// early exit (made no changes)
25-
if (content === updated) return
26-
2725
// save
2826
git += 'git add ' + file + ' && '
2927
saveContent(file, updated)
3028
}
31-
commitChanges(git, version)
29+
// publish
30+
isChange && commitChanges(git, version)
3231
}
3332

3433
// handle content
@@ -53,6 +52,7 @@
5352
if (isFileXml(file)) {
5453
content = content.replace(prev, next)
5554
} else {
55+
isChange = content.version !== version
5656
content.version = version
5757
}
5858
} catch (e) {

0 commit comments

Comments
 (0)