Skip to content

Commit a6391d0

Browse files
committed
fix: updated testbed init after errors in cordova
1 parent f2abfa4 commit a6391d0

File tree

4 files changed

+18
-8438
lines changed

4 files changed

+18
-8438
lines changed

CONTRIBUTING.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
*Questions? [Contact us](https://support.branch.io/support/tickets/new)*
44

5+
1. [Todo](#todo)
56
1. [Data Flow](#data-flow)
67
1. [Dependencies](#dependencies)
78
1. [Setup](#setup)
@@ -10,6 +11,12 @@
1011
1. [Submit](#submit)
1112
1. [Publish](#publish)
1213

14+
## TODO
15+
16+
- `<plugin name="branch-cordova-sdk" spec="../" />` or `cordova plugin add ../` causes an infinite loop when importing Branch on Cordova 7.0.1. Works on Cordova 6.5.0.
17+
- need to remove `TODO` from `init.sh` for `ios-sim` error
18+
- `cordova platform update [email protected]` added for Cordova 6.5.0 error on Android
19+
1320
## Data Flow
1421

1522
- [Users sets values](https://github.com/BranchMetrics/cordova-ionic-phonegap-branch-deep-linking/blob/master/testbed/config.template.xml#L6-L13)

testbed/config.template.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
<widget id="com.eneff.branch.cordovatestbed" version="1.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
33
<!-- Branch -->
44

5-
<!-- uncomment the following line if building locally and not contributing -->
6-
<!-- <plugin name="branch-cordova-sdk" /> -->
5+
<!-- remove spec to switch from local to npm -->
6+
<plugin name="branch-cordova-sdk" spec="../" />
77
<branch-config>
88
<branch-key value="key_live_ndqptlgXNE4LHqIahH1WIpbiyFlb62J3" />
99
<uri-scheme value="branchcordova" />

testbed/init.sh

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -71,25 +71,27 @@ main() {
7171
gulp prod
7272

7373
# config
74-
yes | \cp -f config.template.xml config.xml
74+
cp config.template.xml config.xml
7575

7676
# build (platforms added before plugin because before_plugin_install does not work on file reference)
7777
if [[ "$run_ios" == "true" ]]; then
7878
cordova platform add ios
7979
fi
8080
if [[ "$run_and" == "true" ]]; then
8181
cordova platform add android
82+
# TODO: remove for cordova 6.5.0
83+
cordova platform update [email protected]
8284
fi
8385

8486
# TODO: remove this cordova error fix (https://stackoverflow.com/questions/42350505/error-cannot-read-property-replace-of-undefined-when-building-ios-cordova)
85-
if [[ "$run_ios" == "true" ]]; then
86-
cd ./platforms/ios/cordova/node_modules/
87-
npm install ios-sim@latest
88-
cd ../../../../
89-
fi
87+
# if [[ "$run_ios" == "true" ]]; then
88+
# cd ./platforms/ios/cordova/node_modules/
89+
# npm install ios-sim@latest
90+
# cd ../../../../
91+
# fi
9092

9193
# plugin
92-
cordova plugin add ../
94+
# cordova plugin add ../
9395

9496
# run
9597
if [[ "$run_ios" == "true" ]]; then

0 commit comments

Comments
 (0)