SDK-1440 enable android logging. Fix issue with iOS logging. Add note about early lifecycle events prior to JS runtime init

Author: echo-branch

src/android/io/branch/BranchSDK.java

@@ -527,15 +527,19 @@ private void setCookieBasedMatching(String linkDomain, CallbackContext callbackC
     }
 
     /**
-     * <p>Sets the library to function in debug mode, enabling logging of all requests.</p>
-     * <p>If you want to flag debug, call this <b>before</b> initUserSession</p>
+     * <p>Enabling Branch SDK logging</p>
      *
-     * @param isEnable        A {@link Boolean} value to enable/disable debugging mode for the app.
+     * @param isEnable        A {@link Boolean} value to enable/disable logging
      * @param callbackContext A callback to execute at the end of this method
      */
-    private void setDebug(boolean isEnable, CallbackContext callbackContext) {
+    private void setLogging(boolean isEnable, CallbackContext callbackContext) {
         this.activity = this.cordova.getActivity();
-        Branch.enableDebugMode();
+        if (isEnable == true) {
+            Branch.enableLogging();
+        } else {
+            Branch.disableLogging();
+        }
+
         callbackContext.sendPluginResult(new PluginResult(PluginResult.Status.OK, isEnable));
     }
 

src/index.js

@@ -120,6 +120,7 @@ Branch.prototype.setDebug = function setDebug(isEnabled) {
   });
 };
 
+// For early lifecycle logging, we recommend you enable logging in the native iOS or Android code.
 Branch.prototype.setLogging = function setLogging(isEnabled) {
   var value = typeof isEnabled !== "boolean" ? false : isEnabled;
   this.enableLogging = value;

src/ios/BranchSDK.m

@@ -160,7 +160,7 @@ - (void)enableLogging:(CDVInvokedUrlCommand*)command
     [[Branch getInstance] enableLogging];
   }
 
-  CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsBool:enableDebug];
+  CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsBool:enableLogging];
 
   [self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
 }