Skip to content

Commit f67eb65

Browse files
authored
Merge pull request #391 from BranchMetrics/fix-associated-domains
fix: corrected the duplication of custom link domains in the iOS enti…
2 parents eb06417 + 2491956 commit f67eb65

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

src/scripts/ios/updateAssociatedDomains.js

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -77,25 +77,40 @@
7777
var prev = entitlements[ASSOCIATED_DOMAINS]
7878
var next = updateAssociatedDomains(preferences)
7979

80-
prev = removePreviousAssociatedDomains(prev)
80+
prev = removePreviousAssociatedDomains(preferences, prev)
8181
entitlements[ASSOCIATED_DOMAINS] = domains.concat(prev, next)
8282

8383
return entitlements
8484
}
8585

8686
// removed previous associated domains related to Branch (will not remove link domain changes from custom domains or custom sub domains)
87-
function removePreviousAssociatedDomains (domains) {
87+
function removePreviousAssociatedDomains (preferences, domains) {
8888
var output = []
89+
var linkDomains = preferences.linkDomain
90+
8991
if (!domains) return output
9092
for (var i = 0; i < domains.length; i++) {
9193
var domain = domains[i]
92-
if (domain.indexOf('bnc.lt') > 0 || domain.indexOf('app.link') > 0) continue
93-
output.push(domain)
94+
if (domain.indexOf('applinks:') === 0) {
95+
domain = domain.replace('applinks:', '')
96+
if (isBranchAssociatedDomains(domain, linkDomains)) {
97+
output.push('applinks:' + domain)
98+
}
99+
} else {
100+
if (isBranchAssociatedDomains(domain, linkDomains)) {
101+
output.push(domain)
102+
}
103+
}
94104
}
95105

96106
return output
97107
}
98108

109+
// determine if previous associated domain is related to Branch (to prevent duplicates when appending new)
110+
function isBranchAssociatedDomains (domain, linkDomains) {
111+
return !(domain.indexOf('bnc.lt') > 0 || domain.indexOf('app.link') > 0 || linkDomains.indexOf(domain) >= 0)
112+
}
113+
99114
// determine which Branch Link Domains to append
100115
function updateAssociatedDomains (preferences) {
101116
var domainList = []

0 commit comments

Comments
 (0)