Reverted back logic of caching identity if session is uninitialized.

Author: NidhiDixit09

BranchSDK/Branch.h

@@ -1857,6 +1857,7 @@ typedef NS_ENUM(NSUInteger, BranchCreditHistoryOrder) {
 #endif
 
 @property (copy, nonatomic, nullable) NSString *installUserId;
+@property (copy, nonatomic, nullable) callbackWithParams setIdentityCallback;
 
 @end
 

BranchSDK/Branch.m

@@ -1049,11 +1049,36 @@ - (void)setIdentity:(NSString *)userId {
 }
 
 - (void)setIdentity:(NSString *)userId withCallback:(callbackWithParams)callback {
-    if (userId) {
+    if (!userId || [self.preferenceHelper.userIdentity isEqualToString:userId]) {
+        if (callback) {
+            callback([self getFirstReferringParams], nil);
+        }
+        return;
+    }
+    
+    if (self.initializationStatus == BNCInitStatusUninitialized ) {
+        [self cacheIdentity:userId withCallback:callback];
+    } else {
         self.preferenceHelper.userIdentity = userId;
+        if (callback) {
+            callback([self getFirstReferringParams], nil);
+        }
     }
-    if (callback) {
-        callback([self getFirstReferringParams], nil);
+}
+
+- (void) cacheIdentity: (NSString *)userId withCallback:(callbackWithParams)callback {
+    self.installUserId = userId;
+    self.setIdentityCallback = callback;
+}
+
+- (void) applySavedIdentity {
+    if (self.installUserId != nil) {
+        self.preferenceHelper.userIdentity = self.installUserId;
+        if (self.setIdentityCallback) {
+            self.setIdentityCallback([self getFirstReferringParams], nil);
+        }
+        self.installUserId = nil;
+        self.setIdentityCallback = nil;
     }
 }
 
@@ -2262,7 +2287,8 @@ - (void)handleInitSuccessAndCallCallback:(BOOL)callCallback sceneIdentifier:(NSS
         }
     }
     [self sendOpenNotificationWithLinkParameters:latestReferringParams error:nil];
-
+    
+    [self applySavedIdentity];
 
     if (!self.urlFilter.hasUpdatedPatternList) {
         [self.urlFilter updatePatternListWithCompletion:nil];