Fixed Xcode 9 compiler warnings. (#649)

Author: E-B-Smith

Branch-SDK/Branch-SDK/BNCDebug.h

@@ -61,7 +61,7 @@ extern "C" {
 
 
 ///@return  Returns true if the app is currently attached to a debugger.
-extern BOOL BNCDebuggerIsAttached();
+extern BOOL BNCDebuggerIsAttached(void);
 
 
 ///@param   object An obj-c instance, class, or meta-class.
@@ -71,7 +71,7 @@ extern NSString* _Nonnull BNCDebugStringFromObject(id _Nullable object);
 
 
 ///@return  Returns the names of all loaded classes as an array of NSStrings.
-extern NSArray<NSString*> * _Nonnull BNCDebugArrayOfReqisteredClasses();
+extern NSArray<NSString*> * _Nonnull BNCDebugArrayOfReqisteredClasses(void);
 
 
 ///@return  Returns an NSString indicating the name of the enclosing method.

Branch-SDK/Branch-SDK/BNCDeviceInfo.m

@@ -116,7 +116,7 @@ + (NSString*) systemBuildVersion {
 + (NSString*) userAgentString {
 
     static NSString* browserUserAgentString = nil;
-	void (^setBrowserUserAgent)() = ^() {
+	void (^setBrowserUserAgent)(void) = ^() {
 		if (!browserUserAgentString) {
 			browserUserAgentString =
 				[[[UIWebView alloc]

Branch-SDK/Branch-SDK/BNCLog.h

@@ -44,7 +44,7 @@ typedef NS_ENUM(NSInteger, BNCLogLevel) {
 /*!
 * @return Returns the current log severity display level.
 */
-extern BNCLogLevel BNCLogDisplayLevel();
+extern BNCLogLevel BNCLogDisplayLevel(void);
 
 /*!
 * @param level Sets the current display level for log messages.
@@ -67,14 +67,14 @@ extern void BNCLogSetSynchronizeMessages(BOOL enable);
 
 /*!@return Returns YES if log messages are synchronized between threads.
 */
-extern BOOL BNCLogSynchronizeMessages();
+extern BOOL BNCLogSynchronizeMessages(void);
 
 
 #pragma mark - Programmatic Breakpoints
 
 
 ///@return Returns 'YES' if programmatic breakpoints are enabled.
-extern BOOL BNCLogBreakPointsAreEnabled();
+extern BOOL BNCLogBreakPointsAreEnabled(void);
 
 ///@param enabled Sets programmatic breakpoints enabled or disabled.
 extern void BNCLogSetBreakPointsEnabled(BOOL enabled);
@@ -96,10 +96,10 @@ extern void BNCLogFunctionOutputToStdErr(NSDate*_Nonnull timestamp, BNCLogLevel
 extern void BNCLogSetOutputFunction(BNCLogOutputFunctionPtr _Nullable functionPtr);
 
 ///@return Returns the current logging function.
-extern BNCLogOutputFunctionPtr _Nullable BNCLogOutputFunction();
+extern BNCLogOutputFunctionPtr _Nullable BNCLogOutputFunction(void);
 
 /// If a predefined log handler is being used, the function closes the output file.
-extern void BNCLogCloseLogFile();
+extern void BNCLogCloseLogFile(void);
 
 ///@param URL Sets the log output function to a function that writes messages to the file at URL.
 extern void BNCLogSetOutputToURL(NSURL *_Nullable URL);
@@ -112,15 +112,15 @@ extern void BNCLogSetOutputToURLRecordWrap(NSURL *_Nullable URL, long maxRecords
 ///@param maxBytes Wraps the file at `maxBytes` bytes.  Must be an even number of bytes.
 extern void BNCLogSetOutputToURLByteWrap(NSURL *_Nullable URL, long maxBytes);
 
-typedef void (*BNCLogFlushFunctionPtr)();
+typedef void (*BNCLogFlushFunctionPtr)(void);
 
 ///@param flushFunction The logging functions use `flushFunction` to flush the outstanding log
 ///                     messages to the output function.  For instance, this function may call
 ///                     `fsync` to assure that the log messages are written to disk.
 extern void BNCLogSetFlushFunction(BNCLogFlushFunctionPtr _Nullable flushFunction);
 
 ///@return Returns the current flush function.
-extern BNCLogFlushFunctionPtr _Nullable BNCLogFlushFunction();
+extern BNCLogFlushFunctionPtr _Nullable BNCLogFlushFunction(void);
 
 
 #pragma mark - BNCLogWriteMessage
@@ -145,7 +145,7 @@ extern void BNCLogWriteMessage(
 
 /// This function synchronizes all outstanding log messages and writes them to the logging function
 /// set by BNCLogSetOutputFunction.
-extern void BNCLogFlushMessages();
+extern void BNCLogFlushMessages(void);
 
 
 #pragma mark - Logging

Branch-SDK/Branch-SDK/BNCLog.m

@@ -583,8 +583,8 @@ void BNCLogFlushMessages() {
 
 #pragma mark - BNCLogInitialize
 
-void BNCLogInitialize() __attribute__((constructor));
-void BNCLogInitialize() {
+void BNCLogInitialize(void) __attribute__((constructor));
+void BNCLogInitialize(void) {
     static dispatch_once_t onceToken = 0;
     dispatch_once(&onceToken, ^ {
         bnc_LogQueue = dispatch_queue_create("io.branch.log", DISPATCH_QUEUE_SERIAL);

Branch-SDK/Branch-SDK/BNCPreferenceHelper.h

@@ -11,7 +11,7 @@
 #define FILE_NAME   [[NSString stringWithUTF8String:__FILE__] lastPathComponent]
 #define LINE_NUM    __LINE__
 
-NSURL* /* _Nonnull */ BNCURLForBranchDirectory();
+NSURL* /* _Nonnull */ BNCURLForBranchDirectory(void);
 
 @interface BNCPreferenceHelper : NSObject
 

Branch-SDK/Branch-SDK/Branch.m

@@ -73,8 +73,8 @@
 
 #pragma mark - Load Categories
 
-void ForceCategoriesToLoad();
-void ForceCategoriesToLoad() {
+void ForceCategoriesToLoad(void);
+void ForceCategoriesToLoad(void) {
     ForceNSMutableDictionaryToLoad();
 }
 

Branch-SDK/Branch-SDK/NSMutableDictionary+Branch.h

@@ -10,7 +10,7 @@
 #import <Foundation/Foundation.h>
 
 
-void ForceNSMutableDictionaryToLoad();
+void ForceNSMutableDictionaryToLoad(void);
 
 
 @interface NSMutableDictionary (Branch)

Branch-SDK/Branch-SDK/NSMutableDictionary+Branch.m

@@ -31,6 +31,6 @@ - (void) bnc_safeAddEntriesFromDictionary:(NSDictionary<id<NSCopying>,id> *)othe
 @end
 
 
-void ForceNSMutableDictionaryToLoad() {
+void ForceNSMutableDictionaryToLoad(void) {
     //  Does nothing.  But will force the linker to include this category.
 }

Branch-SDK/Branch-SDK/NSString+Branch.m

@@ -16,7 +16,7 @@
 #import "NSString+Branch.h"
 
 
-void BNCForceNSStringCategoryToLoad() __attribute__((constructor));
+void BNCForceNSStringCategoryToLoad(void) __attribute__((constructor));
 void BNCForceNSStringCategoryToLoad() {
     //  Nothing here, but forces linker to load the category.
 }

Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj

@@ -753,7 +753,7 @@
 		670016581940F51400A9E103 /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0830;
+				LastUpgradeCheck = 0900;
 				ORGANIZATIONNAME = "Branch Metrics";
 				TargetAttributes = {
 					466B58371B17773000A69EDE = {
@@ -1049,14 +1049,20 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
@@ -1094,14 +1100,20 @@
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = NO;
 				CLANG_ENABLE_OBJC_ARC = YES;
+				CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
 				CLANG_WARN_BOOL_CONVERSION = YES;
+				CLANG_WARN_COMMA = YES;
 				CLANG_WARN_CONSTANT_CONVERSION = YES;
 				CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
 				CLANG_WARN_EMPTY_BODY = YES;
 				CLANG_WARN_ENUM_CONVERSION = YES;
 				CLANG_WARN_INFINITE_RECURSION = YES;
 				CLANG_WARN_INT_CONVERSION = YES;
+				CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
+				CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
 				CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
+				CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
+				CLANG_WARN_STRICT_PROTOTYPES = YES;
 				CLANG_WARN_SUSPICIOUS_MOVE = YES;
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;