remove some link creation methods

Author: aaustin

Branch-SDK/Branch-SDK/Branch.h

@@ -793,44 +793,6 @@ typedef NS_ENUM(NSUInteger, BranchCreditHistoryOrder) {
  */
 - (NSString *)getShortUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andAlias:(NSString *)alias andChannel:(NSString *)channel andFeature:(NSString *)feature andStage:(NSString *)stage andMatchDuration:(NSUInteger)duration;
 
-/**
- Get a short url with specified params and channel. The usage type will default to unlimited. Content Urls use the feature `BRANCH_FEATURE_TAG_SHARE`.
- 
- @param params Dictionary of parameters to include in the link.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @warning This method makes a synchronous url request.
- */
-- (NSString *)getContentUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel;
-
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Content Urls use the feature `BRANCH_FEATURE_TAG_SHARE`.
- 
- @param params Dictionary of parameters to include in the link.
- @param tags An array of tags to associate with this link, useful for tracking.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @warning This method makes a synchronous url request.
- */
-- (NSString *)getContentUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel;
-
-/**
- Get a short url with specified params and channel. The usage type will default to unlimited. Referral Urls use the feature `BRANCH_FEATURE_TAG_REFERRAL`.
- 
- @param params Dictionary of parameters to include in the link.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @warning This method makes a synchronous url request.
- */
-- (NSString *)getReferralUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel;
-
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Referral Urls use the feature `BRANCH_FEATURE_TAG_REFERRAL`.
- 
- @param params Dictionary of parameters to include in the link.
- @param tags An array of tags to associate with this link, useful for tracking.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @warning This method makes a synchronous url request.
- */
-- (NSString *)getReferralUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel;
-
 #pragma mark - Long Url generation
 
 ///--------------------------
@@ -1041,44 +1003,6 @@ typedef NS_ENUM(NSUInteger, BranchCreditHistoryOrder) {
  */
 - (void)getShortUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andAlias:(NSString *)alias andMatchDuration:(NSUInteger)duration andChannel:(NSString *)channel andFeature:(NSString *)feature andStage:(NSString *)stage andCallback:(callbackWithUrl)callback;
 
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Content Urls use the feature `BRANCH_FEATURE_TAG_SHARE`.
- 
- @param params Dictionary of parameters to include in the link.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @param callback Callback called with the url.
- */
-- (void)getContentUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback;
-
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Content Urls use the feature `BRANCH_FEATURE_TAG_SHARE`.
- 
- @param params Dictionary of parameters to include in the link.
- @param tags An array of tags to associate with this link, useful for tracking.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @param callback Callback called with the url.
- */
-- (void)getContentUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback;
-
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Referral Urls use the feature `BRANCH_FEATURE_TAG_REFERRAL`.
- 
- @param params Dictionary of parameters to include in the link.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @param callback Callback called with the url.
- */
-- (void)getReferralUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback;
-
-/**
- Get a short url with specified params, tags, and channel. The usage type will default to unlimited. Referral Urls use the feature `BRANCH_FEATURE_TAG_REFERRAL`.
- 
- @param params Dictionary of parameters to include in the link.
- @param tags An array of tags to associate with this link, useful for tracking.
- @param channel The channel for the link. Examples could be Facebook, Twitter, SMS, etc, depending on where it will be shared.
- @param callback Callback called with the url.
- */
-- (void)getReferralUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback;
-
 - (void)getSpotlightUrlWithParams:(NSDictionary *)params callback:(callbackWithParams)callback;
 
 #pragma mark - Content Discovery methods

Branch-SDK/Branch-SDK/Branch.m

@@ -681,25 +681,6 @@ - (BranchLinkProperties *)getLatestReferringBranchLinkProperties {
     return nil;
 }
 
-#pragma mark - ContentUrl methods
-
-- (NSString *)getContentUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel {
-    return [self generateShortUrl:nil andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_SHARE andStage:nil andParams:params ignoreUAString:nil forceLinkCreation:NO];
-}
-
-- (NSString *)getContentUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel {
-    return [self generateShortUrl:tags andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_SHARE andStage:nil andParams:params ignoreUAString:nil forceLinkCreation:NO];
-}
-
-- (void)getContentUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback {
-    [self generateShortUrl:tags andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_SHARE andStage:nil andParams:params andCallback:callback];
-}
-
-- (void)getContentUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback {
-    [self generateShortUrl:nil andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_SHARE andStage:nil andParams:params andCallback:callback];
-}
-
-
 #pragma mark - ShortUrl methods
 
 - (NSString *)getShortURL {
@@ -893,23 +874,6 @@ - (void)createDiscoverableContentWithTitle:(NSString *)title description:(NSStri
     [self.contentDiscoveryManager indexContentWithTitle:title description:description publiclyIndexable:publiclyIndexable type:type thumbnailUrl:thumbnailUrl keywords:keywords userInfo:linkParams expirationDate:expirationDate callback:nil spotlightCallback:spotlightCallback];
 }
 
-#pragma mark - Referral methods
-
-- (NSString *)getReferralUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel {
-    return [self generateShortUrl:tags andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_REFERRAL andStage:nil andParams:params ignoreUAString:nil forceLinkCreation:NO];
-}
-
-- (NSString *)getReferralUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel {
-    return [self generateShortUrl:nil andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_REFERRAL andStage:nil andParams:params ignoreUAString:nil forceLinkCreation:NO];
-}
-
-- (void)getReferralUrlWithParams:(NSDictionary *)params andTags:(NSArray *)tags andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback {
-    [self generateShortUrl:tags andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_REFERRAL andStage:nil andParams:params andCallback:callback];
-}
-
-- (void)getReferralUrlWithParams:(NSDictionary *)params andChannel:(NSString *)channel andCallback:(callbackWithUrl)callback {
-    [self generateShortUrl:nil andAlias:nil andType:BranchLinkTypeUnlimitedUse andMatchDuration:0 andChannel:channel andFeature:BRANCH_FEATURE_TAG_REFERRAL andStage:nil andParams:params andCallback:callback];
-}
 
 #pragma mark - Private methods
 

Branch-SDK/Branch-SDK/BranchConstants.h

@@ -40,7 +40,6 @@ extern NSString * const BRANCH_REQUEST_KEY_HARDWARE_ID_TYPE;
 extern NSString * const BRANCH_REQUEST_KEY_IS_HARDWARE_ID_REAL;
 extern NSString * const BRANCH_REQUEST_KEY_IOS_VENDOR_ID;
 extern NSString * const BRANCH_REQUEST_KEY_AD_TRACKING_ENABLED;
-extern NSString * const BRANCH_REQUEST_KEY_IS_REFERRABLE;
 extern NSString * const BRANCH_REQUEST_KEY_DEBUG;
 extern NSString * const BRANCH_REQUEST_KEY_BUNDLE_ID;
 extern NSString * const BRANCH_REQUEST_KEY_TEAM_ID;

Branch-SDK/Branch-SDK/BranchConstants.m

@@ -40,7 +40,6 @@
 NSString * const BRANCH_REQUEST_KEY_IS_HARDWARE_ID_REAL = @"is_hardware_id_real";
 NSString * const BRANCH_REQUEST_KEY_IOS_VENDOR_ID = @"ios_vendor_id";
 NSString * const BRANCH_REQUEST_KEY_AD_TRACKING_ENABLED = @"ad_tracking_enabled";
-NSString * const BRANCH_REQUEST_KEY_IS_REFERRABLE = @"is_referrable";
 NSString * const BRANCH_REQUEST_KEY_DEBUG = @"debug";
 NSString * const BRANCH_REQUEST_KEY_BUNDLE_ID = @"ios_bundle_id";
 NSString * const BRANCH_REQUEST_KEY_TEAM_ID = @"ios_team_id";

Branch-TestBed/Branch-SDK-Tests/BranchInstallRequestTests.m

@@ -30,7 +30,6 @@ - (void)setUp {
 - (void)testRequestBody {
     NSString * const HARDWARE_ID = @"foo-hardware-id";
     NSNumber * const AD_TRACKING_SAFE = @YES;
-    NSNumber * const IS_REFERRABLE = @YES;
     NSNumber * const IS_DEBUG = @YES;
     NSString * const BUNDLE_ID = @"foo-bundle-id";
     NSString * const APP_VERSION = @"foo-app-version";
@@ -70,7 +69,6 @@ - (void)testRequestBody {
         BRANCH_REQUEST_KEY_APP_VERSION: APP_VERSION,
         BRANCH_REQUEST_KEY_DEBUG: IS_DEBUG,
         BRANCH_REQUEST_KEY_BUNDLE_ID: BUNDLE_ID,
-        BRANCH_REQUEST_KEY_IS_REFERRABLE: IS_REFERRABLE,
         BRANCH_REQUEST_KEY_LINK_IDENTIFIER: LINK_IDENTIFIER,
         BRANCH_REQUEST_KEY_UPDATE: UPDATE_STATE,
         BRANCH_REQUEST_KEY_URI_SCHEME: URI_SCHEME,

Branch-TestBed/Branch-SDK-Tests/BranchOpenRequestTests.m

@@ -32,7 +32,6 @@ - (void)setUp {
 - (void)testRequestBodyWithNoFingerprintID {
     NSString * const HARDWARE_ID = @"foo-hardware-id";
     NSNumber * const AD_TRACKING_SAFE = @YES;
-    NSNumber * const IS_REFERRABLE = @YES;
     NSNumber * const IS_DEBUG = @YES;
     NSString * const BUNDLE_ID = @"foo-bundle-id";
     NSString * const APP_VERSION = @"foo-app-version";
@@ -54,7 +53,6 @@ - (void)testRequestBodyWithNoFingerprintID {
     [[[systemObserverMock stub] andReturn:URI_SCHEME] getDefaultUriScheme];
     [[[systemObserverMock stub] andReturn:UPDATE_STATE] getUpdateState];
 
-    preferenceHelper.isReferrable = [IS_REFERRABLE boolValue];
     preferenceHelper.isDebug = [IS_DEBUG boolValue];
     preferenceHelper.linkClickIdentifier = LINK_IDENTIFIER;
     preferenceHelper.deviceFingerprintID = nil;
@@ -65,7 +63,6 @@ - (void)testRequestBodyWithNoFingerprintID {
         BRANCH_REQUEST_KEY_DEBUG: IS_DEBUG,
         BRANCH_REQUEST_KEY_BRANCH_IDENTITY: IDENTITY_ID,
         BRANCH_REQUEST_KEY_BUNDLE_ID: BUNDLE_ID,
-        BRANCH_REQUEST_KEY_IS_REFERRABLE: IS_REFERRABLE,
         BRANCH_REQUEST_KEY_LINK_IDENTIFIER: LINK_IDENTIFIER,
         BRANCH_REQUEST_KEY_UPDATE: UPDATE_STATE,
         BRANCH_REQUEST_KEY_URI_SCHEME: URI_SCHEME
@@ -83,7 +80,6 @@ - (void)testRequestBodyWithNoFingerprintID {
 - (void)testRequestBodyWithFingerprintID {
     NSString * const HARDWARE_ID = @"foo-hardware-id";
     NSNumber * const AD_TRACKING_SAFE = @YES;
-    NSNumber * const IS_REFERRABLE = @YES;
     NSNumber * const IS_DEBUG = @YES;
     NSString * const BUNDLE_ID = @"foo-bundle-id";
     NSString * const APP_VERSION = @"foo-app-version";
@@ -106,7 +102,6 @@ - (void)testRequestBodyWithFingerprintID {
     [[[systemObserverMock stub] andReturn:URI_SCHEME] getDefaultUriScheme];
     [[[systemObserverMock stub] andReturn:UPDATE_STATE] getUpdateState];
 
-    preferenceHelper.isReferrable = [IS_REFERRABLE boolValue];
     preferenceHelper.explicitlyRequestedReferrable = YES;
     preferenceHelper.isDebug = [IS_DEBUG boolValue];
     preferenceHelper.linkClickIdentifier = LINK_IDENTIFIER;
@@ -118,7 +113,6 @@ - (void)testRequestBodyWithFingerprintID {
         BRANCH_REQUEST_KEY_DEBUG: IS_DEBUG,
         BRANCH_REQUEST_KEY_BRANCH_IDENTITY: IDENTITY_ID,
         BRANCH_REQUEST_KEY_BUNDLE_ID: BUNDLE_ID,
-        BRANCH_REQUEST_KEY_IS_REFERRABLE: IS_REFERRABLE,
         BRANCH_REQUEST_KEY_DEVICE_FINGERPRINT_ID: FINGERPRINT_ID,
         BRANCH_REQUEST_KEY_LINK_IDENTIFIER: LINK_IDENTIFIER,   
         BRANCH_REQUEST_KEY_UPDATE: UPDATE_STATE,