Skip to content

Commit 2456523

Browse files
committed
CORE-1198 rename class
1 parent 9f8e71b commit 2456523

File tree

5 files changed

+26
-26
lines changed

5 files changed

+26
-26
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
@file BNCURLBlackList.h
2+
@file BNCURLFilter.h
33
@package Branch-SDK
44
@brief Manages a list of sensitive URLs such as login data that should not be handled by Branch.
55
@@ -14,7 +14,7 @@
1414
#import <Foundation/Foundation.h>
1515
#endif
1616

17-
@interface BNCURLBlackList : NSObject
17+
@interface BNCURLFilter : NSObject
1818

1919
/**
2020
@brief Checks if a given URL should be ignored (blacklisted).
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
@file BNCURLBlackList.m
2+
@file BNCURLFilter.m
33
@package Branch-SDK
44
@brief Manages a list of URLs that we should ignore.
55
@@ -8,10 +8,10 @@
88
@copyright Copyright © 2018 Branch. All rights reserved.
99
*/
1010

11-
#import "BNCURLBlackList.h"
11+
#import "BNCURLFilter.h"
1212
#import "Branch.h"
1313

14-
@interface BNCURLBlackList () {
14+
@interface BNCURLFilter () {
1515
NSArray<NSString*>*_blackList;
1616
}
1717
@property (strong) NSArray<NSRegularExpression*> *blackListRegex;
@@ -22,7 +22,7 @@ @interface BNCURLBlackList () {
2222
@property (strong) NSURL *blackListJSONURL;
2323
@end
2424

25-
@implementation BNCURLBlackList
25+
@implementation BNCURLFilter
2626

2727
- (instancetype) init {
2828
self = [super init];

Branch-SDK/Branch.m

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
#import "NSString+Branch.h"
3838
#import "Branch+Validator.h"
3939
#import "BNCApplication.h"
40-
#import "BNCURLBlackList.h"
40+
#import "BNCURLFilter.h"
4141
#import "BNCFacebookAppLinks.h"
4242
#import "BNCDeviceInfo.h"
4343
#import "BNCCallbackMap.h"
@@ -123,7 +123,7 @@ typedef NS_ENUM(NSInteger, BNCInitStatus) {
123123

124124
@interface Branch() <BranchDeepLinkingControllerCompletionDelegate> {
125125
NSInteger _networkCount;
126-
BNCURLBlackList *_userURLBlackList;
126+
BNCURLFilter *_userURLBlackList;
127127
}
128128

129129
// This isolation queue protects branch initialization and ensures things are processed in order.
@@ -141,7 +141,7 @@ @interface Branch() <BranchDeepLinkingControllerCompletionDelegate> {
141141
@property (weak, nonatomic) UIViewController *deepLinkPresentingController;
142142
@property (strong, nonatomic) NSDictionary *deepLinkDebugParams;
143143
@property (strong, nonatomic) NSMutableArray *whiteListedSchemeList;
144-
@property (strong, nonatomic) BNCURLBlackList *URLBlackList;
144+
@property (strong, nonatomic) BNCURLFilter *URLBlackList;
145145

146146
#if !TARGET_OS_TV
147147
@property (strong, nonatomic) BNCContentDiscoveryManager *contentDiscoveryManager;
@@ -200,7 +200,7 @@ - (id)initWithInterface:(BNCServerInterface *)interface
200200
#endif
201201

202202
self.class.branchKey = key;
203-
self.URLBlackList = [BNCURLBlackList new];
203+
self.URLBlackList = [BNCURLFilter new];
204204

205205
[BranchOpenRequest setWaitNeededForOpenResponseLock];
206206

@@ -675,7 +675,7 @@ - (void)addWhiteListedScheme:(NSString *)scheme {
675675

676676
- (void)setBlackListURLRegex:(NSArray<NSString*>*)blackListURLs {
677677
@synchronized (self) {
678-
_userURLBlackList = [[BNCURLBlackList alloc] init];
678+
_userURLBlackList = [[BNCURLFilter alloc] init];
679679
_userURLBlackList.blackList = blackListURLs;
680680
}
681681
}

Branch-TestBed/Branch-SDK-Tests/BNCURLBlackList.Test.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
*/
1010

1111
#import "BNCTestCase.h"
12-
#import "BNCURLBlackList.h"
12+
#import "BNCURLFilterList.h"
1313
#import "Branch.h"
1414

15-
@interface BNCURLBlackList ()
15+
@interface BNCURLFilterList ()
1616
@property (readwrite) NSURL *blackListJSONURL;
1717
@end
1818

@@ -33,7 +33,7 @@ - (void) tearDown {
3333

3434
- (void)testListDownLoad {
3535
XCTestExpectation *expectation = [self expectationWithDescription:@"BlackList Download"];
36-
BNCURLBlackList *blackList = [BNCURLBlackList new];
36+
BNCURLFilterList *blackList = [BNCURLFilterList new];
3737
[blackList refreshBlackListFromServerWithCompletion:^ (NSError*error, NSArray*list) {
3838
XCTAssertNil(error);
3939
XCTAssertTrue(list.count == 6);
@@ -80,7 +80,7 @@ - (NSArray*) goodURLs {
8080

8181
- (void)testBadURLs {
8282
// Test default list.
83-
BNCURLBlackList *blackList = [BNCURLBlackList new];
83+
BNCURLFilterList *blackList = [BNCURLFilterList new];
8484
for (NSString *string in self.badURLs) {
8585
NSURL *URL = [NSURL URLWithString:string];
8686
XCTAssertTrue([blackList isBlackListedURL:URL], @"Checking '%@'.", URL);
@@ -90,7 +90,7 @@ - (void)testBadURLs {
9090
- (void) testDownloadBadURLs {
9191
// Test download list.
9292
XCTestExpectation *expectation = [self expectationWithDescription:@"BlackList Download"];
93-
BNCURLBlackList *blackList = [BNCURLBlackList new];
93+
BNCURLFilterList *blackList = [BNCURLFilterList new];
9494
blackList.blackListJSONURL = [NSURL URLWithString:@"https://cdn.branch.io/sdk/uriskiplist_tv1.json"];
9595
[blackList refreshBlackListFromServerWithCompletion:^ (NSError*error, NSArray*list) {
9696
XCTAssertNil(error);
@@ -106,7 +106,7 @@ - (void) testDownloadBadURLs {
106106

107107
- (void)testGoodURLs {
108108
// Test default list.
109-
BNCURLBlackList *blackList = [BNCURLBlackList new];
109+
BNCURLFilterList *blackList = [BNCURLFilterList new];
110110
for (NSString *string in self.goodURLs) {
111111
NSURL *URL = [NSURL URLWithString:string];
112112
XCTAssertFalse([blackList isBlackListedURL:URL], @"Checking '%@'", URL);
@@ -116,7 +116,7 @@ - (void)testGoodURLs {
116116
- (void) testDownloadGoodURLs {
117117
// Test download list.
118118
XCTestExpectation *expectation = [self expectationWithDescription:@"BlackList Download"];
119-
BNCURLBlackList *blackList = [BNCURLBlackList new];
119+
BNCURLFilterList *blackList = [BNCURLFilterList new];
120120
blackList.blackListJSONURL = [NSURL URLWithString:@"https://cdn.branch.io/sdk/uriskiplist_tv1.json"];
121121
[blackList refreshBlackListFromServerWithCompletion:^ (NSError*error, NSArray*list) {
122122
XCTAssertNil(error);

Branch-TestBed/Branch-TestBed.xcodeproj/project.pbxproj

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@
7070
4D8999ED1DC108FF00F7EE0A /* BNCAvailability.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D8999EB1DC108FF00F7EE0A /* BNCAvailability.m */; };
7171
4D8EE7A61E1F0A5D00B1F450 /* BNCCommerceEvent.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D8EE7A41E1F0A5D00B1F450 /* BNCCommerceEvent.m */; };
7272
4D93D8622098D43C00CFABA6 /* UITestSafari.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D93D8602098D43C00CFABA6 /* UITestSafari.m */; };
73-
4D955CCC2035021400FB8008 /* BNCURLBlackList.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D955CCA2035021400FB8008 /* BNCURLBlackList.h */; };
74-
4D955CCD2035021400FB8008 /* BNCURLBlackList.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D955CCB2035021400FB8008 /* BNCURLBlackList.m */; };
73+
4D955CCC2035021400FB8008 /* BNCURLFilter.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D955CCA2035021400FB8008 /* BNCURLFilter.h */; };
74+
4D955CCD2035021400FB8008 /* BNCURLFilter.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D955CCB2035021400FB8008 /* BNCURLFilter.m */; };
7575
4D9607F41FBF9473008AB3C2 /* UIViewController+Branch.h in Headers */ = {isa = PBXBuildFile; fileRef = 4D9607F21FBF9472008AB3C2 /* UIViewController+Branch.h */; settings = {ATTRIBUTES = (Public, ); }; };
7676
4D9607F51FBF9473008AB3C2 /* UIViewController+Branch.m in Sources */ = {isa = PBXBuildFile; fileRef = 4D9607F31FBF9473008AB3C2 /* UIViewController+Branch.m */; };
7777
4DA577181E67B1D600A43BDD /* BNCLog.m in Sources */ = {isa = PBXBuildFile; fileRef = 4DA577161E67B1D600A43BDD /* BNCLog.m */; };
@@ -389,8 +389,8 @@
389389
4D93D8592098CC4400CFABA6 /* README.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = README.md; sourceTree = "<group>"; };
390390
4D93D85F2098D43C00CFABA6 /* Info.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
391391
4D93D8602098D43C00CFABA6 /* UITestSafari.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = UITestSafari.m; sourceTree = "<group>"; };
392-
4D955CCA2035021400FB8008 /* BNCURLBlackList.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BNCURLBlackList.h; sourceTree = "<group>"; };
393-
4D955CCB2035021400FB8008 /* BNCURLBlackList.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCURLBlackList.m; sourceTree = "<group>"; };
392+
4D955CCA2035021400FB8008 /* BNCURLFilter.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = BNCURLFilter.h; sourceTree = "<group>"; };
393+
4D955CCB2035021400FB8008 /* BNCURLFilter.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = BNCURLFilter.m; sourceTree = "<group>"; };
394394
4D9607F21FBF9472008AB3C2 /* UIViewController+Branch.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = "UIViewController+Branch.h"; sourceTree = "<group>"; };
395395
4D9607F31FBF9473008AB3C2 /* UIViewController+Branch.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = "UIViewController+Branch.m"; sourceTree = "<group>"; };
396396
4DA577151E67B1D600A43BDD /* BNCLog.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = BNCLog.h; sourceTree = "<group>"; };
@@ -974,8 +974,8 @@
974974
F185BAA91F3D30D70056300C /* BNCSpotlightService.m */,
975975
4D7881F6209CF28E002B750F /* BNCThreads.h */,
976976
4D7881F5209CF28E002B750F /* BNCThreads.m */,
977-
4D955CCA2035021400FB8008 /* BNCURLBlackList.h */,
978-
4D955CCB2035021400FB8008 /* BNCURLBlackList.m */,
977+
4D955CCA2035021400FB8008 /* BNCURLFilter.h */,
978+
4D955CCB2035021400FB8008 /* BNCURLFilter.m */,
979979
670016BD1946309100A9E103 /* Branch.h */,
980980
670016BE1946309100A9E103 /* Branch.m */,
981981
5FE276AD2432705B00EA1BD2 /* BNCInitSessionResponse.h */,
@@ -1047,7 +1047,7 @@
10471047
5F38021024DCC2E800E6FAFD /* BranchCloseRequest.h in Headers */,
10481048
5FDB04ED24E4D23300F2F267 /* BNCSKAdNetwork.h in Headers */,
10491049
5F5EC45B2374D95300AAAFC7 /* BNCAppleAdClient.h in Headers */,
1050-
4D955CCC2035021400FB8008 /* BNCURLBlackList.h in Headers */,
1050+
4D955CCC2035021400FB8008 /* BNCURLFilter.h in Headers */,
10511051
5F38023824DCC2E800E6FAFD /* BranchContentDiscoverer.h in Headers */,
10521052
5F38023324DCC2E800E6FAFD /* BranchContentDiscoveryManifest.h in Headers */,
10531053
5F38023724DCC2E800E6FAFD /* BNCServerRequest.h in Headers */,
@@ -1415,7 +1415,7 @@
14151415
4D9607F51FBF9473008AB3C2 /* UIViewController+Branch.m in Sources */,
14161416
4D35141C1E3201D80085EBA1 /* NSMutableDictionary+Branch.m in Sources */,
14171417
5F92B23A2383703700CA909B /* BNCLocale.m in Sources */,
1418-
4D955CCD2035021400FB8008 /* BNCURLBlackList.m in Sources */,
1418+
4D955CCD2035021400FB8008 /* BNCURLFilter.m in Sources */,
14191419
466B58681B17779C00A69EDE /* BNCLinkData.m in Sources */,
14201420
5F437E36237DDF770052064B /* BNCTelephony.m in Sources */,
14211421
5F892ED8236258390023AEC1 /* BNCFacebookAppLinks.m in Sources */,

0 commit comments

Comments
 (0)