Merge pull request #993 from BranchMetrics/INTENG-8456-sharesheet-option2

INTENG-8456 allow overriding the placeholder url

Author: echo-branch

Branch-SDK/Branch-SDK/BranchShareLink.h

@@ -86,7 +86,12 @@ Presents a UIActivityViewController that shares the Branch link.
 ///The title for the share sheet.
 @property (nonatomic, strong) NSString*_Nullable title;
 
-///Share text for the item.
+// Override the default placeholder URL
+// iOS 13+ fetches a preview header icon, text and domain name from this URL.
+// By default, we use the Branch bnc.lt link, but if you wish more control override it here.
+@property (nonatomic, strong, nullable) NSURL *placeholderURL;
+
+///Share text for the item.  This is not the text in the iOS 13+ preview header.
 ///This text can be changed later when the `branchShareSheetWillShare:` delegate method is called.
 @property (nonatomic, strong) NSString*_Nullable shareText;
 

Branch-SDK/Branch-SDK/BranchShareLink.m

@@ -134,19 +134,29 @@ - (void) shareDidComplete:(BOOL)completed activityError:(NSError*)error {
         [_activityItems addObject:item];
     }
 
-    NSString *URLString =
-        [[Branch getInstance]
-            getLongURLWithParams:self.serverParameters
-            andChannel:self.linkProperties.channel
-            andTags:self.linkProperties.tags
-            andFeature:self.linkProperties.feature
-            andStage:self.linkProperties.stage
-            andAlias:self.linkProperties.alias];
-    self.shareURL = [[NSURL alloc] initWithString:URLString];
-    if (self.returnURL)
+    if (self.placeholderURL) {
+        // use user provided placeholder url
+        self.shareURL = self.placeholderURL;
+    } else {
+        
+        // use long link as the placeholder url
+        NSString *URLString =
+            [[Branch getInstance]
+                getLongURLWithParams:self.serverParameters
+                andChannel:self.linkProperties.channel
+                andTags:self.linkProperties.tags
+                andFeature:self.linkProperties.feature
+                andStage:self.linkProperties.stage
+                andAlias:self.linkProperties.alias];
+        self.shareURL = [[NSURL alloc] initWithString:URLString];
+    }
+    
+    if (self.returnURL) {
         item = [[BranchShareActivityItem alloc] initWithPlaceholderItem:self.shareURL];
-    else
+    } else {
         item = [[BranchShareActivityItem alloc] initWithPlaceholderItem:self.shareURL.absoluteString];
+    }
+    
     item.itemType = BranchShareActivityItemTypeBranchURL;
     item.parent = self;
     [_activityItems addObject:item];

Branch-TestBed/Branch-TestBed/AppDelegate.m

@@ -32,7 +32,7 @@ - (BOOL)application:(UIApplication *)application
 
 
     // test pre init support
-//    [self testDispatchToIsolationQueue:branch]
+    //[self testDispatchToIsolationQueue:branch]
 
     // Comment out (for match guarantee testing) / or un-comment to toggle debugging:
     // Note: Unit tests will fail if 'setDebug' is set.
@@ -42,7 +42,7 @@ - (BOOL)application:(UIApplication *)application
     //[branch validateSDKIntegration];
 
     // Check for Apple Search Ad attribution (trade-off: slows down app startup):
-    [branch delayInitToCheckForSearchAds];
+    //[branch delayInitToCheckForSearchAds];
 
     /*
      *    Required: Initialize Branch, passing a deep link handler block:
@@ -61,10 +61,10 @@ - (BOOL)application:(UIApplication *)application
     return YES;
 }
 
-// pre init support is meant for extensions, for exmaple, when Adobe axtension needs to pass in Adobe IDs
+// pre init support is meant for extensions, for example, when Adobe axtension needs to pass in Adobe IDs
 // before init session is called. This method will block the queue used by open/install requests until the
 // the passsed in block completes
-- (void) testDispatchToIsolationQueue:(Branch*)branch {
+- (void)testDispatchToIsolationQueue:(Branch *)branch {
     [branch dispatchToIsolationQueue:^{
         dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
         dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(2 * NSEC_PER_SEC)),