Silenced some code analyzer warnings. (#792)

* Silenced some code analyzer warnings.

Author: E-B-Smith

Branch-SDK/Branch-SDK/BNCCommerceEvent.m

@@ -237,7 +237,7 @@ - (NSMutableDictionary*) dictionary {
 	NSMutableDictionary *dictionary = [NSMutableDictionary dictionary];
 
 	#define assign(x) \
-		do { if (self.x) { dictionary[@#x] = self.x; } } while (0)
+		do { if (self.x != nil) { dictionary[@#x] = self.x; } } while (0)
 
 	assign(sku);
 	assign(name);

Branch-SDK/Branch-SDK/BNCFieldDefines.h

@@ -149,7 +149,7 @@
     }
 
     #define addNumber(field, name) { \
-        if (self.field) { \
+        if (self.field != nil) { \
             dictionary[@#name] = self.field; \
         } \
     }

Branch-SDK/Branch-SDK/BNCPreferenceHelper.m

@@ -801,7 +801,7 @@ - (BOOL)readBoolFromDefaults:(NSString *)key {
 - (NSInteger)readIntegerFromDefaults:(NSString *)key {
     @synchronized(self) {
         NSNumber *number = self.persistenceDict[key];
-        if (number) {
+        if (number != nil) {
             return [number integerValue];
         }
         return NSNotFound;

Branch-SDK/Branch-SDK/Networking/BNCNetworkService.h

@@ -33,12 +33,12 @@
 #pragma mark - BNCNetworkService
 
 @interface BNCNetworkService : NSObject <BNCNetworkServiceProtocol>
-+ (id<BNCNetworkServiceProtocol>) new;
++ (instancetype) new;
 
 - (void) cancelAllOperations;
 
 - (BNCNetworkOperation*) networkOperationWithURLRequest:(NSMutableURLRequest*)request
-                completion:(void (^)(BNCNetworkOperation*operation))completion;
+                completion:(void (^)(id<BNCNetworkOperationProtocol>operation))completion;
 
 - (NSError*) pinSessionToPublicSecKeyRefs:(NSArray/**<SecKeyRef>*/*)publicKeys;
 

Branch-SDK/Branch-SDK/Networking/BNCNetworkService.m

@@ -75,7 +75,7 @@ - (NSString*) stringFromResponseData {
 
 @implementation BNCNetworkService
 
-+ (id<BNCNetworkServiceProtocol>) new {
++ (instancetype) new {
     return [[self alloc] init];
 }
 
@@ -173,7 +173,7 @@ - (BOOL) operationsAreSuspended {
 #pragma mark - Operations
 
 - (BNCNetworkOperation*) networkOperationWithURLRequest:(NSMutableURLRequest*)request
-                completion:(void (^)(BNCNetworkOperation*operation))completion {
+                completion:(void (^)(id<BNCNetworkOperationProtocol>operation))completion {
 
     BNCNetworkOperation *operation = [BNCNetworkOperation new];
     if (![request isKindOfClass:[NSMutableURLRequest class]]) {