SDK-1741 Fix early return on iOS 15.4 when checking SKAN

echo-branch · echo-branch · commit 5afc6b763fa1 · 2022-12-16T17:52:31.000-08:00
diff --git a/Branch-SDK/BranchEvent.m b/Branch-SDK/BranchEvent.m
@@ -98,7 +98,6 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
                         } else {
                             BNCLogDebug([NSString stringWithFormat:@"Update conversion value was successful. Conversion Value - %@", conversionValue]);
                         }
-                        return;
                     }];
                 }
                 
@@ -109,9 +108,7 @@ - (void)processResponse:(BNCServerResponse*)response error:(NSError*)error {
                     } else {
                         BNCLogDebug([NSString stringWithFormat:@"Update conversion value was successful. Conversion Value - %@", conversionValue]);
                     }
-                    return;
                 }];
-                return;
             } else {
                 [[BNCSKAdNetwork sharedInstance] updateConversionValue:conversionValue.integerValue];
             }
diff --git a/Branch-TestBed/Branch-TestBed.xcodeproj/Branch-TestBed.xctestplan b/Branch-TestBed/Branch-TestBed.xcodeproj/Branch-TestBed.xctestplan
@@ -30,8 +30,7 @@
         "resolvedPath" : "..\/Simulate-FirstRun.xcappdata"
       },
       "skippedTests" : [
-        "BNCAppleAdClientTests",
-        "BNCAppleSearchAdsTests"
+        "BNCServerInterfaceTests"
       ],
       "target" : {
         "containerPath" : "container:Branch-TestBed.xcodeproj",

Original file line number	Diff line number	Diff line change
`@@ -98,7 +98,6 @@ - (void)processResponse:(BNCServerResponse)response error:(NSError)error {`
`98`	`98`	`} else {`
`99`	`99`	`BNCLogDebug([NSString stringWithFormat:@"Update conversion value was successful. Conversion Value - %@", conversionValue]);`
`100`	`100`	`}`
`101`		`- return;`
`102`	`101`	`}];`
`103`	`102`	`}`
`104`	`103`
`@@ -109,9 +108,7 @@ - (void)processResponse:(BNCServerResponse)response error:(NSError)error {`
`109`	`108`	`} else {`
`110`	`109`	`BNCLogDebug([NSString stringWithFormat:@"Update conversion value was successful. Conversion Value - %@", conversionValue]);`
`111`	`110`	`}`
`112`		`- return;`
`113`	`111`	`}];`
`114`		`- return;`
`115`	`112`	`} else {`
`116`	`113`	`[[BNCSKAdNetwork sharedInstance] updateConversionValue:conversionValue.integerValue];`
`117`	`114`	`}`